)]}'
{"id":"openocd~master~I08fdd2a806c350d061641e28cf15a51b397db099","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001667":{"account":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"last_update":"2022-09-20 05:50:16.000000000","reason":"Jan Matyas replied on the change"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-09-23 21:24:49.000000000","reason":"Change was submitted"},"1001242":{"account":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"last_update":"2022-09-19 16:30:06.000000000","reason":"Tim Newsome replied on the change"}},"hashtags":[],"change_id":"I08fdd2a806c350d061641e28cf15a51b397db099","subject":"target/riscv: fix undefined operation","status":"MERGED","created":"2022-09-19 13:51:13.000000000","updated":"2022-09-23 21:24:49.000000000","submitted":"2022-09-23 21:24:49.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7209","meta_rev_id":"fa5a6d1077f1bcdf48645a196ec203a329e92ac5","_number":7209,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-09-23 21:24:49.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-09-23 21:24:49.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-09-23 21:24:49.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-09-19 13:51:13.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"state":"REVIEWER"},{"updated":"2022-09-19 13:51:13.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"state":"REVIEWER"},{"updated":"2022-09-19 19:18:12.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"13cdf9ea7dd275c50bcccd072332663dc5416be5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-19 13:51:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3d68516f24c68dc2f656ce6b865f09d1ec88c51f","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2022-09-19 16:30:06.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"7d4e85f3c9c4e588b1ce084999a400f889fd52fc","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-09-19 19:18:12.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15960/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16751/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"0881db4ff3820e59d8314d18aceda18f228711e2","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2022-09-20 05:50:16.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"fa5a6d1077f1bcdf48645a196ec203a329e92ac5","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-23 21:24:49.000000000","message":"Change has been successfully cherry-picked as fd2a44ab55e7c54ee9e594717aba72d04e85e716","accounts_in_message":[],"_revision_number":2}],"current_revision":"fd2a44ab55e7c54ee9e594717aba72d04e85e716","revisions":{"fd2a44ab55e7c54ee9e594717aba72d04e85e716":{"kind":"REWORK","_number":2,"created":"2022-09-23 21:24:49.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/09/7209/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/09/7209/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/09/7209/2 \u0026\u0026 git checkout -b change-7209 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/09/7209/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/09/7209/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/09/7209/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/09/7209/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/09/7209/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"aff48a6a31019af17959a7da33909d1cea6de61a","subject":"target/riscv: fix dead assignment"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-19 13:28:15.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-23 21:24:49.000000000","tz":0},"subject":"target/riscv: fix undefined operation","message":"target/riscv: fix undefined operation\n\nScan-build reports:\n\tLogic error: Result of operation is garbage or undefined\n\triscv.c:1614 The result of the left shift is undefined due\n\t\tto shifting by \u00274294967281\u0027, which is greater or\n\t\tequal to the width of type \u0027target_addr_t\u0027\n\nThis is a false warning due to clang that considers the impossible\ncase of 32 bits hart (xlen \u003d 32) in SATP_MODE_SV48 mode\n(info-\u003eva_bits \u003d 48).\nUnder such case:\n\triscv.c:1614 ... ((target_addr_t)1 \u003c\u003c (xlen - (info-\u003eva_bits - 1))) ...\nthe shift amount wraps around the unsigned type and assumes the\nvalue 4294967281 (0xfffffff1).\n\nUse assert() to prevent clang from complaining.\n\nChange-Id: I08fdd2a806c350d061641e28cf15a51b397db099\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7209\nReviewed-by: Tim Newsome \u003ctim@sifive.com\u003e\nReviewed-by: Jan Matyas \u003cmatyas@codasip.com\u003e\nTested-by: jenkins\n"}},"b041b79278792258a82a9126fa9e1d6452714f74":{"kind":"REWORK","_number":1,"created":"2022-09-19 13:51:13.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/09/7209/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/09/7209/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/09/7209/1 \u0026\u0026 git checkout -b change-7209 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/09/7209/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/09/7209/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/09/7209/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/09/7209/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/09/7209/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ed6edb277397d451e18e228d7a5924b0d587b794","subject":"target/riscv: fix dead assignment"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-19 13:28:15.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-19 13:48:05.000000000","tz":120},"subject":"target/riscv: fix undefined operation","message":"target/riscv: fix undefined operation\n\nScan-build reports:\n\tLogic error: Result of operation is garbage or undefined\n\triscv.c:1614 The result of the left shift is undefined due\n\t\tto shifting by \u00274294967281\u0027, which is greater or\n\t\tequal to the width of type \u0027target_addr_t\u0027\n\nThis is a false warning due to clang that considers the impossible\ncase of 32 bits hart (xlen \u003d 32) in SATP_MODE_SV48 mode\n(info-\u003eva_bits \u003d 48).\nUnder such case:\n\triscv.c:1614 ... ((target_addr_t)1 \u003c\u003c (xlen - (info-\u003eva_bits - 1))) ...\nthe shift amount wraps around the unsigned type and assumes the\nvalue 4294967281 (0xfffffff1).\n\nUse assert() to prevent clang from complaining.\n\nChange-Id: I08fdd2a806c350d061641e28cf15a51b397db099\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}