)]}'
{"id":"openocd~master~I62e031220593b8308bc674b753e15d16d4c5c9ac","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001667":{"account":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"last_update":"2022-09-20 07:48:25.000000000","reason":"Jan Matyas replied on the change"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-09-23 21:25:08.000000000","reason":"Change was submitted"},"1001242":{"account":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"last_update":"2022-09-20 16:59:23.000000000","reason":"Tim Newsome replied on the change"}},"hashtags":[],"change_id":"I62e031220593b8308bc674b753e15d16d4c5c9ac","subject":"target/riscv: fix use of uninitialized value","status":"MERGED","created":"2022-09-19 13:51:13.000000000","updated":"2022-09-23 21:25:08.000000000","submitted":"2022-09-23 21:25:08.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7210","meta_rev_id":"fa8f7546abc83426a2f848ba21548b10a9c83b7d","_number":7210,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-09-23 21:25:08.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-09-23 21:25:08.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-09-23 21:25:08.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-09-23 21:25:08.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-09-19 13:51:13.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"state":"REVIEWER"},{"updated":"2022-09-19 13:51:13.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"state":"REVIEWER"},{"updated":"2022-09-19 19:40:59.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"66a01159a7d5b35819017734476a9ef5ae062e2e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-19 13:51:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fa864fdfc6d721183edc689ed30af14eb8dcc887","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2022-09-19 16:20:42.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"29b60256bcbad64634fc3ed0d572f08e06abfd18","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-09-19 19:40:59.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15961/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16752/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"efe6748987490fc751e38d94105633c4d84a833c","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2022-09-20 07:48:25.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"372b17e0454ce305e175fbee08f61dd9aee8dc26","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-20 10:26:37.000000000","message":"Patch Set 1: Code-Review+2\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"11f53958537129ba583c29aaa7d2b6f5776b435e","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2022-09-20 16:59:23.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"fa8f7546abc83426a2f848ba21548b10a9c83b7d","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-23 21:25:08.000000000","message":"Change has been successfully cherry-picked as 44ed26a1db3b9e0ca9dc1000e967533b1c371ee3","accounts_in_message":[],"_revision_number":2}],"current_revision":"44ed26a1db3b9e0ca9dc1000e967533b1c371ee3","revisions":{"44ed26a1db3b9e0ca9dc1000e967533b1c371ee3":{"kind":"REWORK","_number":2,"created":"2022-09-23 21:25:08.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/10/7210/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/10/7210/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/10/7210/2 \u0026\u0026 git checkout -b change-7210 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/10/7210/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/10/7210/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/10/7210/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/10/7210/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/10/7210/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"fd2a44ab55e7c54ee9e594717aba72d04e85e716","subject":"target/riscv: fix undefined operation"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-19 13:39:50.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-23 21:25:08.000000000","tz":0},"subject":"target/riscv: fix use of uninitialized value","message":"target/riscv: fix use of uninitialized value\n\nScan-build reports:\n\tLogic error: Uninitialized argument value\n\triscv.c:2688 2nd function call argument is an uninitialized value\n\nThis is a real error cause by running the command \"riscv\nauthdata_write\" without arguments. In such case \u0027value\u0027 is not\ninitialized and is passed to and used by r-\u003eauthdata_write().\n\nReorganize the code to:\n- detect the correct amount or command\u0027s arguments;\n- drop the LOG_ERROR() on ERROR_COMMAND_SYNTAX_ERROR;\n- drop the \u0027else\u0027 after \u0027return\u0027.\n\nChange-Id: I62e031220593b8308bc674b753e15d16d4c5c9ac\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7210\nTested-by: jenkins\nReviewed-by: Jan Matyas \u003cmatyas@codasip.com\u003e\nReviewed-by: Tim Newsome \u003ctim@sifive.com\u003e\n"}},"b88e7232f6e527771b4f077dc819b90388e07b91":{"kind":"REWORK","_number":1,"created":"2022-09-19 13:51:13.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/10/7210/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/10/7210/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/10/7210/1 \u0026\u0026 git checkout -b change-7210 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/10/7210/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/10/7210/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/10/7210/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/10/7210/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/10/7210/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b041b79278792258a82a9126fa9e1d6452714f74","subject":"target/riscv: fix undefined operation"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-19 13:39:50.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-19 13:48:05.000000000","tz":120},"subject":"target/riscv: fix use of uninitialized value","message":"target/riscv: fix use of uninitialized value\n\nScan-build reports:\n\tLogic error: Uninitialized argument value\n\triscv.c:2688 2nd function call argument is an uninitialized value\n\nThis is a real error cause by running the command \"riscv\nauthdata_write\" without arguments. In such case \u0027value\u0027 is not\ninitialized and is passed to and used by r-\u003eauthdata_write().\n\nReorganize the code to:\n- detect the correct amount or command\u0027s arguments;\n- drop the LOG_ERROR() on ERROR_COMMAND_SYNTAX_ERROR;\n- drop the \u0027else\u0027 after \u0027return\u0027.\n\nChange-Id: I62e031220593b8308bc674b753e15d16d4c5c9ac\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}