)]}'
{"id":"openocd~master~I514cd6d9ae2ba97ce3657b459df22638c278a0b1","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-09-20 21:28:50.000000000","reason":"Antonio Borneo replied on the change"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2022-09-27 07:10:55.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I514cd6d9ae2ba97ce3657b459df22638c278a0b1","subject":"target/adi_v5_swd: fix SWD multidrop","status":"MERGED","created":"2022-09-20 17:11:46.000000000","updated":"2022-09-27 08:28:44.000000000","submitted":"2022-09-27 08:28:44.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7213","meta_rev_id":"5f0077a6847024ad4c21e0ea0a486ac262a0098a","_number":7213,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-09-27 08:28:44.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-09-27 08:28:44.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-09-27 08:28:44.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-09-27 08:28:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"}],"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-09-20 17:37:41.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-09-20 18:04:30.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2022-09-21 10:10:10.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"state":"CC"},{"updated":"2022-09-26 16:05:52.000000000","updated_by":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},"reviewer":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},"state":"REVIEWER"}],"messages":[{"id":"139af12f1c2c5e3a77a1327daa535fe259d5f976","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-09-20 17:11:46.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ff7c545e8ce8d685aa43c6be3dd5ac936c568b16","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-09-20 17:37:41.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15975/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16765/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"26776630b1f40730203395bebe121dba0c3e0f87","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-20 21:28:50.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"5e2d47bb5475e3908e727ac07a1d6ea5a9ce8050","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-09-21 06:56:50.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"935790af6d769b7ae2f53dce6fec4aa721ae6d0f","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-21 10:10:10.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"4bd1d3e5d022310c50cdf6de04decbf8726aeb97","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-09-21 11:48:51.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"a4d7256ed6fb04c46dd65d0ab268c1d75c3b5f01","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-09-21 12:40:58.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"abd5fdd8d0353fa25d56dc085a60ed9a2d001e9d","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-09-21 14:12:58.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15983/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16775/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"46ded2691a4d875e22004410abe4cec7615913ba","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-21 15:23:34.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"e94d9fd112740280dd23f32872ff37e34de31d03","author":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},"real_author":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},"date":"2022-09-26 16:05:52.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"67bd8a50e963a08f129764e2eb5777cd61a7f96a","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-09-27 07:10:55.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"5f0077a6847024ad4c21e0ea0a486ac262a0098a","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-09-27 08:28:44.000000000","message":"Change has been successfully cherry-picked as b2f6b231177240af6693340e4e00d16c1e512692","accounts_in_message":[],"_revision_number":3}],"current_revision":"b2f6b231177240af6693340e4e00d16c1e512692","revisions":{"a2a952cd9e6780f0080d2cfa771da214bc3676c8":{"kind":"REWORK","_number":2,"created":"2022-09-21 12:40:58.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/13/7213/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/13/7213/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/13/7213/2 \u0026\u0026 git checkout -b change-7213 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/13/7213/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/13/7213/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/13/7213/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/13/7213/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/13/7213/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b89cf71e2b5e4dc2c31cf085aec7a19515e2a9d6","subject":"Restore +dev suffix"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-09-20 16:55:51.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-09-21 11:53:23.000000000","tz":120},"subject":"target/adi_v5_swd: fix SWD multidrop","message":"target/adi_v5_swd: fix SWD multidrop\n\nImplementation of ADI v6 introduced banking of DP reg 0.\nThe accompanying change preventing DP SELECT write before\nDP IDR read during connect was added to swd_connect_single() only.\nUnchanged swd_connect_multidrop() / swd_multidrop_select_inner()\nwas broken as it emited DP SELECT and put DP to protocol error state.\n\nCopy dap-\u003eselect handling to swd_multidrop_select_inner().\n\nFixes: 72fb88613f02 (adiv6: add low level swd transport)\n\nChange-Id: I514cd6d9ae2ba97ce3657b459df22638c278a0b1\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"b2f6b231177240af6693340e4e00d16c1e512692":{"kind":"REWORK","_number":3,"created":"2022-09-27 08:28:44.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/13/7213/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/13/7213/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/13/7213/3 \u0026\u0026 git checkout -b change-7213 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/13/7213/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/13/7213/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/13/7213/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/13/7213/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/13/7213/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"60abbda8bcb19e26e073605ec43fdd0f42416567","subject":"target/stm32l5x,stm32u5x: fix trace settings"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-09-20 16:55:51.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-09-27 08:28:44.000000000","tz":0},"subject":"target/adi_v5_swd: fix SWD multidrop","message":"target/adi_v5_swd: fix SWD multidrop\n\nImplementation of ADI v6 introduced banking of DP reg 0.\nThe accompanying change preventing DP SELECT write before\nDP IDR read during connect was added to swd_connect_single() only.\nUnchanged swd_connect_multidrop() / swd_multidrop_select_inner()\nwas broken as it emited DP SELECT and put DP to protocol error state.\n\nCopy dap-\u003eselect handling to swd_multidrop_select_inner().\n\nFixes: 72fb88613f02 (adiv6: add low level swd transport)\n\nChange-Id: I514cd6d9ae2ba97ce3657b459df22638c278a0b1\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7213\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-by: Jonathan Bell \u003cjonathan@raspberrypi.com\u003e\n"}},"bd8ca58f1922f823c2337b5324b84f9cf2b26bdd":{"kind":"REWORK","_number":1,"created":"2022-09-20 17:11:46.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/13/7213/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/13/7213/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/13/7213/1 \u0026\u0026 git checkout -b change-7213 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/13/7213/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/13/7213/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/13/7213/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/13/7213/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/13/7213/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b89cf71e2b5e4dc2c31cf085aec7a19515e2a9d6","subject":"Restore +dev suffix"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-09-20 16:55:51.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-09-20 16:55:51.000000000","tz":120},"subject":"target/adi_v5_swd: fix SWD multidrop","message":"target/adi_v5_swd: fix SWD multidrop\n\nImplementation of ADI v6 introduced banking of DP reg 0.\nThe accompanying change preventing DP SELECT write before\nDP IDR read during connect was added to swd_connect_single() only.\nUnchanged swd_connect_multidrop() / swd_multidrop_select_inner()\nwas broken as it emited DP SELECT and put DP to protocol error state.\n\nCopy dap-\u003eselect handling to swd_multidrop_select_inner().\n\nFixes: 72fb88613f02 (adiv6: add low level swd transport)\n\nChange-Id: I514cd6d9ae2ba97ce3657b459df22638c278a0b1\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}