)]}'
{"src/flash/nor/rp2040.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d8a68bbafeb39954ac0cdc1ed873648460c4d633","unresolved":true,"context_lines":[{"line_number":153,"context_line":"\t * chip select following a rp2040_flash_exit_xip()."},{"line_number":154,"context_line":"\t */"},{"line_number":155,"context_line":"\tLOG_DEBUG(\"Flushing flash cache after write behind\");"},{"line_number":156,"context_line":"\tint err \u003d rp2040_call_rom_func(target, priv, priv-\u003ejump_flush_cache, NULL, 0, 1000);"},{"line_number":157,"context_line":"\tif (err !\u003d ERROR_OK) {"},{"line_number":158,"context_line":"\t\tLOG_ERROR(\"Failed to flush flash cache\");"},{"line_number":159,"context_line":"\t\t/* Intentionally continue after error and try to setup xip anyway */"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"2bbe9b4e_f388d95f","line":156,"updated":"2022-09-21 16:24:02.000000000","message":"To improve readability, can you define and use some macro with e.g. names ?\n#define TIMEOUT_FAST_MS 1000\n#define TIMEOUT_SLOW_MS 3000","commit_id":"b02eec297a28758b7c9dca1e2af61d2349d0389f"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"d70d0194d0fa76aef52758bf2190913e4b30374f","unresolved":true,"context_lines":[{"line_number":153,"context_line":"\t * chip select following a rp2040_flash_exit_xip()."},{"line_number":154,"context_line":"\t */"},{"line_number":155,"context_line":"\tLOG_DEBUG(\"Flushing flash cache after write behind\");"},{"line_number":156,"context_line":"\tint err \u003d rp2040_call_rom_func(target, priv, priv-\u003ejump_flush_cache, NULL, 0, 1000);"},{"line_number":157,"context_line":"\tif (err !\u003d ERROR_OK) {"},{"line_number":158,"context_line":"\t\tLOG_ERROR(\"Failed to flush flash cache\");"},{"line_number":159,"context_line":"\t\t/* Intentionally continue after error and try to setup xip anyway */"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"be70c689_d4179d4e","line":156,"in_reply_to":"2bbe9b4e_f388d95f","updated":"2022-09-21 18:47:17.000000000","message":"Hmm, if I see TIMEOUT_FAST_MS I don\u0027t know how long it takes and I\u0027m forced to search for #define. This is exactly same effort as looking up rp2040_call_rom_func() declaration to see the last parameter is named timeout_ms.\nIf there were 4 functions of similar type, then yes, let\u0027s define one common timeout.\nBut there are 4 completely different functions which may require potentially different timeouts.\nFeel free to #define perhaps any number, but please do it yourself.","commit_id":"b02eec297a28758b7c9dca1e2af61d2349d0389f"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"6481e2ceddbf45d853640fbc7d1be4a117c4dfc7","unresolved":false,"context_lines":[{"line_number":153,"context_line":"\t * chip select following a rp2040_flash_exit_xip()."},{"line_number":154,"context_line":"\t */"},{"line_number":155,"context_line":"\tLOG_DEBUG(\"Flushing flash cache after write behind\");"},{"line_number":156,"context_line":"\tint err \u003d rp2040_call_rom_func(target, priv, priv-\u003ejump_flush_cache, NULL, 0, 1000);"},{"line_number":157,"context_line":"\tif (err !\u003d ERROR_OK) {"},{"line_number":158,"context_line":"\t\tLOG_ERROR(\"Failed to flush flash cache\");"},{"line_number":159,"context_line":"\t\t/* Intentionally continue after error and try to setup xip anyway */"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"f0d1925a_f2695f50","line":156,"in_reply_to":"be70c689_d4179d4e","updated":"2022-09-23 22:40:12.000000000","message":"And datasheet does not provide max values, so this could be updated later on ... ok","commit_id":"b02eec297a28758b7c9dca1e2af61d2349d0389f"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d8a68bbafeb39954ac0cdc1ed873648460c4d633","unresolved":false,"context_lines":[{"line_number":295,"context_line":""},{"line_number":296,"context_line":"\tint timeout_ms \u003d 2000 * (last - first) + 1000;"},{"line_number":297,"context_line":"\terr \u003d rp2040_call_rom_func(bank-\u003etarget, priv, priv-\u003ejump_flash_range_erase,"},{"line_number":298,"context_line":"\t\t\t\t\t\t\targs, ARRAY_SIZE(args), timeout_ms);"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"cleanup:"},{"line_number":301,"context_line":"\trp2040_finalize_stack_free(bank);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"5c9106b0_e546d8ea","line":298,"updated":"2022-09-21 16:24:02.000000000","message":"here no need to use macros, as the name of the variable already explains it.","commit_id":"b02eec297a28758b7c9dca1e2af61d2349d0389f"}]}