)]}'
{"id":"openocd~master~I552bfa317ee17064de3a54ec2f0c63e84ba87222","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-09-23 22:40:12.000000000","reason":"Antonio Borneo replied on the change"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2022-09-27 07:13:21.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I552bfa317ee17064de3a54ec2f0c63e84ba87222","subject":"flash/nor/rp2040: fix flash erase timeout","status":"MERGED","created":"2022-09-21 06:45:13.000000000","updated":"2022-09-27 08:41:54.000000000","submitted":"2022-09-27 08:41:54.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7214","meta_rev_id":"cfdb8eaba43c9583931b768d4d27c6f4b7114aef","_number":7214,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-09-27 08:41:54.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-09-27 08:41:54.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-09-27 08:41:54.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-09-27 08:41:54.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-09-21 09:15:33.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-09-21 16:24:02.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2022-09-23 22:40:12.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2022-09-26 16:04:09.000000000","updated_by":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},"reviewer":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},"state":"REVIEWER"}],"messages":[{"id":"d5f2bdc24ccc712f2c10c4397a2cdaf613a4e986","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-09-21 06:45:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"804062add143ade948ebb07cc11271cc8fdfeed7","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-09-21 09:15:33.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15979/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16768/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"129c4a4531ef0c63dad8200bf269b96d85108be3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-09-21 12:40:58.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"d8a68bbafeb39954ac0cdc1ed873648460c4d633","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-21 16:24:02.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"520f744a7b0e6a3ff13295d7a5c4483ea27df286","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-09-21 17:20:04.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15989/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16779/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"d70d0194d0fa76aef52758bf2190913e4b30374f","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-09-21 18:47:17.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"6481e2ceddbf45d853640fbc7d1be4a117c4dfc7","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-23 22:40:12.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"a11bb4cd4eaf7d43685c890f0bcd32e0b39f928f","author":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},"real_author":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},"date":"2022-09-26 16:04:09.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"0e4450edc33cdbb6d3f2f31831b859b3cfc6fa78","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-09-27 07:13:21.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"cfdb8eaba43c9583931b768d4d27c6f4b7114aef","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-09-27 08:41:54.000000000","message":"Change has been successfully cherry-picked as 53611d8055d1130a925010b3feb39c7c8fa20a14","accounts_in_message":[],"_revision_number":3}],"current_revision":"53611d8055d1130a925010b3feb39c7c8fa20a14","revisions":{"53611d8055d1130a925010b3feb39c7c8fa20a14":{"kind":"REWORK","_number":3,"created":"2022-09-27 08:41:54.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/14/7214/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/14/7214/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/14/7214/3 \u0026\u0026 git checkout -b change-7214 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/14/7214/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/14/7214/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/14/7214/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/14/7214/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/14/7214/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"84d73d0225407594ed9cf646fa3dd8a5752df7ad","subject":"flash/nor/rp2040: fix size of flash write buffer"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-09-21 04:32:21.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-09-27 08:41:54.000000000","tz":0},"subject":"flash/nor/rp2040: fix flash erase timeout","message":"flash/nor/rp2040: fix flash erase timeout\n\nSPI flash erase often takes longer than the fixed timeout 3 seconds.\n\nIntroduce a configurable timeout_ms parameter to rp2040_call_rom_func().\nCompute the erase timeout from the number of blocks to be erased.\n\nWhile on it make the timeouts shorter for connect flash, flush cache and\nenter/exit xip (1 second is enough).\n\nChange-Id: I552bfa317ee17064de3a54ec2f0c63e84ba87222\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7214\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-by: Jonathan Bell \u003cjonathan@raspberrypi.com\u003e\n"}},"b02eec297a28758b7c9dca1e2af61d2349d0389f":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2022-09-21 12:40:58.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/14/7214/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/14/7214/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/14/7214/2 \u0026\u0026 git checkout -b change-7214 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/14/7214/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/14/7214/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/14/7214/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/14/7214/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/14/7214/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d059afcad60b4bf3697cfd5e2d8c756d0b1c50d4","subject":"flash/nor/rp2040: fix size of flash write buffer"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-09-21 04:32:21.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-09-21 12:39:11.000000000","tz":120},"subject":"flash/nor/rp2040: fix flash erase timeout","message":"flash/nor/rp2040: fix flash erase timeout\n\nSPI flash erase often takes longer than the fixed timeout 3 seconds.\n\nIntroduce a configurable timeout_ms parameter to rp2040_call_rom_func().\nCompute the erase timeout from the number of blocks to be erased.\n\nWhile on it make the timeouts shorter for connect flash, flush cache and\nenter/exit xip (1 second is enough).\n\nChange-Id: I552bfa317ee17064de3a54ec2f0c63e84ba87222\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"24936e2c4a3718808732bd991e1b074e25f9a0f3":{"kind":"REWORK","_number":1,"created":"2022-09-21 06:45:13.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/14/7214/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/14/7214/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/14/7214/1 \u0026\u0026 git checkout -b change-7214 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/14/7214/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/14/7214/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/14/7214/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/14/7214/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/14/7214/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ad555ae0d23c30aa2f4e1af804466f642407f33a","subject":"flash/nor/rp2040: fix size of flash write buffer"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-09-21 04:32:21.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-09-21 06:39:55.000000000","tz":120},"subject":"flash/nor/rp2040: fix flash erase timeout","message":"flash/nor/rp2040: fix flash erase timeout\n\nSPI flash erase often takes longer than the fixed timeout 3 seconds.\n\nIntroduce a configurable timeout_ms parameter to rp2040_call_rom_func().\nCompute the erase timeout from the number of blocks to be erased.\n\nWhile on it make the timeouts shorter for connect flash, flush cache and\nenter/exit xip (1 second is enough).\n\nChange-Id: I552bfa317ee17064de3a54ec2f0c63e84ba87222\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}