)]}'
{"id":"openocd~master~I903f5f38c8e61016e5002b235e5f07803bd2ec4e","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2022-09-27 08:47:52.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I903f5f38c8e61016e5002b235e5f07803bd2ec4e","subject":"flash/nor/rp2040: check target halted before flash operation","status":"MERGED","created":"2022-09-21 06:45:13.000000000","updated":"2022-09-27 08:47:52.000000000","submitted":"2022-09-27 08:47:52.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7215","meta_rev_id":"8abd491efe1e07f912b5cc54727c723a9a81e891","_number":7215,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-09-27 08:47:52.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-09-27 08:47:52.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-09-27 08:47:52.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-09-21 10:30:54.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-09-21 16:25:13.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2022-09-26 16:03:55.000000000","updated_by":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},"reviewer":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},"state":"REVIEWER"}],"messages":[{"id":"5688b6a3d65a3aa7d4a998dedd930e1ec7125f70","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-09-21 06:45:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"46b433256c20981da53c5748b5678bf8fdb4dba8","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-09-21 10:30:54.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15981/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16771/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"6ac4ec80cd1d14c3c08a00977b37931b746ae6a4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-09-21 12:40:58.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"9a692d085661ce4305f5598414f69090538772f3","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-09-21 15:56:24.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/15987/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16777/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"a8a105aa2270ea789f2dd46cea36ed78c98acb6c","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-21 16:25:13.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"35832af2d1130dad80a727fb4c5be817c5c4e7cb","author":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},"real_author":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},"date":"2022-09-26 16:03:55.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"8abd491efe1e07f912b5cc54727c723a9a81e891","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-09-27 08:47:52.000000000","message":"Change has been successfully cherry-picked as 931b357466ba029d9984ade1f1598371e20871f4","accounts_in_message":[],"_revision_number":3}],"current_revision":"931b357466ba029d9984ade1f1598371e20871f4","revisions":{"4a92643640df02892138b82f2f748b0147ae2184":{"kind":"REWORK","_number":1,"created":"2022-09-21 06:45:13.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/15/7215/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/15/7215/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/15/7215/1 \u0026\u0026 git checkout -b change-7215 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/15/7215/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/15/7215/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/15/7215/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/15/7215/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/15/7215/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"24936e2c4a3718808732bd991e1b074e25f9a0f3","subject":"flash/nor/rp2040: fix flash erase timeout"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-09-21 05:46:15.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-09-21 06:41:39.000000000","tz":120},"subject":"flash/nor/rp2040: check target halted before flash operation","message":"flash/nor/rp2040: check target halted before flash operation\n\nFlash read_id/erase/write operation on running target failed\nin target_run_algorithm() anyway. It generated lot of error messages.\n\nCheck the target state and bail out early if target is running.\n\nChange-Id: I903f5f38c8e61016e5002b235e5f07803bd2ec4e\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"931b357466ba029d9984ade1f1598371e20871f4":{"kind":"REWORK","_number":3,"created":"2022-09-27 08:47:52.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/15/7215/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/15/7215/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/15/7215/3 \u0026\u0026 git checkout -b change-7215 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/15/7215/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/15/7215/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/15/7215/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/15/7215/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/15/7215/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"53611d8055d1130a925010b3feb39c7c8fa20a14","subject":"flash/nor/rp2040: fix flash erase timeout"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-09-21 05:46:15.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-09-27 08:47:52.000000000","tz":0},"subject":"flash/nor/rp2040: check target halted before flash operation","message":"flash/nor/rp2040: check target halted before flash operation\n\nFlash read_id/erase/write operation on running target failed\nin target_run_algorithm() anyway. It generated lot of error messages.\n\nCheck the target state and bail out early if target is running.\n\nChange-Id: I903f5f38c8e61016e5002b235e5f07803bd2ec4e\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7215\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-by: Jonathan Bell \u003cjonathan@raspberrypi.com\u003e\n"}},"3cf05437636857a6d5f7d5259e3a0933abd04a22":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2022-09-21 12:40:58.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/15/7215/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/15/7215/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/15/7215/2 \u0026\u0026 git checkout -b change-7215 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/15/7215/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/15/7215/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/15/7215/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/15/7215/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/15/7215/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b02eec297a28758b7c9dca1e2af61d2349d0389f","subject":"flash/nor/rp2040: fix flash erase timeout"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-09-21 05:46:15.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-09-21 12:39:11.000000000","tz":120},"subject":"flash/nor/rp2040: check target halted before flash operation","message":"flash/nor/rp2040: check target halted before flash operation\n\nFlash read_id/erase/write operation on running target failed\nin target_run_algorithm() anyway. It generated lot of error messages.\n\nCheck the target state and bail out early if target is running.\n\nChange-Id: I903f5f38c8e61016e5002b235e5f07803bd2ec4e\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}