)]}'
{"id":"openocd~master~Ie5ac98b2c25746dd721812c91baaac61ec877ecd","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-09-27 07:21:10.000000000","reason":"Antonio Borneo replied on the change"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2022-10-08 07:59:44.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ie5ac98b2c25746dd721812c91baaac61ec877ecd","subject":"openocd: fix build with \u0027configure --without-capstone\u0027","status":"MERGED","created":"2022-09-26 13:48:22.000000000","updated":"2022-10-08 07:59:44.000000000","submitted":"2022-10-08 07:59:44.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7224","meta_rev_id":"4e924eb5c0c3b4429d668db60d37c1f093d963ed","_number":7224,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-10-08 07:59:44.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-10-08 07:59:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-09-26 13:53:52.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-09-27 07:21:10.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"9bd5c7b74b71327f78ea49d89f2cc06fe3650c84","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-26 13:48:22.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"68fc67a06beaa7595ee6e662dc01e4b2a9df45b3","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-09-26 13:53:52.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16002/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit/16792/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"faee2c231e598b4e87bbc019c6cce704dc9d6edf","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-26 22:26:27.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"fe63790bf1eeab3e47e100f21fd057782b7702d9","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-09-26 23:00:33.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16005/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16795/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"27b5d2996967c3eb958e488c18b3837ac29bb0d0","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-09-27 07:21:10.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"bb6da0bc0c5cb52afb04a61bc2261d6fc2cbb7fa","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-10-08 07:59:36.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"4e924eb5c0c3b4429d668db60d37c1f093d963ed","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-10-08 07:59:44.000000000","message":"Change has been successfully cherry-picked as 978c115dac5a2f420b9ef70207f384f09e380e35","accounts_in_message":[],"_revision_number":3}],"current_revision":"978c115dac5a2f420b9ef70207f384f09e380e35","revisions":{"8fc25241e350aea631cec5141a6342114839fa86":{"kind":"REWORK","_number":1,"created":"2022-09-26 13:48:22.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/24/7224/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/24/7224/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/24/7224/1 \u0026\u0026 git checkout -b change-7224 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/24/7224/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/24/7224/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/24/7224/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/24/7224/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/24/7224/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"60abbda8bcb19e26e073605ec43fdd0f42416567","subject":"target/stm32l5x,stm32u5x: fix trace settings"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-26 13:32:24.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-26 13:32:24.000000000","tz":120},"subject":"openocd: fix build with \u0027configure --without-capstone\u0027","message":"openocd: fix build with \u0027configure --without-capstone\u0027\n\nWhen configure option --without-capstone is used, the macro\nHAVE_CAPSTONE is not defined in config.h, and the following lines\nare instead present:\n\t/* 1 if you have Capstone disassembly framework. */\n\t/* #undef HAVE_CAPSTONE */\n\nThis cause compile error with message:\n\tarm_disassembler.h:190:5: error: \"HAVE_CAPSTONE\" is not\n\t\tdefined, evaluates to 0 [-Werror\u003dundef]\n\t  190 | #if HAVE_CAPSTONE\n\t      |     ^~~~~~~~~~~~~\n\nReplace the incorrect lines:\n\t#if HAVE_CAPSTONE\nwith:\n\t#ifdef HAVE_CAPSTONE\n\nChange-Id: Ie5ac98b2c25746dd721812c91baaac61ec877ecd\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"978c115dac5a2f420b9ef70207f384f09e380e35":{"kind":"REWORK","_number":3,"created":"2022-10-08 07:59:44.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/24/7224/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/24/7224/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/24/7224/3 \u0026\u0026 git checkout -b change-7224 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/24/7224/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/24/7224/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/24/7224/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/24/7224/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/24/7224/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a69b382efd35f13e0f7e63194086a2f5ac24215b","subject":"target/adiv5: 64-bit TAR setup bugfix"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-26 13:32:24.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-10-08 07:59:44.000000000","tz":0},"subject":"openocd: fix build with \u0027configure --without-capstone\u0027","message":"openocd: fix build with \u0027configure --without-capstone\u0027\n\nWhen configure option --without-capstone is used, the macro\nHAVE_CAPSTONE is not defined in config.h, and the following lines\nare instead present:\n\t/* 1 if you have Capstone disassembly framework. */\n\t/* #undef HAVE_CAPSTONE */\n\nThis cause compile error with message:\n\tarm_disassembler.h:190:5: error: \"HAVE_CAPSTONE\" is not\n\t\tdefined, evaluates to 0 [-Werror\u003dundef]\n\t  190 | #if HAVE_CAPSTONE\n\t      |     ^~~~~~~~~~~~~\n\nThis is caused by configure.ac that does not call AC_DEFINE when\n--without-capstone option is present.\n\nFix configure.ac to always provide the autoconf macro\nHAVE_CAPSTONE, with either value 0 or 1.\n\nChange-Id: Ie5ac98b2c25746dd721812c91baaac61ec877ecd\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7224\nTested-by: jenkins\n"}},"14fe4505b73538a6297ab8255b3fc2dd8bf3778b":{"kind":"REWORK","_number":2,"created":"2022-09-26 22:26:27.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/24/7224/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/24/7224/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/24/7224/2 \u0026\u0026 git checkout -b change-7224 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/24/7224/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/24/7224/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/24/7224/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/24/7224/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/24/7224/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"60abbda8bcb19e26e073605ec43fdd0f42416567","subject":"target/stm32l5x,stm32u5x: fix trace settings"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-26 13:32:24.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-26 22:24:34.000000000","tz":120},"subject":"openocd: fix build with \u0027configure --without-capstone\u0027","message":"openocd: fix build with \u0027configure --without-capstone\u0027\n\nWhen configure option --without-capstone is used, the macro\nHAVE_CAPSTONE is not defined in config.h, and the following lines\nare instead present:\n\t/* 1 if you have Capstone disassembly framework. */\n\t/* #undef HAVE_CAPSTONE */\n\nThis cause compile error with message:\n\tarm_disassembler.h:190:5: error: \"HAVE_CAPSTONE\" is not\n\t\tdefined, evaluates to 0 [-Werror\u003dundef]\n\t  190 | #if HAVE_CAPSTONE\n\t      |     ^~~~~~~~~~~~~\n\nThis is caused by configure.ac that does not call AC_DEFINE when\n--without-capstone option is present.\n\nFix configure.ac to always provide the autoconf macro\nHAVE_CAPSTONE, with either value 0 or 1.\n\nChange-Id: Ie5ac98b2c25746dd721812c91baaac61ec877ecd\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}