)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"65b373d490918d94b3d4d6ae9a1b63a77fa08e74","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"117536ad_1ed6fcae","updated":"2022-09-28 22:02:19.000000000","message":"Forgot to check defer_examine","commit_id":"ed7c270923d45096a5a8b3b3d72ccb33a7c562db"}],"src/target/cortex_m.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"674045b9d4d0daa24cf9669cdc22597374fba1e7","unresolved":true,"context_lines":[{"line_number":1440,"context_line":"\t/* TODO: replace the hack calling target_examine_one()"},{"line_number":1441,"context_line":"\t * as soon as a better reset framework is available */"},{"line_number":1442,"context_line":"\tif (!target_was_examined(target) \u0026\u0026 !target-\u003edefer_examine"},{"line_number":1443,"context_line":"\t\t\u0026\u0026 srst_asserted \u0026\u0026 (jtag_reset_config \u0026 RESET_SRST_NO_GATING)) {"},{"line_number":1444,"context_line":"\t\tLOG_TARGET_DEBUG(target, \"Trying to re-examine under reset\");"},{"line_number":1445,"context_line":"\t\ttarget_examine_one(target);"},{"line_number":1446,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"7b78f22b_e52cb1cf","line":1443,"updated":"2022-10-01 08:26:47.000000000","message":"you can remove (jtag_reset_config \u0026 RESET_SRST_NO_GATING) before it\u0027s implicit in having srst_asserted set.\nBut if you think it makes the code more readable, keep it in!","commit_id":"bcfbf678bb8926bec21de17bfe3d6a8aa8490597"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a5221ec87a9797981b08bd65c18da0e68e9d3be4","unresolved":false,"context_lines":[{"line_number":1440,"context_line":"\t/* TODO: replace the hack calling target_examine_one()"},{"line_number":1441,"context_line":"\t * as soon as a better reset framework is available */"},{"line_number":1442,"context_line":"\tif (!target_was_examined(target) \u0026\u0026 !target-\u003edefer_examine"},{"line_number":1443,"context_line":"\t\t\u0026\u0026 srst_asserted \u0026\u0026 (jtag_reset_config \u0026 RESET_SRST_NO_GATING)) {"},{"line_number":1444,"context_line":"\t\tLOG_TARGET_DEBUG(target, \"Trying to re-examine under reset\");"},{"line_number":1445,"context_line":"\t\ttarget_examine_one(target);"},{"line_number":1446,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"975243f4_34eb404a","line":1443,"in_reply_to":"713e2141_54940517","updated":"2022-10-01 19:01:38.000000000","message":"yes, you are right! Sorry for the noise","commit_id":"bcfbf678bb8926bec21de17bfe3d6a8aa8490597"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"694aece1b2866540753d00b76679168079ee8f9d","unresolved":true,"context_lines":[{"line_number":1440,"context_line":"\t/* TODO: replace the hack calling target_examine_one()"},{"line_number":1441,"context_line":"\t * as soon as a better reset framework is available */"},{"line_number":1442,"context_line":"\tif (!target_was_examined(target) \u0026\u0026 !target-\u003edefer_examine"},{"line_number":1443,"context_line":"\t\t\u0026\u0026 srst_asserted \u0026\u0026 (jtag_reset_config \u0026 RESET_SRST_NO_GATING)) {"},{"line_number":1444,"context_line":"\t\tLOG_TARGET_DEBUG(target, \"Trying to re-examine under reset\");"},{"line_number":1445,"context_line":"\t\ttarget_examine_one(target);"},{"line_number":1446,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"713e2141_54940517","line":1443,"in_reply_to":"7b78f22b_e52cb1cf","updated":"2022-10-01 14:31:49.000000000","message":"If SRST have been asserted because\n(jtag_reset_config \u0026 RESET_HAS_SRST) is true\nand armv7m-\u003edebug_ap is false\nthen we should keep the test (jtag_reset_config \u0026 RESET_SRST_NO_GATING) in place\nor we try an useless examine with reset_config srst_gates_jtag.\nDid I missed something? (the logic is really awful, I know)","commit_id":"bcfbf678bb8926bec21de17bfe3d6a8aa8490597"}]}