)]}'
{"id":"openocd~master~Ife875a966a838c37dde987bc584ad0a1f4d020d6","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-10-01 19:01:38.000000000","reason":"Antonio Borneo replied on the change"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2022-10-08 08:49:52.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ife875a966a838c37dde987bc584ad0a1f4d020d6","subject":"target/cortex_m: try to re-examine under reset in cortex_m_assert_reset()","status":"MERGED","created":"2022-09-28 21:38:28.000000000","updated":"2022-10-08 08:49:52.000000000","submitted":"2022-10-08 08:49:52.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7228","meta_rev_id":"49576687af02af8bb6a8522cdc6ee1edc608cc03","_number":7228,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-10-08 08:49:52.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-10-08 08:49:52.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-09-28 22:10:33.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-10-01 08:26:47.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"a73e2a04029bfa16efea4d22b2782ff541dfb7cf","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-09-28 21:38:28.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"65b373d490918d94b3d4d6ae9a1b63a77fa08e74","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-09-28 22:02:19.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"bf70d490c27765f8bc94cee158e8359513ab7bf8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-09-28 22:10:06.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"6711664c33200a97bd63c6978b206e1a2898059f","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-09-28 22:10:33.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16012/ : ABORTED\n\nhttps://build.openocd.org/job/openocd-gerrit/16802/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"e6e1d8f39394bc0d4593e4c50d2896c6b6a6e175","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-09-28 23:24:49.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16014/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16804/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"d31b3c5a43a1d8a55b6905a58964f075f44edd0e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-09-29 08:33:39.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"0014d295043b5c71374e38f868c1d51833e770ea","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-09-29 09:45:09.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16022/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16812/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"674045b9d4d0daa24cf9669cdc22597374fba1e7","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-10-01 08:26:47.000000000","message":"Patch Set 3: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"694aece1b2866540753d00b76679168079ee8f9d","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-10-01 14:31:49.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"a5221ec87a9797981b08bd65c18da0e68e9d3be4","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-10-01 19:01:38.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"7b387392f1203c5274fa0377c9388d77eeb21e54","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-10-08 08:49:46.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"49576687af02af8bb6a8522cdc6ee1edc608cc03","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-10-08 08:49:52.000000000","message":"Change has been successfully cherry-picked as f65d1da01356e21e07e6c638d58f7c6d09738aa6","accounts_in_message":[],"_revision_number":4}],"current_revision":"f65d1da01356e21e07e6c638d58f7c6d09738aa6","revisions":{"f65d1da01356e21e07e6c638d58f7c6d09738aa6":{"kind":"REWORK","_number":4,"created":"2022-10-08 08:49:52.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/28/7228/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/28/7228/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/28/7228/4 \u0026\u0026 git checkout -b change-7228 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/28/7228/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/28/7228/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/28/7228/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/28/7228/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/28/7228/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b991c416b7e1a070604be919d8762ffe0a930a3f","subject":"target/cortex_m: make reset robust again"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-09-28 21:01:39.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-10-08 08:49:52.000000000","tz":0},"subject":"target/cortex_m: try to re-examine under reset in cortex_m_assert_reset()","message":"target/cortex_m: try to re-examine under reset in cortex_m_assert_reset()\n\nAn application often idling in real sleep mode may make a Cortex-M target\nhard to access as CPU clock are gated and debug requests are responded\nby WAIT ack.\n\nTry to examine the target under reset as the last resort.\n\nChange-Id: Ife875a966a838c37dde987bc584ad0a1f4d020d6\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7228\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"acaf5b808bce7dd37cb0d7c7a530f12d004097f0":{"kind":"REWORK","_number":2,"created":"2022-09-28 22:10:06.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/28/7228/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/28/7228/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/28/7228/2 \u0026\u0026 git checkout -b change-7228 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/28/7228/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/28/7228/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/28/7228/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/28/7228/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/28/7228/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ae937791d35b0820e0bc9bf0ab134c2bebd113e4","subject":"flash/nor/rp2040: remove new line from error message"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-09-28 21:01:39.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-09-28 22:07:08.000000000","tz":120},"subject":"target/cortex_m: try to re-examine under reset in cortex_m_assert_reset()","message":"target/cortex_m: try to re-examine under reset in cortex_m_assert_reset()\n\nAn application often idling in real sleep mode may make a Cortex-M target\nhard to access as CPU clock are gated and debug requests are responded\nby WAIT ack.\n\nTry to examine the target under reset as the last resort.\n\nChange-Id: Ife875a966a838c37dde987bc584ad0a1f4d020d6\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"bcfbf678bb8926bec21de17bfe3d6a8aa8490597":{"kind":"REWORK","_number":3,"created":"2022-09-29 08:33:39.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/28/7228/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/28/7228/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/28/7228/3 \u0026\u0026 git checkout -b change-7228 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/28/7228/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/28/7228/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/28/7228/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/28/7228/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/28/7228/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"536c614b89a066b6488c95e6d55e10103d02afbd","subject":"target/cortex_m: make reset robust again"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-09-28 21:01:39.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-09-29 08:20:30.000000000","tz":120},"subject":"target/cortex_m: try to re-examine under reset in cortex_m_assert_reset()","message":"target/cortex_m: try to re-examine under reset in cortex_m_assert_reset()\n\nAn application often idling in real sleep mode may make a Cortex-M target\nhard to access as CPU clock are gated and debug requests are responded\nby WAIT ack.\n\nTry to examine the target under reset as the last resort.\n\nChange-Id: Ife875a966a838c37dde987bc584ad0a1f4d020d6\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"ed7c270923d45096a5a8b3b3d72ccb33a7c562db":{"kind":"REWORK","_number":1,"created":"2022-09-28 21:38:28.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/28/7228/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/28/7228/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/28/7228/1 \u0026\u0026 git checkout -b change-7228 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/28/7228/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/28/7228/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/28/7228/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/28/7228/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/28/7228/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ae937791d35b0820e0bc9bf0ab134c2bebd113e4","subject":"flash/nor/rp2040: remove new line from error message"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-09-28 21:01:39.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-09-28 21:03:33.000000000","tz":120},"subject":"target/cortex_m: try to re-examine under reset in cortex_m_assert_reset()","message":"target/cortex_m: try to re-examine under reset in cortex_m_assert_reset()\n\nAn application often idling in real sleep mode may make a Cortex-M target\nhard to access as CPU clock are gated and debug requests are responded\nby WAIT ack.\n\nTry to examine the target under reset as the last resort.\n\nChange-Id: Ife875a966a838c37dde987bc584ad0a1f4d020d6\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}
