)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"42c0114307618582bff2035f061a996ad18f44be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"baa0cb66_74fba5bd","updated":"2022-09-29 05:42:15.000000000","message":"Duplicate of 5250: flash/at91samd: Use 32-bit writes to NVMCTRL regs for STLink support | https://review.openocd.org/c/openocd/+/5250","commit_id":"c9a93b2b01d29cdcada09967ab72f2ba52a54129"},{"author":{"_account_id":1001693,"name":"Keith Packard","email":"keithp@keithp.com","username":"keithp"},"change_message_id":"98459c072bf80ca9f45cce5ddce9d4fca85f8d93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c21890bc_105f3075","in_reply_to":"baa0cb66_74fba5bd","updated":"2022-09-29 07:19:21.000000000","message":"Sorry, didn\u0027t remember posting this before, it\u0027s been three years. I also cannot find the tree containing that version of the patch, so I\u0027ve provided an update here which addresses the issues mentioned there.","commit_id":"c9a93b2b01d29cdcada09967ab72f2ba52a54129"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"f951e493859038420d1d9975ef86cd94bfd4cbaa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"73db5328_bbc460a2","in_reply_to":"c21890bc_105f3075","updated":"2022-09-30 06:47:15.000000000","message":"No problem, we can use this change and abandon #5250.\nThanks Keith!","commit_id":"c9a93b2b01d29cdcada09967ab72f2ba52a54129"},{"author":{"_account_id":1001693,"name":"Keith Packard","email":"keithp@keithp.com","username":"keithp"},"change_message_id":"98459c072bf80ca9f45cce5ddce9d4fca85f8d93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dc67c3ea_bf6ac3a3","updated":"2022-09-29 07:19:21.000000000","message":"I\u0027m afraid I don\u0027t know how to update the patch in 5250 -- that tree appears to be long-lost here. I\u0027ve addressed the issues raised there and have posted the updates here.","commit_id":"e4a2f38e033bfc69fd7e716f6c27f36ddd88d356"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"84bb72d1f23849ef7e3582d485530c258545c2b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0781fe39_5b9aa3a3","updated":"2022-09-29 08:02:36.000000000","message":"The st-link driver already supports 16 bit R/W, but requires st-link FW \u003e\u003d j26 (or st-link v3, that will not work on non-ST devices). j26 has been released in 2016, if I remember correctly.\nI think I have tested 16 bits with HLA, it should work; the code for 16 bits is there and I\u0027m using it in dap-direct mode too.\nIf you find that it doesn\u0027t work correctly, then a patch for st-link driver would be welcome.\n\nIf you are forced to use an old st-link FW, then it would be good to add some \"property\" to HLA struct hl_layout_api_s to report if 16 bits is supported, so the code in at91samd can go 16 bits native or use 32 bits workaround.\nI\u0027ve never thought about implementing anything new in HLA, as I\u0027m instead working at switching automatically to dap-direct if the st-link FW is recent, and issue a warning and fallback to HLA otherwise.","commit_id":"e4a2f38e033bfc69fd7e716f6c27f36ddd88d356"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"f951e493859038420d1d9975ef86cd94bfd4cbaa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6eee5db4_031baa9a","in_reply_to":"0781fe39_5b9aa3a3","updated":"2022-09-30 06:47:15.000000000","message":"Antonio,\nMaybe after 0.12 release it will be good time to remove 16-bit read/write workaround for j25- from ST-Link driver and just fail instead of pretending it works.\n\n32-bit write is harmless here and the same workaround has been used in same5x driver since 2019. Let\u0027s don complicate the issue...","commit_id":"e4a2f38e033bfc69fd7e716f6c27f36ddd88d356"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"eed94dc962d9915e4f4511a6453375e6d8f13e1b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0e924f3a_c4274b87","in_reply_to":"6eee5db4_031baa9a","updated":"2022-09-30 20:32:32.000000000","message":"\u003e Maybe after 0.12 release it will be good time to remove 16-bit read/write workaround for j25- from ST-Link driver and just fail instead of pretending it works.\n\nyes, that could be a decent cleanup. With a warning to update to newer FW or to explicitly access 8 or 32 bits.\n\n\u003e 32-bit write is harmless here and the same workaround has been used in same5x driver since 2019. Let\u0027s don complicate the issue...\n\nagree","commit_id":"e4a2f38e033bfc69fd7e716f6c27f36ddd88d356"}]}