)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"ac6424a59d128b142f1a05fc26aae4f6539be582","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6e85b9c8_6dcd9363","updated":"2022-10-05 00:15:49.000000000","message":"Hi\n\nI think there is a dangling pointer generated in virtex2_set_instr().\nThe t gets allocated and assigned to out_value. Then jtag_add_ir_scan() gets called.\nAfter that t is freed. Then jtag_execute_queue is called.\n\nIsn\u0027t the out_value used during jtag_execute_queue at the latest?\n\n","commit_id":"8e419ce30fdd77273341722cdd948ec36f1247e9"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2c0f853a318c6931f6cd9e9cc479c87e573a6b86","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8be0a2c7_b2545d93","updated":"2022-10-02 08:25:16.000000000","message":"Looks ok, thanks.\nBut please have a look to the comment below, another patch is also needed","commit_id":"8e419ce30fdd77273341722cdd948ec36f1247e9"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"449fc7634cd9f6201f2900bb4c92fdf9cda32c44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"48f0c66a_16613aa7","updated":"2022-10-04 11:55:38.000000000","message":"You\u0027re right, I prepared a separate patch: \"leaky file-handle in virtex2 driver\".","commit_id":"8e419ce30fdd77273341722cdd948ec36f1247e9"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"045399e7832983ad2d0234a27f698c117c924eea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b5cbae6b_b57ecf43","in_reply_to":"6e85b9c8_6dcd9363","updated":"2022-10-05 13:15:29.000000000","message":"\u003e Hi\n\u003e \n\u003e I think there is a dangling pointer generated in virtex2_set_instr().\n\u003e The t gets allocated and assigned to out_value. Then jtag_add_ir_scan() gets called.\n\u003e After that t is freed. Then jtag_execute_queue is called.\n\u003e \n\u003e Isn\u0027t the out_value used during jtag_execute_queue at the latest?\n\u003e \n\u003e \n\nNope, this is a flase alarm. Sorry for the noise.","commit_id":"8e419ce30fdd77273341722cdd948ec36f1247e9"}],"src/pld/xilinx_bit.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2c0f853a318c6931f6cd9e9cc479c87e573a6b86","unresolved":true,"context_lines":[{"line_number":96,"context_line":"\tread_count \u003d fread(bit_file-\u003eunknown_header, 1, 13, input_file);"},{"line_number":97,"context_line":"\tif (read_count !\u003d 13) {"},{"line_number":98,"context_line":"\t\tLOG_ERROR(\"couldn\u0027t read unknown_header from file \u0027%s\u0027\", filename);"},{"line_number":99,"context_line":"\t\treturn ERROR_PLD_FILE_LOAD_FAILED;"},{"line_number":100,"context_line":"\t}"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"\tif (read_section(input_file, 2, \u0027a\u0027, NULL, \u0026bit_file-\u003esource_file) !\u003d ERROR_OK) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"de85accb_3d8cdf5d","line":99,"updated":"2022-10-02 08:25:16.000000000","message":"There is another leak, here, that is \u0027input_file\u0027 left open.\nWe need to add fclose(input_file) to every return on error.\nBut it could be better to fix it in a separate patch.","commit_id":"8e419ce30fdd77273341722cdd948ec36f1247e9"}]}