)]}'
{"id":"openocd~master~I7e046df85838692c9044fe9c9d67e8b2c821eb0f","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001810":{"account":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"last_update":"2022-10-04 11:56:56.000000000","reason":"Daniel Anselmi replied on the change"}},"hashtags":[],"change_id":"I7e046df85838692c9044fe9c9d67e8b2c821eb0f","subject":"don\u0027t return ERROR_OK in error cases","status":"MERGED","created":"2022-10-02 00:22:18.000000000","updated":"2022-10-08 07:54:39.000000000","submitted":"2022-10-08 07:54:39.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7236","meta_rev_id":"615f3a66a0e2e2c959d23d4f5adf8020445c150a","_number":7236,"owner":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-10-08 07:54:39.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-10-08 07:54:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-10-02 08:26:21.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2022-10-02 09:36:47.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"bc8e0240e0faa304968639fd21124ec5075caf5d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"real_author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"date":"2022-10-02 00:22:18.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6af0b84a919e718a3a5c9b50daf3c40b1d76aeed","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-10-02 08:26:21.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"6f10471f2e7c1790b2eaefaad214c1067337daf0","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-10-02 09:36:47.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16034/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16824/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"bcdf66d24f2d54bbcbf037203c679130c46043ef","author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"real_author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"date":"2022-10-04 11:56:56.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"615f3a66a0e2e2c959d23d4f5adf8020445c150a","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-10-08 07:54:39.000000000","message":"Change has been successfully cherry-picked as d983114855eaf7ab6c63f0e5e6a553096e862a31","accounts_in_message":[],"_revision_number":2}],"current_revision":"d983114855eaf7ab6c63f0e5e6a553096e862a31","revisions":{"0ab07976d2079e273a7abbc08aafbbaa3e5a0807":{"kind":"REWORK","_number":1,"created":"2022-10-02 00:22:18.000000000","uploader":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"ref":"refs/changes/36/7236/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/36/7236/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/36/7236/1 \u0026\u0026 git checkout -b change-7236 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/36/7236/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/36/7236/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/36/7236/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/36/7236/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/36/7236/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8e419ce30fdd77273341722cdd948ec36f1247e9","subject":"fix memory leak in virtex2 driver"}],"author":{"name":"Daniel Anselmi","email":"danselmi@gmx.ch","date":"2022-10-02 00:16:28.000000000","tz":120},"committer":{"name":"Daniel Anselmi","email":"danselmi@gmx.ch","date":"2022-10-02 00:20:56.000000000","tz":120},"subject":"don\u0027t return ERROR_OK in error cases","message":"don\u0027t return ERROR_OK in error cases\n\nChange-Id: I7e046df85838692c9044fe9c9d67e8b2c821eb0f\nSigned-off-by: Daniel Anselmi \u003cdanselmi@gmx.ch\u003e\n"}},"d983114855eaf7ab6c63f0e5e6a553096e862a31":{"kind":"REWORK","_number":2,"created":"2022-10-08 07:54:39.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/36/7236/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/36/7236/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/36/7236/2 \u0026\u0026 git checkout -b change-7236 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/36/7236/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/36/7236/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/36/7236/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/36/7236/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/36/7236/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0a7e17242037431671d52c7e92f72f216c6a4c57","subject":"fix memory leak in virtex2 driver"}],"author":{"name":"Daniel Anselmi","email":"danselmi@gmx.ch","date":"2022-10-02 00:16:28.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-10-08 07:54:39.000000000","tz":0},"subject":"don\u0027t return ERROR_OK in error cases","message":"don\u0027t return ERROR_OK in error cases\n\nChange-Id: I7e046df85838692c9044fe9c9d67e8b2c821eb0f\nSigned-off-by: Daniel Anselmi \u003cdanselmi@gmx.ch\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7236\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}