)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f7101ad5805978819b15b873cf821b6fd4c72958","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Cortex-M support for SMP multicore targets."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Obsolete gdb \u0027J\u0027 packet/smp_gdb command core switching is not implemented,"},{"line_number":12,"context_line":"use with rtos hwthread."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Only one core is resumed if debug_execution is requested."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fbac20e6_5fa71a71","line":11,"updated":"2022-10-02 09:12:37.000000000","message":"agree, it\u0027s already in my TODO list to be dropped after v0.12.0","commit_id":"91434a191d593f9806af4824d0cfa7ea31bc2c04"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"2603ee75725147a5494f4ab17ea151801aa8eec0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b754bf17_e4784a02","updated":"2022-10-02 09:04:00.000000000","message":"Do not review, will be updated soon","commit_id":"91434a191d593f9806af4824d0cfa7ea31bc2c04"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f7101ad5805978819b15b873cf821b6fd4c72958","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a589d9b9_305cb072","updated":"2022-10-02 09:12:37.000000000","message":"Only some minor remark.\nAnother TODO would be to investigate how to centralize the SMP handling. I see too much copy paste between all the SMP aware targets, with risk of diverging or to fix some bug in one target only and forget the others.","commit_id":"91434a191d593f9806af4824d0cfa7ea31bc2c04"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"ffa346ff21e561b1b54fe3e2c4fca2f5059cc02c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"408964bc_1aabda53","in_reply_to":"a589d9b9_305cb072","updated":"2022-10-02 14:22:32.000000000","message":"Yes, I thought about it as well. Though I\u0027ve not studied all targets implementing SMP. E.g. comparison of cortex_a with aarch64 code employing CTI for core sync suggests it will not be easy to find a good set of common routines.","commit_id":"91434a191d593f9806af4824d0cfa7ea31bc2c04"}],"src/target/cortex_m.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f7101ad5805978819b15b873cf821b6fd4c72958","unresolved":true,"context_lines":[{"line_number":1012,"context_line":"\t\t\t\tif (retval \u003d\u003d ERROR_OK)"},{"line_number":1013,"context_line":"\t\t\t\t\tretval \u003d ret2;\t/* store the first error code ignore others */"},{"line_number":1014,"context_line":"\t\t\t}"},{"line_number":1015,"context_line":"\t\t\t/* regardles of errors returned in previous code update state */"},{"line_number":1016,"context_line":"\t\t\ttarget_call_event_callbacks(target, TARGET_EVENT_HALTED);"},{"line_number":1017,"context_line":"\t\t}"},{"line_number":1018,"context_line":"\t\tif (prev_target_state \u003d\u003d TARGET_DEBUG_RUNNING) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"48bc2437_79c14abb","line":1015,"updated":"2022-10-02 09:12:37.000000000","message":"typo s/regardles/regardless/","commit_id":"91434a191d593f9806af4824d0cfa7ea31bc2c04"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"ffa346ff21e561b1b54fe3e2c4fca2f5059cc02c","unresolved":false,"context_lines":[{"line_number":1012,"context_line":"\t\t\t\tif (retval \u003d\u003d ERROR_OK)"},{"line_number":1013,"context_line":"\t\t\t\t\tretval \u003d ret2;\t/* store the first error code ignore others */"},{"line_number":1014,"context_line":"\t\t\t}"},{"line_number":1015,"context_line":"\t\t\t/* regardles of errors returned in previous code update state */"},{"line_number":1016,"context_line":"\t\t\ttarget_call_event_callbacks(target, TARGET_EVENT_HALTED);"},{"line_number":1017,"context_line":"\t\t}"},{"line_number":1018,"context_line":"\t\tif (prev_target_state \u003d\u003d TARGET_DEBUG_RUNNING) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"28660cfd_d7d5d004","line":1015,"in_reply_to":"48bc2437_79c14abb","updated":"2022-10-02 14:22:32.000000000","message":"Done","commit_id":"91434a191d593f9806af4824d0cfa7ea31bc2c04"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f7101ad5805978819b15b873cf821b6fd4c72958","unresolved":true,"context_lines":[{"line_number":1316,"context_line":"\t\t\tcontinue;"},{"line_number":1317,"context_line":""},{"line_number":1318,"context_line":"\t\tint retval \u003d cortex_m_restore_one(curr, 1, \u0026address,"},{"line_number":1319,"context_line":"\t\t\t\t\t\t\t\t\t\thandle_breakpoints, 0);"},{"line_number":1320,"context_line":"\t\tif (retval !\u003d ERROR_OK)"},{"line_number":1321,"context_line":"\t\t\treturn retval;"},{"line_number":1322,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"de0c4d59_d726ffca","line":1319,"updated":"2022-10-02 09:12:37.000000000","message":"they are declared as \u0027bool\u0027 arguments, not \u0027int\u0027:\n int retval \u003d cortex_m_restore_one(curr, true, \u0026address,\n   handle_breakpoints, false);","commit_id":"91434a191d593f9806af4824d0cfa7ea31bc2c04"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"ffa346ff21e561b1b54fe3e2c4fca2f5059cc02c","unresolved":false,"context_lines":[{"line_number":1316,"context_line":"\t\t\tcontinue;"},{"line_number":1317,"context_line":""},{"line_number":1318,"context_line":"\t\tint retval \u003d cortex_m_restore_one(curr, 1, \u0026address,"},{"line_number":1319,"context_line":"\t\t\t\t\t\t\t\t\t\thandle_breakpoints, 0);"},{"line_number":1320,"context_line":"\t\tif (retval !\u003d ERROR_OK)"},{"line_number":1321,"context_line":"\t\t\treturn retval;"},{"line_number":1322,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"430ae39d_6a6c4c5d","line":1319,"in_reply_to":"de0c4d59_d726ffca","updated":"2022-10-02 14:22:32.000000000","message":"Done","commit_id":"91434a191d593f9806af4824d0cfa7ea31bc2c04"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f7101ad5805978819b15b873cf821b6fd4c72958","unresolved":true,"context_lines":[{"line_number":1320,"context_line":"\t\tif (retval !\u003d ERROR_OK)"},{"line_number":1321,"context_line":"\t\t\treturn retval;"},{"line_number":1322,"context_line":""},{"line_number":1323,"context_line":"\t\tretval \u003d cortex_m_restart_one(curr, 0);"},{"line_number":1324,"context_line":"\t\tif (retval !\u003d ERROR_OK)"},{"line_number":1325,"context_line":"\t\t\treturn retval;"},{"line_number":1326,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"51954344_57c6c14d","line":1323,"updated":"2022-10-02 09:12:37.000000000","message":"same here, s/0/false/","commit_id":"91434a191d593f9806af4824d0cfa7ea31bc2c04"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"ffa346ff21e561b1b54fe3e2c4fca2f5059cc02c","unresolved":false,"context_lines":[{"line_number":1320,"context_line":"\t\tif (retval !\u003d ERROR_OK)"},{"line_number":1321,"context_line":"\t\t\treturn retval;"},{"line_number":1322,"context_line":""},{"line_number":1323,"context_line":"\t\tretval \u003d cortex_m_restart_one(curr, 0);"},{"line_number":1324,"context_line":"\t\tif (retval !\u003d ERROR_OK)"},{"line_number":1325,"context_line":"\t\t\treturn retval;"},{"line_number":1326,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"7bdb4f3a_e9c8c865","line":1323,"in_reply_to":"51954344_57c6c14d","updated":"2022-10-02 14:22:32.000000000","message":"Done","commit_id":"91434a191d593f9806af4824d0cfa7ea31bc2c04"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f7101ad5805978819b15b873cf821b6fd4c72958","unresolved":false,"context_lines":[{"line_number":1330,"context_line":"}"},{"line_number":1331,"context_line":""},{"line_number":1332,"context_line":"static int cortex_m_resume(struct target *target, int current,"},{"line_number":1333,"context_line":"\t\t\t\t\t\t   target_addr_t address, int handle_breakpoints, int debug_execution)"},{"line_number":1334,"context_line":"{"},{"line_number":1335,"context_line":"\tint retval \u003d cortex_m_restore_one(target, !!current, \u0026address, !!handle_breakpoints, !!debug_execution);"},{"line_number":1336,"context_line":"\tif (retval !\u003d ERROR_OK) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"6900cfff_fccd3f04","line":1333,"updated":"2022-10-02 09:12:37.000000000","message":"TODO for post v0.12.0, to convert the prototype to use bool instead of int.","commit_id":"91434a191d593f9806af4824d0cfa7ea31bc2c04"}]}