)]}'
{"id":"openocd~master~I2784a66c42be71f2982dff7746f9fb2eb1dc8ca6","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001810":{"account":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"last_update":"2022-10-04 11:58:04.000000000","reason":"Daniel Anselmi replied on the change"}},"hashtags":[],"change_id":"I2784a66c42be71f2982dff7746f9fb2eb1dc8ca6","subject":"fix leaky file-handle in virtex2 driver","status":"MERGED","created":"2022-10-02 15:17:45.000000000","updated":"2022-10-08 07:54:49.000000000","submitted":"2022-10-08 07:54:49.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7243","meta_rev_id":"feb550eb0b9055176d1ec7b7fd48bfc6e3f205bd","_number":7243,"owner":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-10-08 07:54:49.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-10-08 07:54:49.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-10-02 16:34:14.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-10-02 17:24:08.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"9cfd82684a880239184d13bcddc92f24775c1333","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"real_author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"date":"2022-10-02 15:17:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"beb92a7aaa5b467799ed0b8b950eae3c9b101b9a","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-10-02 16:34:14.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16045/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16835/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"6dde65f6e8738199c9501af94c08f85a2c62906a","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-10-02 17:24:08.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"905a4215d3658921ff724f0b1e46fcac41b75e8f","author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"real_author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"date":"2022-10-04 11:58:04.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"feb550eb0b9055176d1ec7b7fd48bfc6e3f205bd","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-10-08 07:54:49.000000000","message":"Change has been successfully cherry-picked as d6ae732f6e1646742bb179c5247ea6a96acfc47e","accounts_in_message":[],"_revision_number":2}],"current_revision":"d6ae732f6e1646742bb179c5247ea6a96acfc47e","revisions":{"d6ae732f6e1646742bb179c5247ea6a96acfc47e":{"kind":"REWORK","_number":2,"created":"2022-10-08 07:54:49.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/43/7243/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/43/7243/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/43/7243/2 \u0026\u0026 git checkout -b change-7243 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/43/7243/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/43/7243/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/43/7243/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/43/7243/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/43/7243/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d983114855eaf7ab6c63f0e5e6a553096e862a31","subject":"don\u0027t return ERROR_OK in error cases"}],"author":{"name":"Daniel Anselmi","email":"danselmi@gmx.ch","date":"2022-10-02 15:15:41.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-10-08 07:54:49.000000000","tz":0},"subject":"fix leaky file-handle in virtex2 driver","message":"fix leaky file-handle in virtex2 driver\n\nChange-Id: I2784a66c42be71f2982dff7746f9fb2eb1dc8ca6\nSigned-off-by: Daniel Anselmi \u003cdanselmi@gmx.ch\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7243\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"28214cefc2a8a56833f65a93ce8fe43fa9dd4577":{"kind":"REWORK","_number":1,"created":"2022-10-02 15:17:45.000000000","uploader":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"ref":"refs/changes/43/7243/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/43/7243/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/43/7243/1 \u0026\u0026 git checkout -b change-7243 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/43/7243/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/43/7243/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/43/7243/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/43/7243/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/43/7243/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0ab07976d2079e273a7abbc08aafbbaa3e5a0807","subject":"don\u0027t return ERROR_OK in error cases"}],"author":{"name":"Daniel Anselmi","email":"danselmi@gmx.ch","date":"2022-10-02 15:15:41.000000000","tz":120},"committer":{"name":"Daniel Anselmi","email":"danselmi@gmx.ch","date":"2022-10-02 15:15:59.000000000","tz":120},"subject":"fix leaky file-handle in virtex2 driver","message":"fix leaky file-handle in virtex2 driver\n\nChange-Id: I2784a66c42be71f2982dff7746f9fb2eb1dc8ca6\nSigned-off-by: Daniel Anselmi \u003cdanselmi@gmx.ch\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}