)]}'
{"id":"openocd~master~I56fbbf9cc23619b6536ecd326f350c8bf137f322","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002050":{"account":{"_account_id":1002050,"name":"Koudai Iwahori","email":"koudai@google.com","username":"koudai"},"last_update":"2023-01-15 14:51:44.000000000","reason":"Change was submitted"},"1001013":{"account":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"last_update":"2023-01-15 14:51:44.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-10-13 20:59:24.000000000","reason":"Antonio Borneo replied on the change"},"1001661":{"account":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"last_update":"2023-01-15 14:51:44.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I56fbbf9cc23619b6536ecd326f350c8bf137f322","subject":"armv8: Add support of pointer authentication","status":"MERGED","created":"2022-10-05 01:38:51.000000000","updated":"2023-01-15 14:51:44.000000000","submitted":"2023-01-15 14:51:44.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":22,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7248","meta_rev_id":"2772fdcbee5d69dd51ea5e49fc8e1678b747162f","_number":7248,"owner":{"_account_id":1002050,"name":"Koudai Iwahori","email":"koudai@google.com","username":"koudai"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-01-15 14:51:44.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-01-15 14:51:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-10-05 02:19:42.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-10-08 22:57:06.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2022-10-08 22:57:06.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"state":"REVIEWER"},{"updated":"2022-10-08 22:57:06.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"state":"REVIEWER"},{"updated":"2022-10-13 20:59:24.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"e9e6f746a3da849f4bdbe90f1dc61e77ade7428a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002050,"name":"Koudai Iwahori","email":"koudai@google.com","username":"koudai"},"real_author":{"_account_id":1002050,"name":"Koudai Iwahori","email":"koudai@google.com","username":"koudai"},"date":"2022-10-05 01:38:51.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7cf6f0703e245b6570dfb0afa91ac95a8664159f","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-10-05 02:19:42.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16053/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16842/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"18551179d6eb04093852894a48c5ce4523e494a7","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-10-08 22:57:06.000000000","message":"Patch Set 1:\n\n(4 comments)","accounts_in_message":[],"_revision_number":1},{"id":"71434c10519a27c0fac50a0c4026498547121f68","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002050,"name":"Koudai Iwahori","email":"koudai@google.com","username":"koudai"},"real_author":{"_account_id":1002050,"name":"Koudai Iwahori","email":"koudai@google.com","username":"koudai"},"date":"2022-10-09 09:31:33.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"d43c766b84059dc8c915abbbf784ba42fcd3ccdd","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-10-09 10:07:24.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16065/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16854/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"76f330349658ebaa47399d6f83799ee9a78ad7ca","author":{"_account_id":1002050,"name":"Koudai Iwahori","email":"koudai@google.com","username":"koudai"},"real_author":{"_account_id":1002050,"name":"Koudai Iwahori","email":"koudai@google.com","username":"koudai"},"date":"2022-10-09 11:56:08.000000000","message":"Patch Set 2:\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"3197ed396daaff4b88d12c41c89c97b2eaa48d9c","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-10-09 14:45:32.000000000","message":"Patch Set 2:\n\n(7 comments)","accounts_in_message":[],"_revision_number":2},{"id":"daaa46850faffd1446a9493da6abe9524dafbddb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002050,"name":"Koudai Iwahori","email":"koudai@google.com","username":"koudai"},"real_author":{"_account_id":1002050,"name":"Koudai Iwahori","email":"koudai@google.com","username":"koudai"},"date":"2022-10-11 11:56:36.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"234f3c5281f677a2bc92177bcbfa279b134bdc37","author":{"_account_id":1002050,"name":"Koudai Iwahori","email":"koudai@google.com","username":"koudai"},"real_author":{"_account_id":1002050,"name":"Koudai Iwahori","email":"koudai@google.com","username":"koudai"},"date":"2022-10-11 12:13:18.000000000","message":"Patch Set 3:\n\n(7 comments)","accounts_in_message":[],"_revision_number":3},{"id":"6704e99e1d6c91a5ebd081bbd46efe2296651580","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-10-11 12:30:26.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16071/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16860/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"05699c1dea9bbe827a40e594b70e7f1c30c57941","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-10-13 20:59:24.000000000","message":"Patch Set 3: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"a8350ff48da9b6b6d2ff7d7079467dd714623f77","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-01-15 13:26:17.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"2772fdcbee5d69dd51ea5e49fc8e1678b747162f","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-01-15 14:51:44.000000000","message":"Change has been successfully cherry-picked as d0436b0cdabb2106701222628d78932c973a1e62","accounts_in_message":[],"_revision_number":4}],"current_revision":"d0436b0cdabb2106701222628d78932c973a1e62","revisions":{"d0436b0cdabb2106701222628d78932c973a1e62":{"kind":"REWORK","_number":4,"created":"2023-01-15 14:51:44.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/48/7248/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/48/7248/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/48/7248/4 \u0026\u0026 git checkout -b change-7248 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/48/7248/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/48/7248/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/48/7248/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/48/7248/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/48/7248/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d96dc47ef67e427cd64a07d9825fd297e3a81633","subject":"src/rtos/eCos : Support per-build configuration specific structure layouts"}],"author":{"name":"Koudai Iwahori","email":"koudai@google.com","date":"2022-10-04 11:21:35.000000000","tz":-420},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-01-15 14:51:44.000000000","tz":0},"subject":"armv8: Add support of pointer authentication","message":"armv8: Add support of pointer authentication\n\nWhen pointer authentication is enabled, some upper bits of the link\nregister (LR[63:VA_SIZE]) are used to store a signature. Therefore, GDB\nneed to remove the signature to get backtraces.\nGDB has support of pointer authentication. When pointer authenticaion is\nenabled, GDB requests 8-bytes mask to the target to remove the\nsignature. mask[63:VA_SIZE] should be all set and mask[VA_SIZE-1:0]\nshould be all cleared. GDB removes the signature by addr\u0026~mask or\naddr|mask.\nI added a feature to provide the mask for pointer authentication.\n\nSigned-off-by: Koudai Iwahori \u003ckoudai@google.com\u003e\nChange-Id: I56fbbf9cc23619b6536ecd326f350c8bf137f322\nReviewed-on: https://review.openocd.org/c/openocd/+/7248\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"c4aa946fce0f1b2a6c38777178e24bb42a086212":{"kind":"REWORK","_number":1,"created":"2022-10-05 01:38:51.000000000","uploader":{"_account_id":1002050,"name":"Koudai Iwahori","email":"koudai@google.com","username":"koudai"},"ref":"refs/changes/48/7248/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/48/7248/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/48/7248/1 \u0026\u0026 git checkout -b change-7248 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/48/7248/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/48/7248/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/48/7248/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/48/7248/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/48/7248/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ae937791d35b0820e0bc9bf0ab134c2bebd113e4","subject":"flash/nor/rp2040: remove new line from error message"}],"author":{"name":"Koudai Iwahori","email":"koudai@google.com","date":"2022-10-04 11:21:35.000000000","tz":-420},"committer":{"name":"Koudai Iwahori","email":"koudai@google.com","date":"2022-10-05 01:32:47.000000000","tz":-420},"subject":"armv8: Add support of pointer authentication","message":"armv8: Add support of pointer authentication\n\nWhen pointer authentication is enabled, some upper bits of the link\nregister (LR[63:VA_SIZE]) are used to store a signature. Therefore, GDB\nneed to remove the signature to get backtraces.\nGDB has support of pointer authentication. When pointer authenticaion is\nenabled, GDB requests 8-bytes mask to the target to remove the\nsignature. mask[63:VA_SIZE] should be all set and mask[VA_SIZE-1:0]\nshould be all cleared. GDB removes the signature by addr\u0026~mask or\naddr|mask.\nI added a feature to provide the mask for pointer authentication.\n\nSigned-off-by: Koudai Iwahori \u003ckoudai@google.com\u003e\nChange-Id: I56fbbf9cc23619b6536ecd326f350c8bf137f322\n"}},"c068e035dc6e6082e5154bffab450b1defb0d78d":{"kind":"REWORK","_number":2,"created":"2022-10-09 09:31:33.000000000","uploader":{"_account_id":1002050,"name":"Koudai Iwahori","email":"koudai@google.com","username":"koudai"},"ref":"refs/changes/48/7248/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/48/7248/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/48/7248/2 \u0026\u0026 git checkout -b change-7248 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/48/7248/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/48/7248/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/48/7248/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/48/7248/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/48/7248/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ae937791d35b0820e0bc9bf0ab134c2bebd113e4","subject":"flash/nor/rp2040: remove new line from error message"}],"author":{"name":"Koudai Iwahori","email":"koudai@google.com","date":"2022-10-04 11:21:35.000000000","tz":-420},"committer":{"name":"Koudai Iwahori","email":"koudai@google.com","date":"2022-10-09 09:19:37.000000000","tz":-420},"subject":"armv8: Add support of pointer authentication","message":"armv8: Add support of pointer authentication\n\nWhen pointer authentication is enabled, some upper bits of the link\nregister (LR[63:VA_SIZE]) are used to store a signature. Therefore, GDB\nneed to remove the signature to get backtraces.\nGDB has support of pointer authentication. When pointer authenticaion is\nenabled, GDB requests 8-bytes mask to the target to remove the\nsignature. mask[63:VA_SIZE] should be all set and mask[VA_SIZE-1:0]\nshould be all cleared. GDB removes the signature by addr\u0026~mask or\naddr|mask.\nI added a feature to provide the mask for pointer authentication.\n\nSigned-off-by: Koudai Iwahori \u003ckoudai@google.com\u003e\nChange-Id: I56fbbf9cc23619b6536ecd326f350c8bf137f322\n"}},"d8f9a3ac17f3893251fac0f02f9ba3eae08f392e":{"kind":"REWORK","_number":3,"created":"2022-10-11 11:56:36.000000000","uploader":{"_account_id":1002050,"name":"Koudai Iwahori","email":"koudai@google.com","username":"koudai"},"ref":"refs/changes/48/7248/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/48/7248/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/48/7248/3 \u0026\u0026 git checkout -b change-7248 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/48/7248/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/48/7248/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/48/7248/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/48/7248/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/48/7248/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ae937791d35b0820e0bc9bf0ab134c2bebd113e4","subject":"flash/nor/rp2040: remove new line from error message"}],"author":{"name":"Koudai Iwahori","email":"koudai@google.com","date":"2022-10-04 11:21:35.000000000","tz":-420},"committer":{"name":"Koudai Iwahori","email":"koudai@google.com","date":"2022-10-11 11:53:29.000000000","tz":-420},"subject":"armv8: Add support of pointer authentication","message":"armv8: Add support of pointer authentication\n\nWhen pointer authentication is enabled, some upper bits of the link\nregister (LR[63:VA_SIZE]) are used to store a signature. Therefore, GDB\nneed to remove the signature to get backtraces.\nGDB has support of pointer authentication. When pointer authenticaion is\nenabled, GDB requests 8-bytes mask to the target to remove the\nsignature. mask[63:VA_SIZE] should be all set and mask[VA_SIZE-1:0]\nshould be all cleared. GDB removes the signature by addr\u0026~mask or\naddr|mask.\nI added a feature to provide the mask for pointer authentication.\n\nSigned-off-by: Koudai Iwahori \u003ckoudai@google.com\u003e\nChange-Id: I56fbbf9cc23619b6536ecd326f350c8bf137f322\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}