)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"4f8f4dd693439802de9a7253e8a84e1cf38d2a6d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0ac10f30_f0a57f8a","updated":"2022-10-09 15:29:03.000000000","message":"Paul, this patch modifies the text you have added in https://review.openocd.org/1467\nDo you agree on this update?","commit_id":"7d60f990bbb59274fbdda5962fe42148dbe07596"},{"author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"change_message_id":"a25fb745a76a925117c7fc61550adb9c80db4cb3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8a2cd449_0cb29f10","updated":"2022-10-09 21:03:24.000000000","message":"Thank you!","commit_id":"43fed97f8c75acc22adc5f7befe3cb9caf9348bb"}],"README":[{"author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"change_message_id":"d46c4a739976f931be8e1bb79af1593c5e29b41e","unresolved":true,"context_lines":[{"line_number":219,"context_line":""},{"line_number":220,"context_line":"- make"},{"line_number":221,"context_line":"- libtool"},{"line_number":222,"context_line":"- pkg-config \u003e\u003d 0.23"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"Additionally, for building from git:"},{"line_number":225,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"96809fdf_f3937474","line":222,"range":{"start_line":222,"start_character":6,"end_line":222,"end_character":12},"updated":"2022-10-09 15:53:47.000000000","message":"Not sure... Here I implied that FreeBSD has its own implementation of similar functionality, called pkgconf: https://www.freebsd.org/cgi/man.cgi?query\u003dpkgconf\u0026sektion\u003d1\u0026manpath\u003dfreebsd-release-ports and its versioning was different.","commit_id":"7d60f990bbb59274fbdda5962fe42148dbe07596"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a21160a6efe39d2a6c1ac9e15b288f4c1632890e","unresolved":true,"context_lines":[{"line_number":219,"context_line":""},{"line_number":220,"context_line":"- make"},{"line_number":221,"context_line":"- libtool"},{"line_number":222,"context_line":"- pkg-config \u003e\u003d 0.23"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"Additionally, for building from git:"},{"line_number":225,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"dc6a36bc_c5a96e31","line":222,"range":{"start_line":222,"start_character":6,"end_line":222,"end_character":12},"in_reply_to":"13896388_6d2ee538","updated":"2022-10-09 17:34:08.000000000","message":"So my Ubuntu, Arch and FreeBSD use pkgconf, none of them has the original pkg-config.\nThe page https://github.com/pkgconf/pkgconf reports:\n\u003e pkgconf is a program which helps to configure compiler and linker flags for\n\u003e development libraries. It is similar to pkg-config from freedesktop.org.\n\npkgconf claims being compatible with pkg-config.\nSo this line could be changed with:\n - pkg-config \u003e\u003d 0.23 or pkgconf (or compatible)\n\nI don\u0027t have a minimum version to suggest for pkgconf, so far.","commit_id":"7d60f990bbb59274fbdda5962fe42148dbe07596"},{"author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"change_message_id":"6d598d7f68f6b79c75254f5d5d5fbab2e7e438c3","unresolved":true,"context_lines":[{"line_number":219,"context_line":""},{"line_number":220,"context_line":"- make"},{"line_number":221,"context_line":"- libtool"},{"line_number":222,"context_line":"- pkg-config \u003e\u003d 0.23"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"Additionally, for building from git:"},{"line_number":225,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"13896388_6d2ee538","line":222,"range":{"start_line":222,"start_character":6,"end_line":222,"end_character":12},"in_reply_to":"94c48608_443b9995","updated":"2022-10-09 16:50:43.000000000","message":"Apparently Debian lets you choose:\nhttps://tracker.debian.org/pkg/pkg-config vs. https://tracker.debian.org/pkg/pkgconf . See how the numbering scheme of pkgconf differs.","commit_id":"7d60f990bbb59274fbdda5962fe42148dbe07596"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9240a11a73155de51b5b803ffeaaa3d27e2b31c8","unresolved":true,"context_lines":[{"line_number":219,"context_line":""},{"line_number":220,"context_line":"- make"},{"line_number":221,"context_line":"- libtool"},{"line_number":222,"context_line":"- pkg-config \u003e\u003d 0.23"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"Additionally, for building from git:"},{"line_number":225,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"94c48608_443b9995","line":222,"range":{"start_line":222,"start_character":6,"end_line":222,"end_character":12},"in_reply_to":"96809fdf_f3937474","updated":"2022-10-09 16:24:12.000000000","message":"Actually, I don\u0027t know!\nBoth Ubuntu 20.04 and Arch Linux \u0027man pkg-config\u0027 returns the man of \u0027pkgconf\u0027. Arch package pkgconf reports \u0027provides pkg-config\u0027.\nSomehow \u0027pkg-config\u0027 and \u0027pkgconf\u0027 converged.\n\nAlso in FreeBSD 13.0-RELEASE-p3:\n$ pkg-config --path libusb-1.0\n/usr/libdata/pkgconfig/libusb-1.0.pc\n$ pkgconf --path libusb-1.0\n/usr/libdata/pkgconfig/libusb-1.0.pc","commit_id":"7d60f990bbb59274fbdda5962fe42148dbe07596"},{"author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"change_message_id":"d46c4a739976f931be8e1bb79af1593c5e29b41e","unresolved":true,"context_lines":[{"line_number":227,"context_line":"- automake \u003e\u003d 1.14"},{"line_number":228,"context_line":"- texinfo \u003e\u003d 5.0"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"USB-based adapters depend on libusb-1.0."},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"USB-Blaster, ASIX Presto and OpenJTAG interface adapter"},{"line_number":233,"context_line":"drivers need:"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"d7859b41_5fce3eb8","line":230,"updated":"2022-10-09 15:53:47.000000000","message":"FreeBSD has libusb-1.0 API provided by core libraries, and they use to lack .pc in core. Is this different now? Then indeed the comment is no longer relevant.","commit_id":"7d60f990bbb59274fbdda5962fe42148dbe07596"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9528b6fcabb7ae13da719b34fcf59023b6e3bd6a","unresolved":true,"context_lines":[{"line_number":227,"context_line":"- automake \u003e\u003d 1.14"},{"line_number":228,"context_line":"- texinfo \u003e\u003d 5.0"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"USB-based adapters depend on libusb-1.0."},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"USB-Blaster, ASIX Presto and OpenJTAG interface adapter"},{"line_number":233,"context_line":"drivers need:"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7094bb53_5950c97e","line":230,"in_reply_to":"a58c7233_fc17393d","updated":"2022-10-09 20:37:24.000000000","message":"Got it!\nYour patch 1467 is from mid 2013.\nFew months later, FreeBSD added the files .pc for the internal libusb\nhttps://cgit.freebsd.org/src/commit/?id\u003d041d3f3f09b8\nI don\u0027t think we need to add here any comments regarding such old version of FreeBSD.\n\nI will send a new version to list both pkg-config and pkgconf as alternatives.","commit_id":"7d60f990bbb59274fbdda5962fe42148dbe07596"},{"author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"change_message_id":"23c4b88e9cde0e7f4df7a4fc287bd21fe2703412","unresolved":true,"context_lines":[{"line_number":227,"context_line":"- automake \u003e\u003d 1.14"},{"line_number":228,"context_line":"- texinfo \u003e\u003d 5.0"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"USB-based adapters depend on libusb-1.0."},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"USB-Blaster, ASIX Presto and OpenJTAG interface adapter"},{"line_number":233,"context_line":"drivers need:"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"a58c7233_fc17393d","line":230,"in_reply_to":"c353e3b4_97f83837","updated":"2022-10-09 18:39:55.000000000","message":"The original comment was just about libusb-1.0.pc file because if you just installed FreeBSD (and no additional packages from \"ports\") you would already have the .so files that provide the API but no matching  .pc files. If this is different now then the remark isn\u0027t needed of course.\nRegarding the pkg-config version, when adding the comment I knew that pkg-config \u003e\u003d 0.23 was needed, but I wasn\u0027t sure which exactly pkgconf version was compatible /enough/, hence the wording. Probably suboptimal.","commit_id":"7d60f990bbb59274fbdda5962fe42148dbe07596"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a21160a6efe39d2a6c1ac9e15b288f4c1632890e","unresolved":true,"context_lines":[{"line_number":227,"context_line":"- automake \u003e\u003d 1.14"},{"line_number":228,"context_line":"- texinfo \u003e\u003d 5.0"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"USB-based adapters depend on libusb-1.0."},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"USB-Blaster, ASIX Presto and OpenJTAG interface adapter"},{"line_number":233,"context_line":"drivers need:"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"c353e3b4_97f83837","line":230,"in_reply_to":"d7859b41_5fce3eb8","updated":"2022-10-09 17:34:08.000000000","message":"Do you think we need to keep the text I have removed ?\nIn such case it should be moved out from libusb to a general context of pkg-config/pkgconf, now that we depend on several optional libraries.\nBut I think that by specifying the dependency from pkg-config/pkgconf, this text can be dropped.","commit_id":"7d60f990bbb59274fbdda5962fe42148dbe07596"}]}