)]}'
{"id":"openocd~master~I1831112cc58681875548d2aeb688391fb79fa37f","project":"openocd","branch":"master","topic":"after 0.12 release","attention_set":{},"removed_from_attention_set":{"1002041":{"account":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},"last_update":"2023-01-20 09:10:56.000000000","reason":"Jonathan Bell replied on the change"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2023-01-28 15:54:17.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I1831112cc58681875548d2aeb688391fb79fa37f","subject":"jtag/drivers/bcm2835gpio: use rounding in delay math","status":"MERGED","created":"2022-10-14 08:54:10.000000000","updated":"2023-01-28 15:54:17.000000000","submitted":"2023-01-28 15:54:17.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7261-after 0.12 release","meta_rev_id":"3e8899d17b1a88643d85935ee1bdb093a52437f9","_number":7261,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-01-28 15:54:17.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-01-28 15:54:17.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-01-28 15:54:17.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-01-28 15:54:17.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-10-14 10:58:12.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-01-19 19:49:31.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},"state":"REVIEWER"},{"updated":"2023-01-21 10:31:37.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"308b43a23aeb847534a09716bfb91c209cbfe279","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-10-14 08:54:10.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"68c15ce90341d6c3fc009c2579b276e4e5c6ad95","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-10-14 08:56:22.000000000","message":"Topic set to after 0.12 release","accounts_in_message":[],"_revision_number":1},{"id":"180063ac485149850f302b4191a93c3798542654","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-10-14 10:58:12.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16082/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16873/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"b020ecb6a337dd058e323d95308771beb242badc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-11-15 11:19:01.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"8cd7fb2349f60c9bb4234a67d3e43d5e4ac5515f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-01-19 15:41:52.000000000","message":"Patch Set 3: Patch Set 2 was rebased","accounts_in_message":[],"_revision_number":3},{"id":"48eb056324c05be8e664f476e7aca9aa3565368e","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-01-19 16:29:10.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16525/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17323/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"3162945cc95d93244699ad56912fe7f55c2488f7","author":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},"real_author":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},"date":"2023-01-20 09:10:56.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"4c7a3f6e9b9479564a4f7b3804ca45b2345b94ec","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-01-20 13:49:58.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"fe1028bef5f2dda1d3afa16959a0208bbb7670eb","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-01-21 10:31:37.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"3e8899d17b1a88643d85935ee1bdb093a52437f9","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-01-28 15:54:17.000000000","message":"Change has been successfully cherry-picked as b4dd8dbc37daf073bf6481fdc7f0f9d7f2e96809","accounts_in_message":[],"_revision_number":4}],"current_revision":"b4dd8dbc37daf073bf6481fdc7f0f9d7f2e96809","revisions":{"b4dd8dbc37daf073bf6481fdc7f0f9d7f2e96809":{"kind":"REWORK","_number":4,"created":"2023-01-28 15:54:17.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/61/7261/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/61/7261/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/61/7261/4 \u0026\u0026 git checkout -b change-7261 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/61/7261/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/61/7261/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/61/7261/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/61/7261/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/61/7261/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"148bc7e2151740527b4ca67d0a7c7c9f01725981","subject":"jtag/drivers/bitbang: avoid mostly harmless glitch on SWDIO"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-10-13 14:46:31.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-01-28 15:54:17.000000000","tz":0},"subject":"jtag/drivers/bcm2835gpio: use rounding in delay math","message":"jtag/drivers/bcm2835gpio: use rounding in delay math\n\nAfter setting adapter speed to some values, the driver\nshows the real speed little bit higher.\nAlthough it does not impose a problem from technical point\nof view because the difference is smaller than usual speed error,\nit looks at least strange to the user. The documentation reads\nthat real frequency should be same or lower than requested.\n\nUse proper rounding in speed -\u003e delay and delay -\u003e speed\nconversions.\n\nChange-Id: I1831112cc58681875548d2aeb688391fb79fa37f\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7261\nTested-by: jenkins\nReviewed-by: Jonathan Bell \u003cjonathan@raspberrypi.com\u003e\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"0a62463b22df047128ef2efddb9fac307e016927":{"kind":"REWORK","_number":1,"created":"2022-10-14 08:54:10.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/61/7261/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/61/7261/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/61/7261/1 \u0026\u0026 git checkout -b change-7261 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/61/7261/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/61/7261/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/61/7261/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/61/7261/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/61/7261/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"70fde63dcf893203fc45a3b33298afaba01d1c8d","subject":"jtag/drivers/bitbang: avoid mostly harmless glitch on SWDIO"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-10-13 14:46:31.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-10-14 08:37:51.000000000","tz":120},"subject":"jtag/drivers/bcm2835gpio: use rounding in delay math","message":"jtag/drivers/bcm2835gpio: use rounding in delay math\n\nAfter setting adapter speed to some values, the driver\nshows the real speed little bit higher.\nAlthough it does not impose a problem from technical point\nof view because the difference is smaller than usual speed error,\nit looks at least strange to the user. The documentation reads\nthat real frequency should be same or lower than requested.\n\nUse proper rounding in speed -\u003e delay and delay -\u003e speed\nconversions.\n\nChange-Id: I1831112cc58681875548d2aeb688391fb79fa37f\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"07a8d97b005b52758927bd86ec00be1c313eefc3":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2023-01-19 15:41:52.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/61/7261/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/61/7261/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/61/7261/3 \u0026\u0026 git checkout -b change-7261 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/61/7261/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/61/7261/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/61/7261/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/61/7261/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/61/7261/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f720ad448cc0790b357588ce2e62bc5f09ee6221","subject":"jtag/drivers/bitbang: avoid mostly harmless glitch on SWDIO"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-10-13 14:46:31.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2023-01-19 15:41:52.000000000","tz":0},"subject":"jtag/drivers/bcm2835gpio: use rounding in delay math","message":"jtag/drivers/bcm2835gpio: use rounding in delay math\n\nAfter setting adapter speed to some values, the driver\nshows the real speed little bit higher.\nAlthough it does not impose a problem from technical point\nof view because the difference is smaller than usual speed error,\nit looks at least strange to the user. The documentation reads\nthat real frequency should be same or lower than requested.\n\nUse proper rounding in speed -\u003e delay and delay -\u003e speed\nconversions.\n\nChange-Id: I1831112cc58681875548d2aeb688391fb79fa37f\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"},"description":"Rebase"},"eb0e1c13eedf8195abe1b63d4c000893fa27ea3a":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2022-11-15 11:19:01.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/61/7261/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/61/7261/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/61/7261/2 \u0026\u0026 git checkout -b change-7261 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/61/7261/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/61/7261/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/61/7261/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/61/7261/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/61/7261/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4f064c24863627c2f254efa01830ade84ba6f473","subject":"jtag/drivers/bitbang: avoid mostly harmless glitch on SWDIO"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-10-13 14:46:31.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-11-15 11:02:14.000000000","tz":60},"subject":"jtag/drivers/bcm2835gpio: use rounding in delay math","message":"jtag/drivers/bcm2835gpio: use rounding in delay math\n\nAfter setting adapter speed to some values, the driver\nshows the real speed little bit higher.\nAlthough it does not impose a problem from technical point\nof view because the difference is smaller than usual speed error,\nit looks at least strange to the user. The documentation reads\nthat real frequency should be same or lower than requested.\n\nUse proper rounding in speed -\u003e delay and delay -\u003e speed\nconversions.\n\nChange-Id: I1831112cc58681875548d2aeb688391fb79fa37f\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}