)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3d46bf9522d03101f83dbaedbb39d875ea9ee2be","unresolved":true,"context_lines":[{"line_number":11,"context_line":"- Add riscv commands \u0027info\u0027, \u0027reset_delays\u0027; copy the description"},{"line_number":12,"context_line":"from the \u0027help\u0027 text."},{"line_number":13,"context_line":"- Add riscv commands \u0027set_prefer_sba\u0027 and \u0027test_sba_config_reg\u0027"},{"line_number":14,"context_line":"but mark those as deprected in the doc."},{"line_number":15,"context_line":"- Ensure that \u0027test_sba_config_reg\u0027 prints a deprecation warning"},{"line_number":16,"context_line":"when used."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"d507e4f2_8a88adbf","line":14,"updated":"2022-10-17 11:00:18.000000000","message":"message is not correct, I will fix it","commit_id":"b2c409a29b45ffb81c0bd4c6f7bebad7e3d35544"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"61bddb40fd65c13eea6c40cbf462a92188352689","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6dbed9a7_529083a0","updated":"2022-10-16 22:26:43.000000000","message":"I have added the commands in \"almost\" alphabetic order and took the description from the help in the code.\nIf you think a better description or a different order could be more appropriate, feel free to edit this patch and re-submit it.","commit_id":"cd12f3ba6088826c74e339807df5d9440b9ffa62"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f49b46c2d8d77324b87ef8c6173fabe30fe4da2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fe9fd7e3_63276acf","updated":"2022-10-16 22:25:55.000000000","message":"I have added the commands in \"almost\" alphabetic order and took the description from the help in the code.\nIf you think a better description or a different order could be more appropriate, feel free to edit this patch and re-submit it.","commit_id":"cd12f3ba6088826c74e339807df5d9440b9ffa62"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"4de64bbc4a193c38b886f0513d4ea65bb7995289","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"89681a90_13fa5ea1","updated":"2022-10-17 06:01:19.000000000","message":"Thank you, Antonio, for the update of the doc.\n\nI have made these additional changes:\n\n- \"riscv set_prefer_sba\" - I have marked this one as deprecated in the doc since there is a better alternative already - \"riscv set_mem_access\".\n- \"riscv test_sba_config_reg\" - I have marked this one as deprecated in both the doc and the code (warning printed). We will remove this one completely in the next version.\n","commit_id":"abcd3cc1c339264f163e3caedc6a0804e16e178f"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7de1ef79dcfefc5b93674f628541a1dc02e24130","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b491be01_27135100","in_reply_to":"89681a90_13fa5ea1","updated":"2022-10-17 10:18:30.000000000","message":"We prefer not documenting deprecated commands. I will remove them from doc.\n\nWould it be ok to drop the commands after tag v0.12.0?","commit_id":"abcd3cc1c339264f163e3caedc6a0804e16e178f"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"e9f3a0b0fbeac6c8af1a30712c85e7b287d0101a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"40a15ddc_6840b44c","in_reply_to":"b491be01_27135100","updated":"2022-10-17 10:37:53.000000000","message":"\u003e We prefer not documenting deprecated commands. I will remove them from doc.\n\nOk. In that case feel free to remove the mentions of \"set_prefer_sba\" and \"test_sba_config_reg\" from the documentation.\n\n\u003e Would it be ok to drop the commands after tag v0.12.0?\n\n- test_sba_config_reg - We can drop this one immediately after v0.12.0 is out.\n- set_prefer_sba - I would prefer to drop this command only later - after v0.13.0 is tagged. That\u0027s because more people may be using this one - and I\u0027d like to provide more gentle transition period.","commit_id":"abcd3cc1c339264f163e3caedc6a0804e16e178f"}]}