)]}'
{"id":"openocd~master~I9048e14fb316dc124847a42cfaefb1f76b5ce53e","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-10-18 20:46:42.000000000","reason":"Antonio Borneo replied on the change"},"1001982":{"account":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"last_update":"2022-10-19 22:28:01.000000000","reason":"Ian Thompson replied on the change"},"1001964":{"account":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"last_update":"2022-10-21 18:16:23.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I9048e14fb316dc124847a42cfaefb1f76b5ce53e","subject":"target/xtensa: remove redundant call for `TARGET_EVENT_HALTED`","status":"MERGED","created":"2022-10-18 15:41:09.000000000","updated":"2022-10-21 18:16:23.000000000","submitted":"2022-10-21 18:16:23.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7274","meta_rev_id":"b48ade145f3e5f9b064146aa6e0484c35c889e51","_number":7274,"owner":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-10-21 18:16:23.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"value":0,"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-10-21 18:16:23.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-10-21 18:16:23.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-10-18 15:45:27.000000000","updated_by":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2022-10-18 15:45:27.000000000","updated_by":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"reviewer":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"state":"REVIEWER"},{"updated":"2022-10-18 16:22:39.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"bd875ec965b60fb5bb0f72066709f4bc4dd354f3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"real_author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"date":"2022-10-18 15:41:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b46cd6c788e96c95911ff4f97bd05bb17b817aee","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-10-18 16:22:39.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16101/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16890/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"0a7d548da96809f2d81595df6ed090755e8effd3","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-10-18 20:46:42.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"7fbe5678e44574ac05bf478ab276462977476bdd","author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"real_author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"date":"2022-10-19 22:28:01.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"b7e2593146eb4a401c861dbd1547d598ebd88478","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-10-21 18:15:14.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"b48ade145f3e5f9b064146aa6e0484c35c889e51","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-10-21 18:16:23.000000000","message":"Change has been successfully cherry-picked as 535de48ca69ba34860067dfe5ea6f7fa6638f7f9","accounts_in_message":[],"_revision_number":2}],"current_revision":"535de48ca69ba34860067dfe5ea6f7fa6638f7f9","revisions":{"535de48ca69ba34860067dfe5ea6f7fa6638f7f9":{"kind":"REWORK","_number":2,"created":"2022-10-21 18:16:23.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/74/7274/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/74/7274/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/74/7274/2 \u0026\u0026 git checkout -b change-7274 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/74/7274/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/74/7274/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/74/7274/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/74/7274/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/74/7274/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b8735bbf7ed7eedb0590edbf2a22929b401887ba","subject":"doc: fix riscv commands"}],"author":{"name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","date":"2022-10-18 15:23:15.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-10-21 18:16:23.000000000","tz":0},"subject":"target/xtensa: remove redundant call for `TARGET_EVENT_HALTED`","message":"target/xtensa: remove redundant call for `TARGET_EVENT_HALTED`\n\n`xtensa_do_step` is invoked from `xtensa_prepare_resume` to silently\nstep over BP/WP before resuming.\nFor example; in the case of WPs (DEBUGCAUSE_DB), in the current\nimplementation `xtensa_do_step` will generate one more\n`TARGET_EVENT_HALTED` after the original one caused by WP itself.\n\nThis patch moves the halted event cb call after\nthe step is done successfully.\n\nSigned-off-by: Erhan Kurubas \u003cerhan.kurubas@espressif.com\u003e\nChange-Id: I9048e14fb316dc124847a42cfaefb1f76b5ce53e\nReviewed-on: https://review.openocd.org/c/openocd/+/7274\nTested-by: jenkins\nReviewed-by: Ian Thompson \u003cianst@cadence.com\u003e\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"a6f82539b81f787c67eeca5c1727f6f0998ffb55":{"kind":"REWORK","_number":1,"created":"2022-10-18 15:41:09.000000000","uploader":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"ref":"refs/changes/74/7274/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/74/7274/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/74/7274/1 \u0026\u0026 git checkout -b change-7274 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/74/7274/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/74/7274/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/74/7274/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/74/7274/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/74/7274/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a7ea1ef0aa00920c7c7cb9282080e1d617eb9e81","subject":"README: update build dependency list"}],"author":{"name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","date":"2022-10-18 15:23:15.000000000","tz":120},"committer":{"name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","date":"2022-10-18 15:38:16.000000000","tz":120},"subject":"target/xtensa: remove redundant call for `TARGET_EVENT_HALTED`","message":"target/xtensa: remove redundant call for `TARGET_EVENT_HALTED`\n\n`xtensa_do_step` is invoked from `xtensa_prepare_resume` to silently\nstep over BP/WP before resuming.\nFor example; in the case of WPs (DEBUGCAUSE_DB), in the current\nimplementation `xtensa_do_step` will generate one more\n`TARGET_EVENT_HALTED` after the original one caused by WP itself.\n\nThis patch moves the halted event cb call after\nthe step is done successfully.\n\nSigned-off-by: Erhan Kurubas \u003cerhan.kurubas@espressif.com\u003e\nChange-Id: I9048e14fb316dc124847a42cfaefb1f76b5ce53e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}