)]}'
{"id":"openocd~master~I1600084db84809ee13bcf8e7828b79f8c9ff9077","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-11-15 10:11:39.000000000","reason":"Antonio Borneo replied on the change"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2022-11-15 10:14:19.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I1600084db84809ee13bcf8e7828b79f8c9ff9077","subject":"target/armv7m: prevent saving and restoring non existent regs","status":"MERGED","created":"2022-10-18 20:16:22.000000000","updated":"2022-11-15 21:30:07.000000000","submitted":"2022-11-15 21:30:07.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":7,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7276","meta_rev_id":"e892b6603c41549c8e86ebf5b837ab5977fcea44","_number":7276,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-11-15 21:30:07.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-11-15 21:30:07.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-11-15 21:30:07.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-10-18 21:31:20.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-10-19 21:15:29.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2022-11-15 10:11:39.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"7a5bbdf82c4821fc692f16e6b967c60881a879ca","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-10-18 20:16:22.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b050fa2984a37185a55045f61f606b3ad7f77460","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-10-18 21:31:20.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16103/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16892/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"519740b7e813db93ea33893c191c7acadc410bbc","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-10-19 21:15:29.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"46ae805dc74fc5e1fc975590f754c473e7045551","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-10-20 05:08:45.000000000","message":"Patch Set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"fb0d141e7b46cb346a01e474899673dd09b1d643","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-10-20 05:45:46.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"1a37cd1ff331329394a0c4e2ecbff9675cbd8e1d","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-10-20 05:58:41.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16117/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16906/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"565bfabc7c6f2f2b0fc5c683211d8305016239e8","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-10-30 15:47:53.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"9b1c530fdc8c87c8cac9de61bdb6d48334403843","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-11-15 07:49:05.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"68c77a74e497d8cc56906fc58c06ee3899014a52","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-11-15 10:11:39.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"94c4f1665bc4b9a23aa3d5d2d301db1b1a19acec","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-11-15 10:14:19.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"e892b6603c41549c8e86ebf5b837ab5977fcea44","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-11-15 21:30:07.000000000","message":"Change has been successfully cherry-picked as 69391878535ec584a472475ee9767b6beaaa138c","accounts_in_message":[],"_revision_number":3}],"current_revision":"69391878535ec584a472475ee9767b6beaaa138c","revisions":{"69391878535ec584a472475ee9767b6beaaa138c":{"kind":"REWORK","_number":3,"created":"2022-11-15 21:30:07.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/76/7276/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/76/7276/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/76/7276/3 \u0026\u0026 git checkout -b change-7276 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/76/7276/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/76/7276/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/76/7276/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/76/7276/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/76/7276/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1d04ef3e55843f9880b7bbab32f564d2018a4b93","subject":"tcl/interface: fix raspberrypi2-native.cfg speed coefficient"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-10-18 20:00:18.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-11-15 21:30:07.000000000","tz":0},"subject":"target/armv7m: prevent saving and restoring non existent regs","message":"target/armv7m: prevent saving and restoring non existent regs\n\narmv7m_start_algorithm() saves register values to arch_info-\u003econtext.\narmv7m_wait_algorithm() restores register values from arch_info-\u003econtext.\nExclude registers with flag exist \u003d false from both loops.\n\nWhile on it refactor the register restore: introduce \u0027struct reg\u0027 pointer\nand dereference it instead of numerous accesses by a full path\nfrom armv7m pointer.\n\nChange-Id: I1600084db84809ee13bcf8e7828b79f8c9ff9077\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7276\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"536c0859f65a7b5021522824ba88bd5ebf31fd10":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2022-10-20 05:08:45.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/76/7276/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/76/7276/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/76/7276/2 \u0026\u0026 git checkout -b change-7276 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/76/7276/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/76/7276/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/76/7276/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/76/7276/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/76/7276/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3b90958c64c97d642347f01e41b68d9f5220d70d","subject":"tcl/target: add basic RP2040 target config"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-10-18 20:00:18.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-10-20 05:08:34.000000000","tz":0},"subject":"target/armv7m: prevent saving and restoring non existent regs","message":"target/armv7m: prevent saving and restoring non existent regs\n\narmv7m_start_algorithm() saves register values to arch_info-\u003econtext.\narmv7m_wait_algorithm() restores register values from arch_info-\u003econtext.\nExclude registers with flag exist \u003d false from both loops.\n\nWhile on it refactor the register restore: introduce \u0027struct reg\u0027 pointer\nand dereference it instead of numerous accesses by a full path\nfrom armv7m pointer.\n\nChange-Id: I1600084db84809ee13bcf8e7828b79f8c9ff9077\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"},"description":"Edit commit message"},"1a70219f523654f71b55885d660cacc3a7d56533":{"kind":"REWORK","_number":1,"created":"2022-10-18 20:16:22.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/76/7276/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/76/7276/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/76/7276/1 \u0026\u0026 git checkout -b change-7276 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/76/7276/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/76/7276/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/76/7276/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/76/7276/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/76/7276/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3b90958c64c97d642347f01e41b68d9f5220d70d","subject":"tcl/target: add basic RP2040 target config"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-10-18 20:00:18.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-10-18 20:00:18.000000000","tz":120},"subject":"target/armv7m: prevent saving and restoring non existent regs","message":"target/armv7m: prevent saving and restoring non existent regs\n\narmv7m_start_algorithm() saves register values to arch_info-\u003econtext.\narmv7m_wait_algorithm() restores register values from arch_info-\u003econtext.\nExclude registres with flag exist \u003d false from both loops.\n\nWhile on it refactor the register restore: introduce \u0027struct reg\u0027 pointer\nand dereference it instead of numerous accesses by a full path\nfrom armv7m pointer.\n\nChange-Id: I1600084db84809ee13bcf8e7828b79f8c9ff9077\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}