)]}'
{"id":"openocd~master~Id5d7e59a416f2d2789bbd74d7e320a1ff0c5d3d2","project":"openocd","branch":"master","attention_set":{"1002057":{"account":{"_account_id":1002057,"name":"Will Rigby","email":"will@breakfastny.com","username":"wrigby"},"last_update":"2023-05-01 11:05:46.000000000","reason":"\u003cGERRIT_ACCOUNT_1001023\u003e replied on the change","reason_account":{"_account_id":1001023,"name":"Matthijs Kooijman","email":"matthijs@stdin.nl","username":"matthijskooijman"}},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2023-05-01 08:43:00.000000000","reason":"\u003cGERRIT_ACCOUNT_1002057\u003e replied on the change","reason_account":{"_account_id":1002057,"name":"Will Rigby","email":"will@breakfastny.com","username":"wrigby"}},"1000863":{"account":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"last_update":"2022-11-19 07:29:42.000000000","reason":"Antonio Borneo replied on the change"}},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-05-01 05:20:48.000000000","reason":"\u003cGERRIT_ACCOUNT_1000687\u003e replied on the change","reason_account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}},"hashtags":[],"change_id":"Id5d7e59a416f2d2789bbd74d7e320a1ff0c5d3d2","subject":"flash/nor/stm32f2x: fix OTP write protection","status":"NEW","created":"2022-10-18 22:47:02.000000000","updated":"2023-05-19 12:36:05.000000000","submit_type":"CHERRY_PICK","mergeable":true,"submittable":false,"total_comment_count":8,"unresolved_comment_count":2,"has_review_started":true,"meta_rev_id":"7e6f356ff7d278bb18d8c7d52fcb20d8a192d63c","_number":7277,"owner":{"_account_id":1002057,"name":"Will Rigby","email":"will@breakfastny.com","username":"wrigby"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"_account_id":1001023,"name":"Matthijs Kooijman","email":"matthijs@stdin.nl","username":"matthijskooijman"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":1,"date":"2022-11-15 14:55:36.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"recommended":{"_account_id":1001023,"name":"Matthijs Kooijman","email":"matthijs@stdin.nl","username":"matthijskooijman"},"all":[{"value":1,"date":"2023-05-01 11:05:46.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1001023,"name":"Matthijs Kooijman","email":"matthijs@stdin.nl","username":"matthijskooijman"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","value":1,"default_value":0}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}],"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"_account_id":1001023,"name":"Matthijs Kooijman","email":"matthijs@stdin.nl","username":"matthijskooijman"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-10-18 23:17:18.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-11-19 07:29:42.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2022-11-19 07:29:42.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"state":"REVIEWER"},{"updated":"2023-05-01 05:20:48.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"CC"},{"updated":"2023-05-01 11:05:46.000000000","updated_by":{"_account_id":1001023,"name":"Matthijs Kooijman","email":"matthijs@stdin.nl","username":"matthijskooijman"},"reviewer":{"_account_id":1001023,"name":"Matthijs Kooijman","email":"matthijs@stdin.nl","username":"matthijskooijman"},"state":"REVIEWER"}],"messages":[{"id":"b63876f9a37ce4f46f0cc5a6ba14508394a8268d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002057,"name":"Will Rigby","email":"will@breakfastny.com","username":"wrigby"},"real_author":{"_account_id":1002057,"name":"Will Rigby","email":"will@breakfastny.com","username":"wrigby"},"date":"2022-10-18 22:47:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2d6ac586ccc6e707c84053976259cf89fda398ff","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002057,"name":"Will Rigby","email":"will@breakfastny.com","username":"wrigby"},"real_author":{"_account_id":1002057,"name":"Will Rigby","email":"will@breakfastny.com","username":"wrigby"},"date":"2022-10-18 23:16:57.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"f66e1ac9c341b8444b52bc92206bbc15d9c59f92","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-10-18 23:17:18.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16104/ : ABORTED\n\nhttps://build.openocd.org/job/openocd-gerrit/16893/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"28289668fbb1bf1b443b7263d8cb59a81a75a169","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-10-18 23:49:13.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16105/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16894/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"2ca8d3e737e092628939087c7476ffb23381f38c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002057,"name":"Will Rigby","email":"will@breakfastny.com","username":"wrigby"},"real_author":{"_account_id":1002057,"name":"Will Rigby","email":"will@breakfastny.com","username":"wrigby"},"date":"2022-11-15 14:19:05.000000000","message":"Patch Set 3: Patch Set 2 was rebased","accounts_in_message":[],"_revision_number":3},{"id":"cdf441c45ba3f568c8a927bde079b20e82bc432e","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-11-15 14:55:36.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16244/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17034/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"5f7fbd8669c2e73808ee7de0d323fe3cc59c3c51","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-11-19 07:29:42.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"7ecd37323bf1071175d8651a97cc67b1a1199522","author":{"_account_id":1002057,"name":"Will Rigby","email":"will@breakfastny.com","username":"wrigby"},"real_author":{"_account_id":1002057,"name":"Will Rigby","email":"will@breakfastny.com","username":"wrigby"},"date":"2022-11-21 19:57:34.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"2b4db9e4324e81c2443c527d9fc3f65110d4b967","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-05-01 05:20:48.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"184c9cb267967a8224802f2fff4a884a19b2ba3e","author":{"_account_id":1002057,"name":"Will Rigby","email":"will@breakfastny.com","username":"wrigby"},"real_author":{"_account_id":1002057,"name":"Will Rigby","email":"will@breakfastny.com","username":"wrigby"},"date":"2023-05-01 08:43:00.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"e21ad799f12d7ecfbee147d9f96c6f0aad8a7edc","author":{"_account_id":1001023,"name":"Matthijs Kooijman","email":"matthijs@stdin.nl","username":"matthijskooijman"},"real_author":{"_account_id":1001023,"name":"Matthijs Kooijman","email":"matthijs@stdin.nl","username":"matthijskooijman"},"date":"2023-05-01 11:05:46.000000000","message":"Patch Set 3: Code-Review+1\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"7e6f356ff7d278bb18d8c7d52fcb20d8a192d63c","author":{"_account_id":1001023,"name":"Matthijs Kooijman","email":"matthijs@stdin.nl","username":"matthijskooijman"},"real_author":{"_account_id":1001023,"name":"Matthijs Kooijman","email":"matthijs@stdin.nl","username":"matthijskooijman"},"date":"2023-05-19 12:36:05.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3}],"current_revision":"7ffe55ed5911f1e2c9bf9044fcecabe2152aa3c4","revisions":{"73c850d3d73e5f118fbc02b93b6da9c0f51e2ed5":{"kind":"REWORK","_number":1,"created":"2022-10-18 22:47:02.000000000","uploader":{"_account_id":1002057,"name":"Will Rigby","email":"will@breakfastny.com","username":"wrigby"},"ref":"refs/changes/77/7277/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/77/7277/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/77/7277/1 \u0026\u0026 git checkout -b change-7277 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/77/7277/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/77/7277/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/77/7277/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/77/7277/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/77/7277/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a7ea1ef0aa00920c7c7cb9282080e1d617eb9e81","subject":"README: update build dependency list"}],"author":{"name":"Will Rigby","email":"will@breakfastny.com","date":"2022-10-18 22:34:21.000000000","tz":-240},"committer":{"name":"Will Rigby","email":"will@breakfastny.com","date":"2022-10-18 22:46:08.000000000","tz":-240},"subject":"flash/nor/stm32f2x: fix OTP write protection","message":"flash/nor/stm32f2x: fix OTP write protection\n\nThis fixes some bugs in the STM32F2X driver\u0027s handling of the OTP lock\narea, which prevented locking the OTP flash.\n\nChange-Id: Id5d7e59a416f2d2789bbd74d7e320a1ff0c5d3d2\nSigned-off-by: Will Rigby \u003cwill@breakfastny.com\u003e\n"}},"7ffe55ed5911f1e2c9bf9044fcecabe2152aa3c4":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2022-11-15 14:19:05.000000000","uploader":{"_account_id":1002057,"name":"Will Rigby","email":"will@breakfastny.com","username":"wrigby"},"ref":"refs/changes/77/7277/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/77/7277/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/77/7277/3 \u0026\u0026 git checkout -b change-7277 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/77/7277/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/77/7277/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/77/7277/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/77/7277/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/77/7277/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1d04ef3e55843f9880b7bbab32f564d2018a4b93","subject":"tcl/interface: fix raspberrypi2-native.cfg speed coefficient"}],"author":{"name":"Will Rigby","email":"will@breakfastny.com","date":"2022-10-18 22:34:21.000000000","tz":-240},"committer":{"name":"Will Rigby","email":"will@breakfastny.com","date":"2022-11-15 14:19:05.000000000","tz":0},"subject":"flash/nor/stm32f2x: fix OTP write protection","message":"flash/nor/stm32f2x: fix OTP write protection\n\nThis fixes some bugs in the STM32F2X driver\u0027s handling of the OTP lock\narea, which prevented locking the OTP flash.\n\nThis writes to the OTP lock area as a series of single-byte writes, mostly\nfor the sake of simplicity. A more sophisticated implementation could read\nback the entire lock area, check if it needs to be changed, and write it\nback as doublewords.\n\nWhile we\u0027re in here, I moved the OTP-enabled safety check from\nstm32x_write_block to stm32x_write, so single-byte writes can\u0027t evade the\nsafety check.\n\nChange-Id: Id5d7e59a416f2d2789bbd74d7e320a1ff0c5d3d2\nSigned-off-by: Will Rigby \u003cwill@breakfastny.com\u003e\n"},"description":"Rebase"},"8099bb6dc7a911e17efcfa002dba4e7acc579dae":{"kind":"REWORK","_number":2,"created":"2022-10-18 23:16:57.000000000","uploader":{"_account_id":1002057,"name":"Will Rigby","email":"will@breakfastny.com","username":"wrigby"},"ref":"refs/changes/77/7277/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/77/7277/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/77/7277/2 \u0026\u0026 git checkout -b change-7277 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/77/7277/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/77/7277/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/77/7277/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/77/7277/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/77/7277/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a7ea1ef0aa00920c7c7cb9282080e1d617eb9e81","subject":"README: update build dependency list"}],"author":{"name":"Will Rigby","email":"will@breakfastny.com","date":"2022-10-18 22:34:21.000000000","tz":-240},"committer":{"name":"Will Rigby","email":"will@breakfastny.com","date":"2022-10-18 23:15:15.000000000","tz":-240},"subject":"flash/nor/stm32f2x: fix OTP write protection","message":"flash/nor/stm32f2x: fix OTP write protection\n\nThis fixes some bugs in the STM32F2X driver\u0027s handling of the OTP lock\narea, which prevented locking the OTP flash.\n\nThis writes to the OTP lock area as a series of single-byte writes, mostly\nfor the sake of simplicity. A more sophisticated implementation could read\nback the entire lock area, check if it needs to be changed, and write it\nback as doublewords.\n\nWhile we\u0027re in here, I moved the OTP-enabled safety check from\nstm32x_write_block to stm32x_write, so single-byte writes can\u0027t evade the\nsafety check.\n\nChange-Id: Id5d7e59a416f2d2789bbd74d7e320a1ff0c5d3d2\nSigned-off-by: Will Rigby \u003cwill@breakfastny.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"NEED"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}}]}