)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f7ad5bde9d36937d0d62518056a9ab13b4036893","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cbeafb67_c8009393","updated":"2022-10-21 17:20:43.000000000","message":"Thanks, queued for after 0.12.0","commit_id":"2c2daadf3689cd7de1f7101ae267b041608b4e53"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"30b70786b87db9c7d1cb0616e50feb4fd95fc231","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5e7d6976_9e432d24","in_reply_to":"c0071e81_3e266195","updated":"2022-10-25 12:48:55.000000000","message":"Not surprisingly the compiled code is absolutely equal without the change\n 0x08136aa9 \u003cstm32l4_probe+777\u003e:      mov    $0x82f3d00,%edx\n 0x08136aae \u003cstm32l4_probe+782\u003e:      mov    %eax,0x30(%edi)\n 0x08136ab1 \u003cstm32l4_probe+785\u003e:      mov    %eax,0x2c(%edi)\n\nand with the change\n 0x08136aa9 \u003cstm32l4_probe+777\u003e:      mov    $0x82f3d00,%edx\n 0x08136aae \u003cstm32l4_probe+782\u003e:      mov    %eax,0x2c(%edi)\n 0x08136ab1 \u003cstm32l4_probe+785\u003e:      mov    %eax,0x30(%edi)\n\nSo if we exclude the possibility that your colleague compiled OpenOCD by a broken gcc, the only explanation could be a mistake in testing.","commit_id":"2c2daadf3689cd7de1f7101ae267b041608b4e53"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"6ea6ed7d986798cd1ee6b27a897e7e07739a11f6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c0071e81_3e266195","in_reply_to":"c42c5396_df4d5d06","updated":"2022-10-21 22:42:11.000000000","message":"I don\u0027t see how this change can impact the functionality.\nFor me this is only a code cleanup.\nHave you tested running it under valgrind? Looks to me the effect of an uninitialized variable and changing one random line of code changes the stack and the value of the uninitialized.","commit_id":"2c2daadf3689cd7de1f7101ae267b041608b4e53"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"e86119afacacb9002b7ef0c6fa652fbfd6f81d07","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c42c5396_df4d5d06","in_reply_to":"cbeafb67_c8009393","updated":"2022-10-21 21:43:30.000000000","message":"IDK how and why, but this seems to fix an issue when writing to non aligned flash memory\nthis was detected by my colleague while doing some validation\nusing this command \n  \u003e flash fillw 0x8000001 0xdeadbeef 1\n\nafter splitting the assignment, the issue was fixed","commit_id":"2c2daadf3689cd7de1f7101ae267b041608b4e53"}]}
