)]}'
{"id":"openocd~master~Id764c7b5ec4f5b3c18c7da650bbff39fc98ed049","project":"openocd","branch":"master","hashtags":[],"change_id":"Id764c7b5ec4f5b3c18c7da650bbff39fc98ed049","subject":"esirisc_jtag: fix clang error core.VLASize","status":"MERGED","created":"2022-11-02 00:23:30.000000000","updated":"2022-11-11 20:11:03.000000000","submitted":"2022-11-11 20:11:03.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7301","meta_rev_id":"adab11e1030c2766cea57fc3bf978f57c2db8c0c","_number":7301,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-11-11 20:11:03.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-11-11 20:11:03.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-11-02 01:00:26.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"ecd5c6f65817371b096c0e380b204596e6f9864a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-11-02 00:23:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0152d6337545e673d1cd2fdd05e5f3e22d97fab5","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-11-02 01:00:26.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16158/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16947/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"af0261a17e5e9f959ec93ee1abc9d0dfd299a476","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-11-04 00:24:07.000000000","message":"Patch Set 1:\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16182/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16972/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"b87874b2387756b74856a1621b679ad8df1a682e","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-11-04 15:02:53.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"f6c0432d8ba1e79d8936823bdcd6a5577e903a29","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-11-11 20:10:58.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"adab11e1030c2766cea57fc3bf978f57c2db8c0c","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-11-11 20:11:03.000000000","message":"Change has been successfully cherry-picked as 0946e80407150b68acd02bc59f0f3a3170142c4c","accounts_in_message":[],"_revision_number":2}],"current_revision":"0946e80407150b68acd02bc59f0f3a3170142c4c","revisions":{"0946e80407150b68acd02bc59f0f3a3170142c4c":{"kind":"REWORK","_number":2,"created":"2022-11-11 20:11:03.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/01/7301/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/01/7301/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/01/7301/2 \u0026\u0026 git checkout -b change-7301 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/01/7301/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/01/7301/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/01/7301/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/01/7301/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/01/7301/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7a09635735486dd2d74576b003c85c7ff16705d5","subject":"openrisc: fix clang error core.CallAndMessage"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-11-01 23:57:17.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-11-11 20:11:03.000000000","tz":0},"subject":"esirisc_jtag: fix clang error core.VLASize","message":"esirisc_jtag: fix clang error core.VLASize\n\nThe function esirisc_jtag_recv() can be called with argument\nnum_in_fields \u003d 0, for example as consequence of calling\nesirisc_jtag_continue().\nIn this case, num_in_bytes is zero and the allocation of the\nvariable-length array \u0027r\u0027 requires size zero.\n\n  src/target/esirisc_jtag.c:133:2: warning: Declared variable-length\n    array (VLA) has zero size [core.VLASize]\n        uint8_t r[num_in_bytes * 2];\n        ^~~~~~~~~ ~~~~~~~~~~~~~~~~\n\nFix it by forcing size one when num_in_bytes is zero.\n\nChange-Id: Id764c7b5ec4f5b3c18c7da650bbff39fc98ed049\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7301\nTested-by: jenkins\n"}},"28c479b40bbaa3eda50a4e8d11ae55d50c4f0c3b":{"kind":"REWORK","_number":1,"created":"2022-11-02 00:23:30.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/01/7301/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/01/7301/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/01/7301/1 \u0026\u0026 git checkout -b change-7301 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/01/7301/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/01/7301/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/01/7301/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/01/7301/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/01/7301/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d790cd7f66a976b93c1fd70eed93db1838ef884a","subject":"openrisc: fix clang error core.CallAndMessage"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-11-01 23:57:17.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-11-02 00:19:55.000000000","tz":60},"subject":"esirisc_jtag: fix clang error core.VLASize","message":"esirisc_jtag: fix clang error core.VLASize\n\nThe function esirisc_jtag_recv() can be called with argument\nnum_in_fields \u003d 0, for example as consequence of calling\nesirisc_jtag_continue().\nIn this case, num_in_bytes is zero and the allocation of the\nvariable-length array \u0027r\u0027 requires size zero.\n\n  src/target/esirisc_jtag.c:133:2: warning: Declared variable-length\n    array (VLA) has zero size [core.VLASize]\n        uint8_t r[num_in_bytes * 2];\n        ^~~~~~~~~ ~~~~~~~~~~~~~~~~\n\nFix it by forcing size one when num_in_bytes is zero.\n\nChange-Id: Id764c7b5ec4f5b3c18c7da650bbff39fc98ed049\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}