)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2f27fed41a9fd101ed5d9c2141ad95a65ede9328","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bb25c8b8_2dacf447","updated":"2022-11-02 22:30:22.000000000","message":"Andreas,\nclang finds 4 issues in this code from you (partially patched by Marc).\nWith this patch I fix the trivial one.\nFor the other three I cannot propose a patch nor I can test it.\nI have added some remark below. Would you mind give a look and propose a patch or provide some hint on how to proceed?\nThanks","commit_id":"f1b99ad1f69e99a9f44256008969eb9c1f5e9cbd"}],"src/flash/nor/stmqspi.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2f27fed41a9fd101ed5d9c2141ad95a65ede9328","unresolved":true,"context_lines":[{"line_number":616,"context_line":""},{"line_number":617,"context_line":"\tLOG_DEBUG(\"%s\", __func__);"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"\tdual \u003d (stmqspi_info-\u003esaved_cr \u0026 BIT(SPI_DUAL_FLASH)) ? 1 : 0;"},{"line_number":620,"context_line":""},{"line_number":621,"context_line":"\t/* chip_erase_cmd, sectorsize and erase_cmd are optional */"},{"line_number":622,"context_line":"\tif ((CMD_ARGC \u003c 7) || (CMD_ARGC \u003e 10))"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"1aca30f8_bd5909ea","line":619,"updated":"2022-11-02 22:30:22.000000000","message":"this triggers SIGSEGV because \u0027stmqspi_info\u0027 has been set to NULL few lines above.\n\u0027dual\u0027 is only used much later in this function, so I thought about moving this line below.\nBut this function invalidates all the probed info; I don\u0027t know when this line can be safely executed.\nAny hint?","commit_id":"f1b99ad1f69e99a9f44256008969eb9c1f5e9cbd"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2f27fed41a9fd101ed5d9c2141ad95a65ede9328","unresolved":true,"context_lines":[{"line_number":2104,"context_line":"\t/* check whether QSPI_ABR is writeable and readback returns the value written */"},{"line_number":2105,"context_line":"\tretval \u003d target_write_u32(target, io_base + QSPI_ABR, magic);"},{"line_number":2106,"context_line":"\tif (retval \u003d\u003d ERROR_OK) {"},{"line_number":2107,"context_line":"\t\tretval \u003d target_read_u32(target, io_base + QSPI_ABR, \u0026data);"},{"line_number":2108,"context_line":"\t\tretval \u003d target_write_u32(target, io_base + QSPI_ABR, 0);"},{"line_number":2109,"context_line":"\t}"},{"line_number":2110,"context_line":""},{"line_number":2111,"context_line":"\tif (data \u003d\u003d magic) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"244958ba_6c95b3b3","line":2108,"range":{"start_line":2107,"start_character":1,"end_line":2108,"end_character":2},"updated":"2022-11-02 22:30:22.000000000","message":"These two values assigned to retval are never used\nIn the original code the second assignment was tested later on, but after a code update from Marc also the second assignment is dead assignment.\nWhat was your original idea about this code?\nDoes it make sense to return if one of these retval is not ERROR_OK?","commit_id":"f1b99ad1f69e99a9f44256008969eb9c1f5e9cbd"}]}