)]}'
{"id":"openocd~master~Id4e9134408fab3e04936d36e95724bf8d3ab55aa","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000853":{"account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2022-11-11 20:12:48.000000000","reason":"Change was submitted"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2022-11-11 20:12:48.000000000","reason":"Change was submitted"},"1001036":{"account":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"last_update":"2022-11-11 20:12:48.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Id4e9134408fab3e04936d36e95724bf8d3ab55aa","subject":"flash: stmqspi: fix clang error \u0027dead assignment\u0027","status":"MERGED","created":"2022-11-02 22:15:26.000000000","updated":"2022-11-11 20:12:48.000000000","submitted":"2022-11-11 20:12:48.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":3,"unresolved_comment_count":2,"has_review_started":true,"submission_id":"7304","meta_rev_id":"9252d531c50980cb1a0166d58499d5d6e95d6006","_number":7304,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-11-11 20:12:48.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-11-11 20:12:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-11-02 22:30:22.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2022-11-02 22:30:22.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"state":"REVIEWER"},{"updated":"2022-11-02 22:30:22.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001036,"name":"Andreas Bolsch","email":"hyphen0break@gmail.com","username":"abmero"},"state":"REVIEWER"},{"updated":"2022-11-02 22:45:47.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"2dbb4262e7c30ac667f9a57359372920efc896f6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-11-02 22:15:26.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2f27fed41a9fd101ed5d9c2141ad95a65ede9328","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-11-02 22:30:22.000000000","message":"Patch Set 1:\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"cebfb818f49f39a79a64f09d10968eb6ee470a3f","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-11-02 22:45:47.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16168/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16957/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"91dc492b170351687804eccbe5f138bde5d79966","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-11-04 15:04:47.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"8dd66dfbf524e654c751f877203e349563110bc4","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-11-11 20:11:29.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"9252d531c50980cb1a0166d58499d5d6e95d6006","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-11-11 20:12:48.000000000","message":"Change has been successfully cherry-picked as 1dea9ab41f988c5173325521b1e9b75274a785da","accounts_in_message":[],"_revision_number":2}],"current_revision":"1dea9ab41f988c5173325521b1e9b75274a785da","revisions":{"1dea9ab41f988c5173325521b1e9b75274a785da":{"kind":"REWORK","_number":2,"created":"2022-11-11 20:12:48.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/04/7304/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/04/7304/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/04/7304/2 \u0026\u0026 git checkout -b change-7304 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/04/7304/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/04/7304/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/04/7304/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/04/7304/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/04/7304/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5fc4882b8039dbd35f2efcd1419e83fbda9eba28","subject":"dsp5680xx: fix clang error core.UndefinedBinaryOperatorResult"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-11-02 22:11:19.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-11-11 20:12:48.000000000","tz":0},"subject":"flash: stmqspi: fix clang error \u0027dead assignment\u0027","message":"flash: stmqspi: fix clang error \u0027dead assignment\u0027\n\nThe variable retval is assigned a value that is never used, as it\nis reassigned few lines below.\n\nDrop the dead assignment.\n\nChange-Id: Id4e9134408fab3e04936d36e95724bf8d3ab55aa\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7304\nTested-by: jenkins\n"}},"f1b99ad1f69e99a9f44256008969eb9c1f5e9cbd":{"kind":"REWORK","_number":1,"created":"2022-11-02 22:15:26.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/04/7304/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/04/7304/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/04/7304/1 \u0026\u0026 git checkout -b change-7304 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/04/7304/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/04/7304/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/04/7304/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/04/7304/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/04/7304/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"590a623db9ad667d26b6b162daf90d3d65df1d5f","subject":"dsp5680xx: fix clang error core.UndefinedBinaryOperatorResult"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-11-02 22:11:19.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-11-02 22:11:19.000000000","tz":60},"subject":"flash: stmqspi: fix clang error \u0027dead assignment\u0027","message":"flash: stmqspi: fix clang error \u0027dead assignment\u0027\n\nThe variable retval is assigned a value that is never used, as it\nis reassigned few lines below.\n\nDrop the dead assignment.\n\nChange-Id: Id4e9134408fab3e04936d36e95724bf8d3ab55aa\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}