)]}'
{"id":"openocd~master~Ib87e60e0edfd9671091f5dcfa9aedaf1aed800d1","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-11-11 20:23:13.000000000","reason":"Change was submitted"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2022-11-06 06:14:41.000000000","reason":"Tomas Vanek replied on the change"}},"hashtags":[],"change_id":"Ib87e60e0edfd9671091f5dcfa9aedaf1aed800d1","subject":"rtos: hwthread: fix clang error core.NullDereference","status":"MERGED","created":"2022-11-05 16:18:51.000000000","updated":"2022-11-11 20:23:13.000000000","submitted":"2022-11-11 20:23:13.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7337","meta_rev_id":"087a15eedf716a4516e814f2a8d4517fab2a6692","_number":7337,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-11-11 20:23:13.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-11-11 20:23:13.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-11-11 20:23:13.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-11-05 16:18:51.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2022-11-05 17:12:18.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"4d72b75c515730303d312b6dcd4a2f9ca7ea8d51","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-11-05 16:18:51.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7349cc3013b0b6fcd5581ac567cc7bbef92338ae","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-11-05 17:12:18.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16193/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16983/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"686f9ccc1029c5814f2da7c6245ed53403f567ce","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-11-05 17:22:39.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"1178aa3f3af294578e97b343fdf74141ce63d6ef","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-11-06 06:14:41.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"087a15eedf716a4516e814f2a8d4517fab2a6692","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-11-11 20:23:13.000000000","message":"Change has been successfully cherry-picked as fb23c9c10bd161ac05b85e73ad91676063592b96","accounts_in_message":[],"_revision_number":2}],"current_revision":"fb23c9c10bd161ac05b85e73ad91676063592b96","revisions":{"5ed28e4594a51f90a58bedf2a61dbd316b4559fb":{"kind":"REWORK","_number":1,"created":"2022-11-05 16:18:51.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/37/7337/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/37/7337/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/37/7337/1 \u0026\u0026 git checkout -b change-7337 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/37/7337/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/37/7337/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/37/7337/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/37/7337/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/37/7337/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f62bb4a4f2f0753084d51fbcb421c54b7ec4567c","subject":"Revert \"Remove duplicate of a counter in hwthread_update_threads\""}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-11-03 23:32:20.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-11-05 16:15:32.000000000","tz":60},"subject":"rtos: hwthread: fix clang error core.NullDereference","message":"rtos: hwthread: fix clang error core.NullDereference\n\nClang spots a potential NULL pointer dereferencing that is instead\nan incorrect use of an array of pointers:\n\n\tsrc/rtos/hwthread.c:254:32: warning: Dereference of null pointer\n\t  [core.NullDereference]\n\t\t(*rtos_reg_list)[j].number \u003d (*reg_list)[i].number;\n\t\t                             ^~~~~~~~~~~~~~~~~~~~~\nThe error has not been spotted before because:\n- this function is not called for the first core of the SMP node,\n- for the other cores on Cortex-A it still returns valid register\n  value for the first 12 ARM registers, then it diverges.\n\nAlso Valgrind does not spot any issue at runtime.\n\nAddress the array correctly.\n\nWhile there, use DIV_ROUND_UP() macro for the computation.\n\nChange-Id: Ib87e60e0edfd9671091f5dcfa9aedaf1aed800d1\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"fb23c9c10bd161ac05b85e73ad91676063592b96":{"kind":"REWORK","_number":2,"created":"2022-11-11 20:23:13.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/37/7337/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/37/7337/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/37/7337/2 \u0026\u0026 git checkout -b change-7337 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/37/7337/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/37/7337/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/37/7337/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/37/7337/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/37/7337/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"09731b69a6f50c7e0e2f6fa0ba245374034217cb","subject":"Revert \"Remove duplicate of a counter in hwthread_update_threads\""}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-11-03 23:32:20.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-11-11 20:23:13.000000000","tz":0},"subject":"rtos: hwthread: fix clang error core.NullDereference","message":"rtos: hwthread: fix clang error core.NullDereference\n\nClang spots a potential NULL pointer dereferencing that is instead\nan incorrect use of an array of pointers:\n\n\tsrc/rtos/hwthread.c:254:32: warning: Dereference of null pointer\n\t  [core.NullDereference]\n\t\t(*rtos_reg_list)[j].number \u003d (*reg_list)[i].number;\n\t\t                             ^~~~~~~~~~~~~~~~~~~~~\nThe error has not been spotted before because:\n- this function is not called for the first core of the SMP node,\n- for the other cores on Cortex-A it still returns valid register\n  value for the first 12 ARM registers, then it diverges.\n\nAlso Valgrind does not spot any issue at runtime.\n\nAddress the array correctly.\n\nWhile there, use DIV_ROUND_UP() macro for the computation.\n\nChange-Id: Ib87e60e0edfd9671091f5dcfa9aedaf1aed800d1\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7337\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}