)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"476abf7e9e6d45c85264f1fb72051d5489d32a58","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"534c6caa_1330ae89","updated":"2022-11-06 23:01:02.000000000","message":"Thanks for the split. It helps.\nThe patch is ok. I only have a strange feeling for some odd number in the table.\nCan you please verify them with the datasheet?\nIf you confirm they are ok, I will merge this as is.","commit_id":"d0ffb5f9f97b0bb00896bd50873aab2692491f27"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"81a11c159e95e7ae900e3cd32daf08ded3de91df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a6e51035_266b9b70","updated":"2022-11-09 14:38:48.000000000","message":"Thanks!","commit_id":"d0ffb5f9f97b0bb00896bd50873aab2692491f27"}],"src/flash/nor/numicro.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"476abf7e9e6d45c85264f1fb72051d5489d32a58","unresolved":true,"context_lines":[{"line_number":215,"context_line":"\t{\"MINI54ZDE\", 0x20205403, NUMICRO_BANKS_GENERAL(16 * 1024, 0 * 1024, 2 * 1024, 8)},"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"\t/* MINI55 */"},{"line_number":218,"context_line":"\t{\"MINI55LDE\", 0x00505500, NUMICRO_BANKS_GENERAL(35 * 512, 0 * 1024, 2 * 1024, 8)},"},{"line_number":219,"context_line":"\t{\"MINI55ZDE\", 0x00505503, NUMICRO_BANKS_GENERAL(35 * 512, 0 * 1024, 2 * 1024, 8)},"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"\t/* MINI58 */"},{"line_number":222,"context_line":"\t{\"MINI58FDE\", 0x00A05805, NUMICRO_BANKS_GENERAL(32 * 1024, 0 * 1024, 5 * 512, 8)},"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"06b8398e_f8be2f1f","line":219,"range":{"start_line":218,"start_character":49,"end_line":219,"end_character":52},"updated":"2022-11-06 23:01:02.000000000","message":"are you sure these are 35? Looks an odd number","commit_id":"d0ffb5f9f97b0bb00896bd50873aab2692491f27"},{"author":{"_account_id":1001899,"name":"Jian-Hong Pan","email":"chienhung.pan@gmail.com","username":"starnight"},"change_message_id":"597b13ad063b6fb5b1c68502bb76ef82b9378046","unresolved":false,"context_lines":[{"line_number":215,"context_line":"\t{\"MINI54ZDE\", 0x20205403, NUMICRO_BANKS_GENERAL(16 * 1024, 0 * 1024, 2 * 1024, 8)},"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"\t/* MINI55 */"},{"line_number":218,"context_line":"\t{\"MINI55LDE\", 0x00505500, NUMICRO_BANKS_GENERAL(35 * 512, 0 * 1024, 2 * 1024, 8)},"},{"line_number":219,"context_line":"\t{\"MINI55ZDE\", 0x00505503, NUMICRO_BANKS_GENERAL(35 * 512, 0 * 1024, 2 * 1024, 8)},"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"\t/* MINI58 */"},{"line_number":222,"context_line":"\t{\"MINI58FDE\", 0x00A05805, NUMICRO_BANKS_GENERAL(32 * 1024, 0 * 1024, 5 * 512, 8)},"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"d8946ded_bc542cc2","line":219,"range":{"start_line":218,"start_character":49,"end_line":219,"end_character":52},"in_reply_to":"06b8398e_f8be2f1f","updated":"2022-11-08 15:21:14.000000000","message":"1. According to Nuvoton\u0027s OpenOCD-Nuvoton [1] MINI55xxx has \"35 * 512\" bytes APROM.\n2. According to Table 4.2-1 NuMicro® Mini55 Series Product Selection Guide of NuMicro® Family Mini55 Series Datasheet [2], it shows the series chips have 17.5 KB \u003d 35 * 512 APROM. \n[1]: https://github.com/OpenNuvoton/OpenOCD-Nuvoton/blob/b78f50ab953b2a70d733a5f4e36b420a4a2ae834/src/flash/nor/numicro.c#L367-L368\n[2]: https://www.nuvoton.com/export/resource-files/DS_Mini55_Series_EN_Rev1.01.pdf","commit_id":"d0ffb5f9f97b0bb00896bd50873aab2692491f27"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"476abf7e9e6d45c85264f1fb72051d5489d32a58","unresolved":true,"context_lines":[{"line_number":219,"context_line":"\t{\"MINI55ZDE\", 0x00505503, NUMICRO_BANKS_GENERAL(35 * 512, 0 * 1024, 2 * 1024, 8)},"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"\t/* MINI58 */"},{"line_number":222,"context_line":"\t{\"MINI58FDE\", 0x00A05805, NUMICRO_BANKS_GENERAL(32 * 1024, 0 * 1024, 5 * 512, 8)},"},{"line_number":223,"context_line":"\t{\"MINI58LDE\", 0x00A05800, NUMICRO_BANKS_GENERAL(32 * 1024, 0 * 1024, 5 * 512, 8)},"},{"line_number":224,"context_line":"\t{\"MINI58TDE\", 0x00A05804, NUMICRO_BANKS_GENERAL(32 * 1024, 0 * 1024, 5 * 512, 8)},"},{"line_number":225,"context_line":"\t{\"MINI58ZDE\", 0x00A05803, NUMICRO_BANKS_GENERAL(32 * 1024, 0 * 1024, 5 * 512, 8)},"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"57b75774_e62cca60","line":222,"range":{"start_line":222,"start_character":70,"end_line":222,"end_character":71},"updated":"2022-11-06 23:01:02.000000000","message":"other odd number 5","commit_id":"d0ffb5f9f97b0bb00896bd50873aab2692491f27"},{"author":{"_account_id":1001899,"name":"Jian-Hong Pan","email":"chienhung.pan@gmail.com","username":"starnight"},"change_message_id":"597b13ad063b6fb5b1c68502bb76ef82b9378046","unresolved":false,"context_lines":[{"line_number":219,"context_line":"\t{\"MINI55ZDE\", 0x00505503, NUMICRO_BANKS_GENERAL(35 * 512, 0 * 1024, 2 * 1024, 8)},"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"\t/* MINI58 */"},{"line_number":222,"context_line":"\t{\"MINI58FDE\", 0x00A05805, NUMICRO_BANKS_GENERAL(32 * 1024, 0 * 1024, 5 * 512, 8)},"},{"line_number":223,"context_line":"\t{\"MINI58LDE\", 0x00A05800, NUMICRO_BANKS_GENERAL(32 * 1024, 0 * 1024, 5 * 512, 8)},"},{"line_number":224,"context_line":"\t{\"MINI58TDE\", 0x00A05804, NUMICRO_BANKS_GENERAL(32 * 1024, 0 * 1024, 5 * 512, 8)},"},{"line_number":225,"context_line":"\t{\"MINI58ZDE\", 0x00A05803, NUMICRO_BANKS_GENERAL(32 * 1024, 0 * 1024, 5 * 512, 8)},"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"aa70dd1e_7a6aeb2b","line":222,"range":{"start_line":222,"start_character":70,"end_line":222,"end_character":71},"in_reply_to":"57b75774_e62cca60","updated":"2022-11-08 15:21:14.000000000","message":"1. According to Nuvoton\u0027s OpenOCD-Nuvoton [1] MINI58xxx has \"5 * 512\" bytes ISP Loader ROM.\n2. According to Table 4.2-1 NuMicro® Mini58 Series Product Selection Guide of NuMicro® Family Mini58DE Series Datasheet [2], it shows the series chips have 2.5 KB \u003d 5 * 512 ISP Loader ROM. \n[1]: https://github.com/OpenNuvoton/OpenOCD-Nuvoton/blob/b78f50ab953b2a70d733a5f4e36b420a4a2ae834/src/flash/nor/numicro.c#L378-L382\n[2]: https://www.nuvoton.com/export/resource-files/DS_Mini58DE_Series_EN_Rev1.04.pdf","commit_id":"d0ffb5f9f97b0bb00896bd50873aab2692491f27"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"476abf7e9e6d45c85264f1fb72051d5489d32a58","unresolved":true,"context_lines":[{"line_number":252,"context_line":"\t{\"NANO100KC2BN\", 0x00110040, NUMICRO_BANKS_GENERAL(64 * 1024,  0 * 1024, 4 * 1024, 8)},"},{"line_number":253,"context_line":"\t{\"NANO100KD2BN\", 0x00110039, NUMICRO_BANKS_GENERAL(64 * 1024,  0 * 1024, 4 * 1024, 8)},"},{"line_number":254,"context_line":"\t{\"NANO100KD3BN\", 0x00110038, NUMICRO_BANKS_GENERAL(64 * 1024,  0 * 1024, 4 * 1024, 8)},"},{"line_number":255,"context_line":"\t{\"NANO100KE3BN\", 0x00110030, NUMICRO_BANKS_GENERAL(123 * 1024, 0 * 1024, 4 * 1024, 8)},"},{"line_number":256,"context_line":"\t{\"NANO100LC2BN\", 0x00110043, NUMICRO_BANKS_GENERAL(32 * 1024,  0 * 1024, 4 * 1024, 8)},"},{"line_number":257,"context_line":"\t{\"NANO100LD2BN\", 0x0011003F, NUMICRO_BANKS_GENERAL(64 * 1024,  0 * 1024, 4 * 1024, 8)},"},{"line_number":258,"context_line":"\t{\"NANO100LD3BN\", 0x0011003E, NUMICRO_BANKS_GENERAL(64 * 1024,  0 * 1024, 4 * 1024, 8)},"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"eacee9d0_787fa525","line":255,"range":{"start_line":255,"start_character":52,"end_line":255,"end_character":55},"updated":"2022-11-06 23:01:02.000000000","message":"also 123 looks odd, but some were present in former version of the file","commit_id":"d0ffb5f9f97b0bb00896bd50873aab2692491f27"},{"author":{"_account_id":1001899,"name":"Jian-Hong Pan","email":"chienhung.pan@gmail.com","username":"starnight"},"change_message_id":"597b13ad063b6fb5b1c68502bb76ef82b9378046","unresolved":false,"context_lines":[{"line_number":252,"context_line":"\t{\"NANO100KC2BN\", 0x00110040, NUMICRO_BANKS_GENERAL(64 * 1024,  0 * 1024, 4 * 1024, 8)},"},{"line_number":253,"context_line":"\t{\"NANO100KD2BN\", 0x00110039, NUMICRO_BANKS_GENERAL(64 * 1024,  0 * 1024, 4 * 1024, 8)},"},{"line_number":254,"context_line":"\t{\"NANO100KD3BN\", 0x00110038, NUMICRO_BANKS_GENERAL(64 * 1024,  0 * 1024, 4 * 1024, 8)},"},{"line_number":255,"context_line":"\t{\"NANO100KE3BN\", 0x00110030, NUMICRO_BANKS_GENERAL(123 * 1024, 0 * 1024, 4 * 1024, 8)},"},{"line_number":256,"context_line":"\t{\"NANO100LC2BN\", 0x00110043, NUMICRO_BANKS_GENERAL(32 * 1024,  0 * 1024, 4 * 1024, 8)},"},{"line_number":257,"context_line":"\t{\"NANO100LD2BN\", 0x0011003F, NUMICRO_BANKS_GENERAL(64 * 1024,  0 * 1024, 4 * 1024, 8)},"},{"line_number":258,"context_line":"\t{\"NANO100LD3BN\", 0x0011003E, NUMICRO_BANKS_GENERAL(64 * 1024,  0 * 1024, 4 * 1024, 8)},"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"fe6766e5_ac517b69","line":255,"range":{"start_line":255,"start_character":52,"end_line":255,"end_character":55},"in_reply_to":"eacee9d0_787fa525","updated":"2022-11-08 15:21:14.000000000","message":"1. According to Nuvoton\u0027s OpenOCD-Nuvoton [1] NANO100KE3BN has \"123 * 1024\" bytes APROM.\n2. According to section \"5.6.2 Features\" of NuMicro® Family Nano100 Series Datasheet [2], it shows 32/64/123 KB application program memory (APROM). \n[1]: https://github.com/OpenNuvoton/OpenOCD-Nuvoton/blob/b78f50ab953b2a70d733a5f4e36b420a4a2ae834/src/flash/nor/numicro.c#L421\n[2]: https://www.nuvoton.com/export/resource-files/DS_Nano100%28B%29_Series_EN_Rev1.09.pdf\n\nAcuatully, I think 123 KB is really special, too.  However, both the code of OpenOCD-Nuvoton and the datasheet say 123 KB APROM.\n\nFiled an issue to OpenOCD-Nuvoton https://github.com/OpenNuvoton/OpenOCD-Nuvoton/issues/27\n\nI think it is okay to merge this version.  If Nuvoton updates the APROM size of the related chips, we can have another commit by following Nuvoton\u0027s new modification.","commit_id":"d0ffb5f9f97b0bb00896bd50873aab2692491f27"},{"author":{"_account_id":1001899,"name":"Jian-Hong Pan","email":"chienhung.pan@gmail.com","username":"starnight"},"change_message_id":"d67354dfe7aa0490b36a2cc5ce15fdf80b60cde6","unresolved":false,"context_lines":[{"line_number":252,"context_line":"\t{\"NANO100KC2BN\", 0x00110040, NUMICRO_BANKS_GENERAL(64 * 1024,  0 * 1024, 4 * 1024, 8)},"},{"line_number":253,"context_line":"\t{\"NANO100KD2BN\", 0x00110039, NUMICRO_BANKS_GENERAL(64 * 1024,  0 * 1024, 4 * 1024, 8)},"},{"line_number":254,"context_line":"\t{\"NANO100KD3BN\", 0x00110038, NUMICRO_BANKS_GENERAL(64 * 1024,  0 * 1024, 4 * 1024, 8)},"},{"line_number":255,"context_line":"\t{\"NANO100KE3BN\", 0x00110030, NUMICRO_BANKS_GENERAL(123 * 1024, 0 * 1024, 4 * 1024, 8)},"},{"line_number":256,"context_line":"\t{\"NANO100LC2BN\", 0x00110043, NUMICRO_BANKS_GENERAL(32 * 1024,  0 * 1024, 4 * 1024, 8)},"},{"line_number":257,"context_line":"\t{\"NANO100LD2BN\", 0x0011003F, NUMICRO_BANKS_GENERAL(64 * 1024,  0 * 1024, 4 * 1024, 8)},"},{"line_number":258,"context_line":"\t{\"NANO100LD3BN\", 0x0011003E, NUMICRO_BANKS_GENERAL(64 * 1024,  0 * 1024, 4 * 1024, 8)},"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"e54d7694_054d327c","line":255,"range":{"start_line":255,"start_character":52,"end_line":255,"end_character":55},"in_reply_to":"fe6766e5_ac517b69","updated":"2022-11-09 12:10:53.000000000","message":"The 123 KB APROM is confirmed!\nhttps://github.com/OpenNuvoton/OpenOCD-Nuvoton/issues/27#issuecomment-1308129754","commit_id":"d0ffb5f9f97b0bb00896bd50873aab2692491f27"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"476abf7e9e6d45c85264f1fb72051d5489d32a58","unresolved":true,"context_lines":[{"line_number":397,"context_line":"\t{\"NUC120VE3DN\", 0x30012018, NUMICRO_BANKS_GENERAL(128 * 1024, 0 * 1024, 4 * 1024, 8)},"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"\t/* NUC121 */"},{"line_number":400,"context_line":"\t{\"NUC121SC2AE\", 0x00012105, NUMICRO_BANKS_GENERAL(32 * 1024, 0 * 1024, 9 * 512, 8)},"},{"line_number":401,"context_line":"\t{\"NUC121LC2AE\", 0x00012125, NUMICRO_BANKS_GENERAL(32 * 1024, 0 * 1024, 9 * 512, 8)},"},{"line_number":402,"context_line":"\t{\"NUC121ZC2AE\", 0x00012145, NUMICRO_BANKS_GENERAL(32 * 1024, 0 * 1024, 9 * 512, 8)},"},{"line_number":403,"context_line":"\t{\"NUC125SC2AE\", 0x00012505, NUMICRO_BANKS_GENERAL(32 * 1024, 0 * 1024, 9 * 512, 8)},"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"bc711dc9_6a9c6e80","line":400,"range":{"start_line":400,"start_character":72,"end_line":400,"end_character":73},"updated":"2022-11-06 23:01:02.000000000","message":"other odd number 9","commit_id":"d0ffb5f9f97b0bb00896bd50873aab2692491f27"},{"author":{"_account_id":1001899,"name":"Jian-Hong Pan","email":"chienhung.pan@gmail.com","username":"starnight"},"change_message_id":"597b13ad063b6fb5b1c68502bb76ef82b9378046","unresolved":false,"context_lines":[{"line_number":397,"context_line":"\t{\"NUC120VE3DN\", 0x30012018, NUMICRO_BANKS_GENERAL(128 * 1024, 0 * 1024, 4 * 1024, 8)},"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"\t/* NUC121 */"},{"line_number":400,"context_line":"\t{\"NUC121SC2AE\", 0x00012105, NUMICRO_BANKS_GENERAL(32 * 1024, 0 * 1024, 9 * 512, 8)},"},{"line_number":401,"context_line":"\t{\"NUC121LC2AE\", 0x00012125, NUMICRO_BANKS_GENERAL(32 * 1024, 0 * 1024, 9 * 512, 8)},"},{"line_number":402,"context_line":"\t{\"NUC121ZC2AE\", 0x00012145, NUMICRO_BANKS_GENERAL(32 * 1024, 0 * 1024, 9 * 512, 8)},"},{"line_number":403,"context_line":"\t{\"NUC125SC2AE\", 0x00012505, NUMICRO_BANKS_GENERAL(32 * 1024, 0 * 1024, 9 * 512, 8)},"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"ea1ab9da_009d0b7e","line":400,"range":{"start_line":400,"start_character":72,"end_line":400,"end_character":73},"in_reply_to":"bc711dc9_6a9c6e80","updated":"2022-11-08 15:21:14.000000000","message":"1. According to Nuvoton\u0027s OpenOCD-Nuvoton [1] NUC121/125 has \"9 * 512\" bytes ISP Loader ROM.\n2. According to \"Table 4.1-1 NuMicro® NUC121 USB Series Selection Guide\" and \"Table 4.1-2 NuMicro® NUC125 USB Series Selection Guide\" of NuMicro® Family NUC121/125 Series Datasheet [2], they show the series chips have 4.5 KB \u003d 9 * 512 ISP Loader ROM. \n[1]: https://github.com/OpenNuvoton/OpenOCD-Nuvoton/blob/b78f50ab953b2a70d733a5f4e36b420a4a2ae834/src/flash/nor/numicro.c#L598-L605\n[2]: https://www.nuvoton.com/export/resource-files/DS_NUC121_125_Series_EN_Rev1.04.pdf","commit_id":"d0ffb5f9f97b0bb00896bd50873aab2692491f27"}]}