)]}'
{"id":"openocd~master~I12e79580f2936b1622fb7231d9a2484a763ba72a","project":"openocd","branch":"master","topic":"after 0.12 release","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-11-15 21:53:06.000000000","reason":"Antonio Borneo replied on the change"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2022-11-15 17:21:50.000000000","reason":"Tomas Vanek replied on the change"}},"hashtags":[],"change_id":"I12e79580f2936b1622fb7231d9a2484a763ba72a","subject":"tools: add disassembler helper for files .inc","status":"MERGED","created":"2022-11-13 15:08:20.000000000","updated":"2023-01-15 15:06:56.000000000","submitted":"2023-01-15 15:06:56.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":6,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"7347-after 0.12 release","meta_rev_id":"a57a38a244ec407e9bedd8f738bd1734608b270a","_number":7347,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-01-15 15:06:56.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-01-15 15:06:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-01-15 15:06:56.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-11-13 15:08:20.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2022-11-13 15:48:14.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"3717a00f5fbdf4a1eeef9776aa781380cf3e6194","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-11-13 15:08:20.000000000","message":"Uploaded patch set 1: Code-Review+1.","accounts_in_message":[],"_revision_number":1},{"id":"73d58244c630a612ad96b0b9c97f8c53aa5b935b","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-11-13 15:48:14.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16231/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17021/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"7fd7e672489e8e66953cea6c5b95a389901c7e4b","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-11-13 19:45:11.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"8340760dc798d9cd1debe3cdccd15bf211209f20","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-11-13 23:20:39.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"0c51c6fd1d685ae863221d0b283b2dc0b8eea9d9","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-11-14 07:51:03.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f40310fe32a2b1f520493ef6fc1567f1afd4af38","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-11-14 08:28:28.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"66421e98bd05f5ed7f7c339a5cd38ed7da27f230","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-11-14 14:16:49.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"d35323a4d3d952efd1d47f0294e6b124c24d4a1d","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-11-14 14:43:30.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16238/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17028/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"bbfa6f0fbb4ccd029b7d7a3a99f2c6cf61048a88","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-11-15 17:21:50.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"ac26dc2993de65e3f9550ad776d5b06ef48ba085","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-11-15 21:52:21.000000000","message":"Topic set to after 0.12 release","accounts_in_message":[],"_revision_number":2},{"id":"fd2630a5354409505986335ad3dac32e01c8b466","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-11-15 21:53:06.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"2f48394e31eee6dace7623f9d7738dae850886b8","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-01-15 14:34:38.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"a57a38a244ec407e9bedd8f738bd1734608b270a","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-01-15 15:06:56.000000000","message":"Change has been successfully cherry-picked as 9dac3b247b43d8b91821560b7c99fbd33d736419","accounts_in_message":[],"_revision_number":3}],"current_revision":"9dac3b247b43d8b91821560b7c99fbd33d736419","revisions":{"9dac3b247b43d8b91821560b7c99fbd33d736419":{"kind":"REWORK","_number":3,"created":"2023-01-15 15:06:56.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/47/7347/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/47/7347/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/47/7347/3 \u0026\u0026 git checkout -b change-7347 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/47/7347/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/47/7347/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/47/7347/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/47/7347/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/47/7347/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6d76a915214f06a4960710ae171434265409a705","subject":"doc: usb_adapters: add other adapters"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-11-13 14:46:19.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-01-15 15:06:56.000000000","tz":0},"subject":"tools: add disassembler helper for files .inc","message":"tools: add disassembler helper for files .inc\n\nWe are moving the binary helpers in files .inc in contrib/loaders/\nbut we have no support to disassemble them for checking their\ncontent, nor documentation to give any hint.\n\nAdd a simple script that uses objdump to directly disassemble a\nfile .inc\nUse Cortex-M settings as default, but provide the flexibility to\nreuse the script for any other target CPU.\n\nChange-Id: I12e79580f2936b1622fb7231d9a2484a763ba72a\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7347\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"2bfbd864b66d54b5698b774c0a274ec0e886221e":{"kind":"REWORK","_number":2,"created":"2022-11-14 14:16:49.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/47/7347/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/47/7347/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/47/7347/2 \u0026\u0026 git checkout -b change-7347 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/47/7347/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/47/7347/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/47/7347/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/47/7347/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/47/7347/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4e077fddadd7d8fedacc61f59ce18a700f6759cf","subject":"tcl/cpld/xilinx-xcu: fix typo"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-11-13 14:46:19.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-11-14 14:16:04.000000000","tz":60},"subject":"tools: add disassembler helper for files .inc","message":"tools: add disassembler helper for files .inc\n\nWe are moving the binary helpers in files .inc in contrib/loaders/\nbut we have no support to disassemble them for checking their\ncontent, nor documentation to give any hint.\n\nAdd a simple script that uses objdump to directly disassemble a\nfile .inc\nUse Cortex-M settings as default, but provide the flexibility to\nreuse the script for any other target CPU.\n\nChange-Id: I12e79580f2936b1622fb7231d9a2484a763ba72a\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"b73da708c6309f53b84793b7efd75b058f0eca4c":{"kind":"REWORK","_number":1,"created":"2022-11-13 15:08:20.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/47/7347/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/47/7347/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/47/7347/1 \u0026\u0026 git checkout -b change-7347 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/47/7347/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/47/7347/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/47/7347/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/47/7347/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/47/7347/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4e077fddadd7d8fedacc61f59ce18a700f6759cf","subject":"tcl/cpld/xilinx-xcu: fix typo"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-11-13 14:46:19.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-11-13 15:00:00.000000000","tz":60},"subject":"tools: add disassembler helper for files .inc","message":"tools: add disassembler helper for files .inc\n\nWe are moving the binary helpers in files .inc in contrib/loaders/\nbut we have no support to disassemble them for checking their\ncontent, nor documentation to give any hint.\n\nAdd a simple script that uses objdump to directly disassemble a\nfile .inc\nUse Cortex-M settings as default, but provide the flexibility to\nreuse the script for any other target CPU.\n\nChange-Id: I12e79580f2936b1622fb7231d9a2484a763ba72a\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}
