)]}'
{"id":"openocd~master~I60e427bda795d7a13d55d61443590dd31d694832","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001975":{"account":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"last_update":"2023-05-24 05:27:02.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-05-24 05:27:02.000000000","reason":"Change was submitted"},"1002041":{"account":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},"last_update":"2023-05-15 09:11:07.000000000","reason":"\u003cGERRIT_ACCOUNT_1002041\u003e replied on the change","reason_account":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"}},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2023-05-15 16:25:02.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I60e427bda795d7a13d55d61443590dd31d694832","subject":"jtag/drivers/bcm2835gpio: add peripheral_mem_dev config command","status":"MERGED","created":"2022-11-15 11:19:01.000000000","updated":"2023-05-24 05:27:02.000000000","submitted":"2023-05-24 05:27:02.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":29,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7350","meta_rev_id":"09bcc4aa4f410efa6e5fe34b50741922ee7731da","_number":7350,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-05-24 05:27:02.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-05-24 05:27:02.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-05-24 05:27:02.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"}],"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-11-15 17:43:28.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-11-16 12:09:17.000000000","updated_by":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},"reviewer":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},"state":"REVIEWER"},{"updated":"2023-01-21 10:42:48.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2023-05-09 20:10:28.000000000","updated_by":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"reviewer":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"state":"CC"},{"updated":"2023-05-13 16:51:19.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"d3590bb505bd4d7abea68e2a00ff3be7c46d95b3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-11-15 11:19:01.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2724e0140e092bb8c152b2f3a35ebda8ccac12ba","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-11-15 15:58:20.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"3c9a07c5e20684ec397c3f23c27b09e9f5feb484","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-11-15 17:11:50.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"4aab7a3372aa4584d7980fe0749510f9f5091a59","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-11-15 17:43:28.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16245/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17035/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"072887b75eae1fe7f2ed77d2630245a53093a3f7","author":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},"real_author":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},"date":"2022-11-16 12:09:17.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"09fbbda82318e121fa5d5c8d83dac8be753368ad","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-11-16 12:44:31.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"89bdf6631595d3bdaaa28a854bd895b381895ad4","author":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},"real_author":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},"date":"2022-11-16 14:36:09.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"3216b4307698dd2f8b5ca69144d5fa39fd6448dc","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-01-21 10:42:48.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"68a99881851397fcc2305b53747efa4de5c0502f","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-01-21 12:06:45.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"55cee28aad40f82c9baa63d2af4841de01f2396f","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-01-21 15:57:49.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"49fbfde3c3509cbd9448fb40e49669f4fe6488f0","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-01-24 10:23:06.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"9371e356ec6cae3a3be72dda246f116ccabaf406","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-01-26 23:18:36.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"2cfce2b53cd4d7dd18068564681ae22dfad89620","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-01-27 17:37:54.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"729bc4c070c49b10343fc9e5820460f6cc9a0a70","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-03-06 21:16:33.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"b0b238522df814de894e934ff79c53ea648a9cb3","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-03-06 21:25:27.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"b4cce205c9831d56c0d0c24d9177de37e9ee118d","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-03-31 07:24:43.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"e0f261a504b65b89716386842e2a4e094792add3","author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"real_author":{"_account_id":1001975,"name":"Steve Marple","email":"stevemarple@googlemail.com","username":"stevemarple"},"date":"2023-05-09 20:10:28.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"a315a99d54e5d6c5f435beb08f3b7b57d3dfbed1","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-10 08:42:23.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"8a04fb9e6690076d9594a17f40e0881f5e75a140","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-05-12 08:05:46.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"862b7802c632574869c06ce71584c09aa440ee68","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-12 13:10:26.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"fc8c08b8b8f2812dc2f680eff82a27ff452766b3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-05-13 08:44:22.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Code-Review+1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"fecc0b01e49bdd14a68372bd48145b8363bef01c","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-05-13 08:57:50.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"b57727e808d5f85956396071c8b1d737404afeb2","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-05-13 10:43:09.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17711/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/16912/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"d467762f39598946854434753a6f309f0517f5f3","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-05-13 12:25:35.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"19bea7edf2dd344af1695cbb6a3164da168fed1b","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-05-13 16:51:19.000000000","message":"Patch Set 3: Code-Review+1\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"8e297624404e0958e457e9c601729d24b4163ddf","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-05-13 20:21:29.000000000","message":"Patch Set 4: Published edit on patch set 3.\n\nOutdated Votes:\n* Code-Review+1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":4},{"id":"83411fe40cd7cc098c185a0df24203889da8b148","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-05-13 20:29:24.000000000","message":"Patch Set 4:\n\n(4 comments)","accounts_in_message":[],"_revision_number":4},{"id":"02b5f41b6dde18fbba7a3ffd6273fa861252d42e","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2023-05-14 01:50:11.000000000","message":"Patch Set 4: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17719/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/16921/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"e8bfba765dbfd5b1db174b61ac56622d6f783a80","author":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},"real_author":{"_account_id":1002041,"name":"Jonathan Bell","email":"jonathan@raspberrypi.com","username":"jonathan.bell"},"date":"2023-05-15 09:11:07.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"5d1637329b04d8c6a73a31acda17821f05f9daa8","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-05-15 16:25:02.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"09bcc4aa4f410efa6e5fe34b50741922ee7731da","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2023-05-24 05:27:02.000000000","message":"Change has been successfully cherry-picked as 5c46a5de49f5dd14227b9444a5815eaaadd7ceb4","accounts_in_message":[],"_revision_number":5}],"current_revision":"5c46a5de49f5dd14227b9444a5815eaaadd7ceb4","revisions":{"9f8418ec20d715c1f9fd3760759d66982edd9bd0":{"kind":"REWORK","_number":2,"created":"2022-11-15 17:11:50.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/50/7350/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/50/7350/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/50/7350/2 \u0026\u0026 git checkout -b change-7350 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/50/7350/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/50/7350/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/50/7350/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/50/7350/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/50/7350/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"563cd6a643d4fa46a9fe49ff4d56eae8c17cf641","subject":"tcl/interface: universal config for all Raspberry Pi models"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-11-15 08:47:43.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-11-15 17:11:25.000000000","tz":60},"subject":"jtag/drivers/bcm2835gpio: deprecate /dev/mem access to GPIO control","message":"jtag/drivers/bcm2835gpio: deprecate /dev/mem access to GPIO control\n\nDeprecate /dev/mem in favour of /dev/gpiomem.\n/dev/gpiomem is available in Raspberry linux kernel since ~2016\nand unlike /dev/mem doesn\u0027t require root access. Also it doesn\u0027t need\na peripheral base address.\n\nHowever the pads configuration (slew rate, drive strength) requires\n/dev/mem access, no way to set the pads with mapped /dev/gpiomem.\n\nWithout this change the driver code preferred /dev/gpiomem and if not\navailable falled back /dev/mem.\nThe pads were configured at a wrong memory address if gpiomem was mapped.\n\nFor the limited time until /dev/mem access is completely dropped\nuse \u0027bcm2835gpio peripheral_base\u0027 parameter to choose the memory\naccess device.\n\nWithout peripheral_base (or peripheral_base 0) use /dev/gpiomem\nIf a non-zero peripheral_base is configured, use /dev/mem\nand issue a warning.\n\nDisable the pads setting if the driver doesn\u0027t open /dev/mem.\n\nWhile on it extend peripheral_base to uint64_t\nRaspberry Pi 4 with 64-bit kernel and arm_peri_high\u003d1 config.txt\nparameter has peripheral_base 0x47e000000\n\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nChange-Id: I60e427bda795d7a13d55d61443590dd31d694832\n"}},"34994fd1a0c2c7f56108fc48918b86fe83d8e161":{"kind":"REWORK","_number":3,"created":"2023-05-13 08:44:22.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/50/7350/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/50/7350/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/50/7350/3 \u0026\u0026 git checkout -b change-7350 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/50/7350/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/50/7350/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/50/7350/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/50/7350/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/50/7350/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"03b4b64ccbe92a54ca7d0aa85fef9f932d16600c","subject":"jtag/drivers/bcm2835gpio: extend peripheral_base to off_t"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2023-05-13 04:39:48.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2023-05-13 08:44:05.000000000","tz":120},"subject":"jtag/drivers/bcm2835gpio: add peripheral_mem_dev config command","message":"jtag/drivers/bcm2835gpio: add peripheral_mem_dev config command\n\nThe bcm2835gpio driver preferred /dev/gpiomem for access to\nmemory mapped GPIO control and used /dev/mem as a fallback\nonly if it couldn\u0027t open /dev/gpiomem.\n\n/dev/mem usually requires elevated rights or specific capabilities\nof the opening process, so the fallback failed anyway.\n\nAlthough /dev/gpiomem is the strongly preferred option with respect\nto security, there could be also use cases which require /dev/mem\neven if /dev/gpiomem is available (e.g. changing the GPIO pad\nsettings is necessary or testing/debugging OpenOCD).\nIt was difficult to handle such cases because they required\nto block globally the system device /dev/gpiomem\n(remove, rename or chmod).\n\nDrop the fallback feature and select the memory device\nby \u0027bcm2835gpio peripheral_mem_dev\u0027 configuration command.\nUse /dev/gpiomem as a default.\n\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nChange-Id: I60e427bda795d7a13d55d61443590dd31d694832\n"}},"3b4c81c6c3f9f7ab41d1bada998884a49d988c2d":{"kind":"REWORK","_number":1,"created":"2022-11-15 11:19:01.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/50/7350/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/50/7350/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/50/7350/1 \u0026\u0026 git checkout -b change-7350 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/50/7350/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/50/7350/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/50/7350/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/50/7350/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/50/7350/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"563cd6a643d4fa46a9fe49ff4d56eae8c17cf641","subject":"tcl/interface: universal config for all Raspberry Pi models"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-11-15 08:47:43.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-11-15 11:12:17.000000000","tz":60},"subject":"jtag/drivers/bcm2835gpio: deprecate /dev/mem access to GPIO control","message":"jtag/drivers/bcm2835gpio: deprecate /dev/mem access to GPIO control\n\nDeprecate /dev/mem in favour of /dev/gpiomem.\n/dev/gpiomem is available in Raspberry linux kernel since ~2016\nand unlike /dev/mem doesn\u0027t require root access. Also it doesn\u0027t need\na peripheral base address.\n\nHowever the pads configuration (slew rate, drive strength) requires\n/dev/mem access, no way to set the pads with mapped /dev/gpiomem.\n\nWithout this change the driver code preferred /dev/gpiomem and if not\navailable falled back /dev/mem.\nThe pads were configured at a wrong memory address if gpiomem was mapped.\n\nFor the limited time until /dev/mem access is completely dropped\nuse \u0027bcm2835gpio peripheral_base\u0027 parameter to choose the memory\naccess device.\n\nWithout peripheral_base (or peripheral_base 0) use /dev/gpiomem\nIf a non-zero peripheral_base is configured, use /dev/mem\nand issue a warning.\n\nDisable the pads setting if the driver doesn\u0027t open /dev/mem.\n\nWhile on it extend peripheral_base to uint64_t\nRaspberry Pi 4 with 64-bit kernel and arm_peri_high\u003d1 config.txt\nparameter has peripheral_base 0x47e000000\n\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nChange-Id: I60e427bda795d7a13d55d61443590dd31d694832\n"}},"5be0f2401612d916e10e81847e7c235fd71349ec":{"kind":"REWORK","_number":4,"created":"2023-05-13 20:21:29.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/50/7350/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/50/7350/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/50/7350/4 \u0026\u0026 git checkout -b change-7350 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/50/7350/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/50/7350/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/50/7350/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/50/7350/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/50/7350/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"03b4b64ccbe92a54ca7d0aa85fef9f932d16600c","subject":"jtag/drivers/bcm2835gpio: extend peripheral_base to off_t"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2023-05-13 04:39:48.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2023-05-13 20:21:23.000000000","tz":0},"subject":"jtag/drivers/bcm2835gpio: add peripheral_mem_dev config command","message":"jtag/drivers/bcm2835gpio: add peripheral_mem_dev config command\n\nThe bcm2835gpio driver preferred /dev/gpiomem for access to\nmemory mapped GPIO control and used /dev/mem as a fallback\nonly if it couldn\u0027t open /dev/gpiomem.\n\n/dev/mem usually requires elevated rights or specific capabilities\nof the opening process, so the fallback failed anyway.\n\nAlthough /dev/gpiomem is the strongly preferred option with respect\nto security, there could be also use cases which require /dev/mem\neven if /dev/gpiomem is available (e.g. changing the GPIO pad\nsettings is necessary or testing/debugging OpenOCD).\nIt was difficult to handle such cases because they required\nto block globally the system device /dev/gpiomem\n(remove, rename or chmod).\n\nDrop the fallback feature and select the memory device\nby \u0027bcm2835gpio peripheral_mem_dev\u0027 configuration command.\nUse /dev/gpiomem as a default.\n\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nChange-Id: I60e427bda795d7a13d55d61443590dd31d694832\n"}},"5c46a5de49f5dd14227b9444a5815eaaadd7ceb4":{"kind":"REWORK","_number":5,"created":"2023-05-24 05:27:02.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/50/7350/5","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/50/7350/5","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/50/7350/5 \u0026\u0026 git checkout -b change-7350 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/50/7350/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/50/7350/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/50/7350/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/50/7350/5","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/50/7350/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b41b368255d53d9561851900eeeba38b12720a82","subject":"jtag/drivers/bcm2835gpio: extend peripheral_base to off_t"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2023-05-13 04:39:48.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2023-05-24 05:27:02.000000000","tz":0},"subject":"jtag/drivers/bcm2835gpio: add peripheral_mem_dev config command","message":"jtag/drivers/bcm2835gpio: add peripheral_mem_dev config command\n\nThe bcm2835gpio driver preferred /dev/gpiomem for access to\nmemory mapped GPIO control and used /dev/mem as a fallback\nonly if it couldn\u0027t open /dev/gpiomem.\n\n/dev/mem usually requires elevated rights or specific capabilities\nof the opening process, so the fallback failed anyway.\n\nAlthough /dev/gpiomem is the strongly preferred option with respect\nto security, there could be also use cases which require /dev/mem\neven if /dev/gpiomem is available (e.g. changing the GPIO pad\nsettings is necessary or testing/debugging OpenOCD).\nIt was difficult to handle such cases because they required\nto block globally the system device /dev/gpiomem\n(remove, rename or chmod).\n\nDrop the fallback feature and select the memory device\nby \u0027bcm2835gpio peripheral_mem_dev\u0027 configuration command.\nUse /dev/gpiomem as a default.\n\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nChange-Id: I60e427bda795d7a13d55d61443590dd31d694832\nReviewed-on: https://review.openocd.org/c/openocd/+/7350\nTested-by: jenkins\nReviewed-by: Jonathan Bell \u003cjonathan@raspberrypi.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}