)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"change_message_id":"69da21c51d83df2dbade1cbec60059da0ef5b8b9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4300dde2_747ce106","updated":"2022-11-29 13:47:08.000000000","message":"I think https://review.openocd.org/gitweb?p\u003dopenocd.git;a\u003dblob;f\u003dsrc/pld/pld.c;h\u003de2e0ef41387df1ebdac822499ec75455a6000d9b;hb\u003dHEAD#l136 would be a \"perfect\" place to put in some simple validation like \"is a file\" and \"is readable\" globally, and then you could drop it from all of these places.","commit_id":"2f54b4d8618021c37584ef648dbae71c6ec4e179"},{"author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"change_message_id":"56fd079ad79d7215db2aef40c0db666d9aa08f05","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ca1449bf_88e9ecf7","updated":"2022-11-29 13:41:59.000000000","message":"reply to publish comments","commit_id":"2f54b4d8618021c37584ef648dbae71c6ec4e179"},{"author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"change_message_id":"2db9a4cb72b2c128d9836a7e582e316586306878","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"63432cbf_dc78d802","in_reply_to":"2b45ad27_e0f28ff4","updated":"2022-11-30 09:27:12.000000000","message":"I completely understand and personally have no objections to doing a cleanup patch afterwards.","commit_id":"2f54b4d8618021c37584ef648dbae71c6ec4e179"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"96259cfd43ee1aa51b6308ea9c64f1ebc31648bf","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2b45ad27_e0f28ff4","in_reply_to":"4300dde2_747ce106","updated":"2022-11-30 01:24:37.000000000","message":"There are 6 patches (ecp2/3, ecp5, certus, efinix, intel, gowin) which will benefit from these changes. Shall I add a patch set to all of them or wait after the merge and add a new patch then? It would save me a lot of rebaseing when I can prepare a patch afterwards.","commit_id":"2f54b4d8618021c37584ef648dbae71c6ec4e179"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"a1cb8dcdd818cfc6292e902ccc67e5cc5be8c6d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cb16bd38_33dd4e4e","in_reply_to":"63432cbf_dc78d802","updated":"2022-11-30 15:27:01.000000000","message":"So I will prepare a patch afterwards, I promise. Thanks.","commit_id":"2f54b4d8618021c37584ef648dbae71c6ec4e179"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"0fa42adc5329cbe3ac5e605fbcbb3454e0fd32cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4f64dd6f_96e09b56","in_reply_to":"ca1449bf_88e9ecf7","updated":"2022-11-30 01:25:23.000000000","message":"Done","commit_id":"2f54b4d8618021c37584ef648dbae71c6ec4e179"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"0d960a9a59f381cc7eafb409ded15c9fb9e3954c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ed714a41_e5739d6e","in_reply_to":"cb16bd38_33dd4e4e","updated":"2022-11-30 22:16:18.000000000","message":"done: see patch \"pld: move file sanity checks to pld.c\"","commit_id":"2f54b4d8618021c37584ef648dbae71c6ec4e179"},{"author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"change_message_id":"2db9a4cb72b2c128d9836a7e582e316586306878","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e47af748_535e5cf3","updated":"2022-11-30 09:27:12.000000000","message":"gerrrrrrrit!","commit_id":"6aeef7e825584340cad8c48c4332b821c1b6c214"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"c9efbdb0621cbe291a669e55d7934413b84e6b74","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"afc2001f_fe73713c","updated":"2022-12-19 12:37:12.000000000","message":"\u003e Patch Set 7: Verified-1\n\u003e \n\u003e Build Failed \n\u003e \n\u003e https://build.openocd.org/job/openocd-gerrit-build/16385/ : FAILURE\n\u003e \n\u003e https://build.openocd.org/job/openocd-gerrit/17181/ : SUCCESS\n\n","commit_id":"e43b7a255a62621d27a574276a015039b97a36cd"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3255b047893039b9f45384e9c02e05015dca730f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"3915d1eb_485ac7b5","updated":"2023-04-02 16:47:46.000000000","message":"In this patch some file have been renamed or removed.\nUsers that eventually were using them, will find hard to understand why it disappear and what file to use in replacement\nIt would be nice to keep the old file-name, but with a helpful warning:\n # file oldname.cfg replaced by newname.cfg\n echo \"DEPRECATED: use newname.cfg instead of deprecated oldname.cfg\"\n source [find fpga/newname.cfg]","commit_id":"36058d88231ccef70dd37a1a1aa562c73d9abce4"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"695becd29a974b7a86ba7daa7343b1b3007ebe21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"e4d0645c_af624ffa","updated":"2023-04-10 20:19:45.000000000","message":"thanks for reviewing","commit_id":"0dfd71764c7341cc94e5dad00dcf90016bab4a7c"}],"doc/openocd.texi":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3255b047893039b9f45384e9c02e05015dca730f","unresolved":true,"context_lines":[{"line_number":8538,"context_line":"The option @option{family} is one of @var{cycloneiii cycloneiv cyclonev cyclone10 arriaii}."},{"line_number":8539,"context_line":"This is needed when the JTAG ID of the device is ambiguous (same ID is used for chips in different families)."},{"line_number":8540,"context_line":""},{"line_number":8541,"context_line":"As input file format the driver supports an \u0027.rbf\u0027 (raw bitstream file) file. the \u0027.rbf\u0027 file can be generated"},{"line_number":8542,"context_line":"from a \u0027.sof\u0027 file with @verb{|quartus_cpf -c blinker.sof blinker.rbf|}"},{"line_number":8543,"context_line":""},{"line_number":8544,"context_line":"Defines a new PLD device, an FPGA of the Cyclone III family, using the TAP named @verb{|cycloneiii.tap|}:"}],"source_content_type":"text/x-texinfo","patch_set":12,"id":"a8e3213f_18b51e73","line":8541,"updated":"2023-04-02 16:47:46.000000000","message":"s/an \u0027.rbf\u0027/a \u0027.rbf\u0027/ ?\nUppercase after \u0027.\u0027, s/file. the/file. The/","commit_id":"36058d88231ccef70dd37a1a1aa562c73d9abce4"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"0289e2f642868e8c2d2f0457a9c52afe7dda8cb9","unresolved":false,"context_lines":[{"line_number":8538,"context_line":"The option @option{family} is one of @var{cycloneiii cycloneiv cyclonev cyclone10 arriaii}."},{"line_number":8539,"context_line":"This is needed when the JTAG ID of the device is ambiguous (same ID is used for chips in different families)."},{"line_number":8540,"context_line":""},{"line_number":8541,"context_line":"As input file format the driver supports an \u0027.rbf\u0027 (raw bitstream file) file. the \u0027.rbf\u0027 file can be generated"},{"line_number":8542,"context_line":"from a \u0027.sof\u0027 file with @verb{|quartus_cpf -c blinker.sof blinker.rbf|}"},{"line_number":8543,"context_line":""},{"line_number":8544,"context_line":"Defines a new PLD device, an FPGA of the Cyclone III family, using the TAP named @verb{|cycloneiii.tap|}:"}],"source_content_type":"text/x-texinfo","patch_set":12,"id":"4a5d0f5a_f6c72380","line":8541,"in_reply_to":"a8e3213f_18b51e73","updated":"2023-04-08 20:26:06.000000000","message":"Done","commit_id":"36058d88231ccef70dd37a1a1aa562c73d9abce4"}],"src/pld/intel.c":[{"author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"change_message_id":"56fd079ad79d7215db2aef40c0db666d9aa08f05","unresolved":true,"context_lines":[{"line_number":201,"context_line":"\tif (input_stat.st_size \u003d\u003d 0) {"},{"line_number":202,"context_line":"\t\tLOG_ERROR(\"Empty file %s\", filename);"},{"line_number":203,"context_line":"\t\treturn ERROR_PLD_FILE_LOAD_FAILED;"},{"line_number":204,"context_line":"\t}"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"\t/* check if binary .bin or ascii .bit/.hex */"},{"line_number":207,"context_line":"\tconst char *file_ending_pos \u003d strrchr(filename, \u0027.\u0027);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"44466b3c_b9a171f8","line":204,"updated":"2022-11-29 13:41:59.000000000","message":"Same comments as elsewhere I guess.  Can some of this be handled in pld-\u003eload before it passes down to this layer?  You\u0027ve got this sort of stuff repeated mulitiple times.","commit_id":"2f54b4d8618021c37584ef648dbae71c6ec4e179"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"a1cb8dcdd818cfc6292e902ccc67e5cc5be8c6d7","unresolved":false,"context_lines":[{"line_number":201,"context_line":"\tif (input_stat.st_size \u003d\u003d 0) {"},{"line_number":202,"context_line":"\t\tLOG_ERROR(\"Empty file %s\", filename);"},{"line_number":203,"context_line":"\t\treturn ERROR_PLD_FILE_LOAD_FAILED;"},{"line_number":204,"context_line":"\t}"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"\t/* check if binary .bin or ascii .bit/.hex */"},{"line_number":207,"context_line":"\tconst char *file_ending_pos \u003d strrchr(filename, \u0027.\u0027);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"0718bb0e_9bbe6f99","line":204,"in_reply_to":"44466b3c_b9a171f8","updated":"2022-11-30 15:27:01.000000000","message":"Done","commit_id":"2f54b4d8618021c37584ef648dbae71c6ec4e179"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3255b047893039b9f45384e9c02e05015dca730f","unresolved":true,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"#define BYPASS 0x3FF"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"enum family_e {cycloneiii,"},{"line_number":23,"context_line":"\t\t\t\tcycloneiv,"},{"line_number":24,"context_line":"\t\t\t\tcyclonev,"},{"line_number":25,"context_line":"\t\t\t\tcyclone10,"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"441a759e_9404a93b","line":22,"updated":"2023-04-02 16:47:46.000000000","message":"enum values must be upper case","commit_id":"36058d88231ccef70dd37a1a1aa562c73d9abce4"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"0289e2f642868e8c2d2f0457a9c52afe7dda8cb9","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"#define BYPASS 0x3FF"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"enum family_e {cycloneiii,"},{"line_number":23,"context_line":"\t\t\t\tcycloneiv,"},{"line_number":24,"context_line":"\t\t\t\tcyclonev,"},{"line_number":25,"context_line":"\t\t\t\tcyclone10,"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"3b3f0d29_1a617dba","line":22,"in_reply_to":"441a759e_9404a93b","updated":"2023-04-08 20:26:06.000000000","message":"Done","commit_id":"36058d88231ccef70dd37a1a1aa562c73d9abce4"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3255b047893039b9f45384e9c02e05015dca730f","unresolved":true,"context_lines":[{"line_number":173,"context_line":""},{"line_number":174,"context_line":"\tif (intel_info-\u003echeckpos \u003e\u003d 0 \u0026\u0026 (unsigned int)intel_info-\u003echeckpos \u003e\u003d intel_info-\u003eboundary_scan_length) {"},{"line_number":175,"context_line":"\t\tLOG_ERROR(\"checkpos has to be smaller than scan length %u \u003c %u\","},{"line_number":176,"context_line":"\t\t\t\t\t(unsigned int)intel_info-\u003echeckpos, intel_info-\u003eboundary_scan_length);"},{"line_number":177,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":178,"context_line":"\t}"},{"line_number":179,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":12,"id":"2b6930ff_f24ac99e","line":176,"updated":"2023-04-02 16:47:46.000000000","message":"you can use format converted %d and avoid the (unsigned int) cast","commit_id":"36058d88231ccef70dd37a1a1aa562c73d9abce4"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"0289e2f642868e8c2d2f0457a9c52afe7dda8cb9","unresolved":false,"context_lines":[{"line_number":173,"context_line":""},{"line_number":174,"context_line":"\tif (intel_info-\u003echeckpos \u003e\u003d 0 \u0026\u0026 (unsigned int)intel_info-\u003echeckpos \u003e\u003d intel_info-\u003eboundary_scan_length) {"},{"line_number":175,"context_line":"\t\tLOG_ERROR(\"checkpos has to be smaller than scan length %u \u003c %u\","},{"line_number":176,"context_line":"\t\t\t\t\t(unsigned int)intel_info-\u003echeckpos, intel_info-\u003eboundary_scan_length);"},{"line_number":177,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":178,"context_line":"\t}"},{"line_number":179,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":12,"id":"d4a9c238_ca1ad521","line":176,"in_reply_to":"2b6930ff_f24ac99e","updated":"2023-04-08 20:26:06.000000000","message":"Done","commit_id":"36058d88231ccef70dd37a1a1aa562c73d9abce4"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3255b047893039b9f45384e9c02e05015dca730f","unresolved":true,"context_lines":[{"line_number":417,"context_line":"\tintel_info-\u003echeckpos \u003d -1;"},{"line_number":418,"context_line":"\tintel_info-\u003efamily \u003d family;"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"\tpld-\u003edriver_priv \u003d intel_info;"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"\treturn ERROR_OK;"},{"line_number":423,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"11f65f17_30cb4028","line":420,"updated":"2023-04-02 16:47:46.000000000","message":"memory leak at second call of this command","commit_id":"36058d88231ccef70dd37a1a1aa562c73d9abce4"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"a25731165a5cd2e50a34ac22fe727d73bf63da42","unresolved":false,"context_lines":[{"line_number":417,"context_line":"\tintel_info-\u003echeckpos \u003d -1;"},{"line_number":418,"context_line":"\tintel_info-\u003efamily \u003d family;"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"\tpld-\u003edriver_priv \u003d intel_info;"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"\treturn ERROR_OK;"},{"line_number":423,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"c8a5a4f8_60b511b9","line":420,"in_reply_to":"11f65f17_30cb4028","updated":"2023-04-08 20:58:48.000000000","message":"Not needed. See other patches (eg 7396).","commit_id":"36058d88231ccef70dd37a1a1aa562c73d9abce4"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3255b047893039b9f45384e9c02e05015dca730f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"645d631a_25aa7e93","line":460,"updated":"2023-04-02 16:47:46.000000000","message":"there is an empty line at the end of the file. Please remove it","commit_id":"36058d88231ccef70dd37a1a1aa562c73d9abce4"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"0289e2f642868e8c2d2f0457a9c52afe7dda8cb9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"e31313b5_65ed6f9c","line":460,"in_reply_to":"645d631a_25aa7e93","updated":"2023-04-08 20:26:06.000000000","message":"Done","commit_id":"36058d88231ccef70dd37a1a1aa562c73d9abce4"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"8538dac9a7a865943f9884baa781b7fac50a35a3","unresolved":true,"context_lines":[{"line_number":206,"context_line":"\tstruct scan_field field;"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"\tfield.num_bits \u003d tap-\u003eir_length;"},{"line_number":209,"context_line":"\tvoid *t \u003d calloc(DIV_ROUND_UP(field.num_bits, 8), 1);"},{"line_number":210,"context_line":"\tfield.out_value \u003d t;"},{"line_number":211,"context_line":"\tbuf_set_u32(t, 0, field.num_bits, new_instr);"},{"line_number":212,"context_line":"\tfield.in_value \u003d NULL;"}],"source_content_type":"text/x-csrc","patch_set":14,"id":"b320c9fe_3a44299f","line":209,"updated":"2023-04-10 16:26:33.000000000","message":"if (!t) LOG_ERROR(...);","commit_id":"ec74f01e4ecb54a25833eab0dfbdf0954543c3e7"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"695becd29a974b7a86ba7daa7343b1b3007ebe21","unresolved":false,"context_lines":[{"line_number":206,"context_line":"\tstruct scan_field field;"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"\tfield.num_bits \u003d tap-\u003eir_length;"},{"line_number":209,"context_line":"\tvoid *t \u003d calloc(DIV_ROUND_UP(field.num_bits, 8), 1);"},{"line_number":210,"context_line":"\tfield.out_value \u003d t;"},{"line_number":211,"context_line":"\tbuf_set_u32(t, 0, field.num_bits, new_instr);"},{"line_number":212,"context_line":"\tfield.in_value \u003d NULL;"}],"source_content_type":"text/x-csrc","patch_set":14,"id":"513dc1c7_f08dc0ff","line":209,"in_reply_to":"b320c9fe_3a44299f","updated":"2023-04-10 20:19:45.000000000","message":"Done","commit_id":"ec74f01e4ecb54a25833eab0dfbdf0954543c3e7"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e3f8536c153c01fa2067f1c824b9dc1bb686b4b4","unresolved":true,"context_lines":[{"line_number":205,"context_line":"{"},{"line_number":206,"context_line":"\tstruct scan_field field;"},{"line_number":207,"context_line":"\tuint8_t ov[4];"},{"line_number":208,"context_line":"\tfield.num_bits \u003d tap-\u003eir_length;"},{"line_number":209,"context_line":"\tbuf_set_u32(ov, 0, field.num_bits, new_instr);"},{"line_number":210,"context_line":"\tfield.out_value \u003d ov;"},{"line_number":211,"context_line":"\tfield.in_value \u003d NULL;"}],"source_content_type":"text/x-csrc","patch_set":16,"id":"f3f0c695_2a3e6ad0","line":208,"updated":"2023-04-11 20:43:23.000000000","message":"Unfortunately tap-\u003eir_length is set in the config file and \"someone\" can set it out of limit, causing illegal memory access.\nThe best would be to make this function returning error, but if you think it\u0027s too invasive, just print a LOG_ERROR().\nThen either go back to use calloc (and return on calloc fail), or in this version check if tap-\u003eir_lenght \u003e 8*sizeof(ov), and saturate field.num_bits to the max value 8*sizeof(ov).\n\nSame comment for gowin and cologne","commit_id":"0dfd71764c7341cc94e5dad00dcf90016bab4a7c"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"4e0018fa3afe060011cbe54f6cb94d24921164e3","unresolved":false,"context_lines":[{"line_number":205,"context_line":"{"},{"line_number":206,"context_line":"\tstruct scan_field field;"},{"line_number":207,"context_line":"\tuint8_t ov[4];"},{"line_number":208,"context_line":"\tfield.num_bits \u003d tap-\u003eir_length;"},{"line_number":209,"context_line":"\tbuf_set_u32(ov, 0, field.num_bits, new_instr);"},{"line_number":210,"context_line":"\tfield.out_value \u003d ov;"},{"line_number":211,"context_line":"\tfield.in_value \u003d NULL;"}],"source_content_type":"text/x-csrc","patch_set":16,"id":"70a2f1da_834b75f2","line":208,"in_reply_to":"1d763c06_27f4262b","updated":"2023-04-12 21:03:34.000000000","message":"Done","commit_id":"0dfd71764c7341cc94e5dad00dcf90016bab4a7c"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"4e0018fa3afe060011cbe54f6cb94d24921164e3","unresolved":false,"context_lines":[{"line_number":205,"context_line":"{"},{"line_number":206,"context_line":"\tstruct scan_field field;"},{"line_number":207,"context_line":"\tuint8_t ov[4];"},{"line_number":208,"context_line":"\tfield.num_bits \u003d tap-\u003eir_length;"},{"line_number":209,"context_line":"\tbuf_set_u32(ov, 0, field.num_bits, new_instr);"},{"line_number":210,"context_line":"\tfield.out_value \u003d ov;"},{"line_number":211,"context_line":"\tfield.in_value \u003d NULL;"}],"source_content_type":"text/x-csrc","patch_set":16,"id":"144d8b00_6044fe1c","line":208,"in_reply_to":"1d763c06_27f4262b","updated":"2023-04-12 21:03:34.000000000","message":"and for virtex2_set_instr() ? it already returns an error but is ignored in almost all calls..","commit_id":"0dfd71764c7341cc94e5dad00dcf90016bab4a7c"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"6bead5488602919e37f95962c643a339bbe44772","unresolved":true,"context_lines":[{"line_number":205,"context_line":"{"},{"line_number":206,"context_line":"\tstruct scan_field field;"},{"line_number":207,"context_line":"\tuint8_t ov[4];"},{"line_number":208,"context_line":"\tfield.num_bits \u003d tap-\u003eir_length;"},{"line_number":209,"context_line":"\tbuf_set_u32(ov, 0, field.num_bits, new_instr);"},{"line_number":210,"context_line":"\tfield.out_value \u003d ov;"},{"line_number":211,"context_line":"\tfield.in_value \u003d NULL;"}],"source_content_type":"text/x-csrc","patch_set":16,"id":"1d763c06_27f4262b","line":208,"in_reply_to":"f3f0c695_2a3e6ad0","updated":"2023-04-11 20:48:02.000000000","message":"and for lattice_set_instr() too","commit_id":"0dfd71764c7341cc94e5dad00dcf90016bab4a7c"}]}