)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"af8610d6d48b1c2ca1b5cb60da18f7441a498fc4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a9f7b573_bfed6080","updated":"2022-11-17 16:11:13.000000000","message":"Please review when time permits.  Adds support for Xtensa NX architecture.","commit_id":"558d8abda2eb1f94504108005533cde357594e34"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"ca5644a4308d8d0ad42a662c0e4a247b3642a9bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"26eb7f0e_ee36f4f2","updated":"2023-01-18 14:37:00.000000000","message":"@antonio congrats on tagging v0.12!  Great to see it. \n\nCould you and @erhan please review this patch once you have some free bandwidth again?  Thanks in advance.","commit_id":"773d3a0d6136df723bcf65a8fe216b62dec91a6f"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"e69a8bd2ffeb228db8a6cb31b2bed8f062d3173d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5cd5b364_b57f2642","updated":"2023-01-31 00:34:36.000000000","message":"Sorry for the slow response, @anotonio.  Issues resolved.  Thanks as always for the feedback.","commit_id":"773d3a0d6136df723bcf65a8fe216b62dec91a6f"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"5f1c35db45cd73646eb3556cd251492c5a9439e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e92a8032_7735c206","updated":"2023-01-20 23:29:39.000000000","message":"Thanks for this patch, and congrats for v0.12.0 to you and all the contributors!","commit_id":"773d3a0d6136df723bcf65a8fe216b62dec91a6f"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"4f318265248f1d912e7c5b558ff033dc6589e6aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e2c9996d_d120ee33","in_reply_to":"26eb7f0e_ee36f4f2","updated":"2023-01-20 18:22:48.000000000","message":"I tested the changes. Nothing is broken on our side. Thanks, @Ian","commit_id":"773d3a0d6136df723bcf65a8fe216b62dec91a6f"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"651703e0b5298645fe5633df4431823cfe411f8f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"60a27bbd_e76ea77a","updated":"2023-03-02 14:54:15.000000000","message":"@antonio any chance you\u0027ll have some bandwidth to review again soon?  Thanks.","commit_id":"65bdcf2583757d768e006769f8fc3eee89461419"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"263f065d47028bd2c4a255cdc012c913712bf037","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bfddffc7_91e8e0a0","updated":"2023-02-13 14:43:54.000000000","message":"Hi @antonio, does this patch address all of your concerns?  We have customers excited to use this patch, as well as subsequent Xtensa NX patches waiting to be submitted.  Thanks in advance.\n\n@erhankur, thanks for the testing.  Anything else on your end for this one?","commit_id":"65bdcf2583757d768e006769f8fc3eee89461419"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"5b8c3001cf04cddedc855ebcbd364c103a19665f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"001eb45a_30ba355e","updated":"2023-03-04 10:33:22.000000000","message":"Thanks and sorry for taking so long time to review this","commit_id":"65bdcf2583757d768e006769f8fc3eee89461419"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"aa492bbf1f5596cc42079d71cf2127fa3dc5716d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a03760de_1ddb00cf","in_reply_to":"bfddffc7_91e8e0a0","updated":"2023-02-13 23:55:13.000000000","message":"Hi @Ian, Nothing expected from our side.","commit_id":"65bdcf2583757d768e006769f8fc3eee89461419"}],"src/target/xtensa/xtensa.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"5f1c35db45cd73646eb3556cd251492c5a9439e1","unresolved":true,"context_lines":[{"line_number":1043,"context_line":"\t} else {"},{"line_number":1044,"context_line":"\t\tuint32_t dsr \u003d xtensa_dm_core_status_get(\u0026xtensa-\u003edbg_mod);"},{"line_number":1045,"context_line":"\t\t/* NX causes are prioritized; only 1 bit can be set */"},{"line_number":1046,"context_line":"\t\tswitch ((dsr \u0026 OCDDSR_STOPCAUSE) \u003e\u003e OCDDSR_STOPCAUSE_SHIFT) {"},{"line_number":1047,"context_line":"\t\t\tcase OCDDSR_STOPCAUSE_DI:"},{"line_number":1048,"context_line":"\t\t\t\txtensa-\u003enx_stop_cause \u003d DEBUGCAUSE_DI;"},{"line_number":1049,"context_line":"\t\t\t\tbreak;"},{"line_number":1050,"context_line":"\t\t\tcase OCDDSR_STOPCAUSE_SS:"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"00f1dc8b_a364e750","line":1047,"range":{"start_line":1046,"start_character":1,"end_line":1047,"end_character":21},"updated":"2023-01-20 23:29:39.000000000","message":"per coding style, please align switch and case with the same indentation level","commit_id":"773d3a0d6136df723bcf65a8fe216b62dec91a6f"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"e69a8bd2ffeb228db8a6cb31b2bed8f062d3173d","unresolved":false,"context_lines":[{"line_number":1043,"context_line":"\t} else {"},{"line_number":1044,"context_line":"\t\tuint32_t dsr \u003d xtensa_dm_core_status_get(\u0026xtensa-\u003edbg_mod);"},{"line_number":1045,"context_line":"\t\t/* NX causes are prioritized; only 1 bit can be set */"},{"line_number":1046,"context_line":"\t\tswitch ((dsr \u0026 OCDDSR_STOPCAUSE) \u003e\u003e OCDDSR_STOPCAUSE_SHIFT) {"},{"line_number":1047,"context_line":"\t\t\tcase OCDDSR_STOPCAUSE_DI:"},{"line_number":1048,"context_line":"\t\t\t\txtensa-\u003enx_stop_cause \u003d DEBUGCAUSE_DI;"},{"line_number":1049,"context_line":"\t\t\t\tbreak;"},{"line_number":1050,"context_line":"\t\t\tcase OCDDSR_STOPCAUSE_SS:"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"c3d7b788_6ce418b9","line":1047,"range":{"start_line":1046,"start_character":1,"end_line":1047,"end_character":21},"in_reply_to":"00f1dc8b_a364e750","updated":"2023-01-31 00:34:36.000000000","message":"Done","commit_id":"773d3a0d6136df723bcf65a8fe216b62dec91a6f"}],"src/target/xtensa/xtensa.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"5f1c35db45cd73646eb3556cd251492c5a9439e1","unresolved":true,"context_lines":[{"line_number":194,"context_line":"\tXT_STEPPING_ISR_ON,\t\t/* interrupts are enabled during stepping */"},{"line_number":195,"context_line":"};"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"typedef enum xtensa_nx_reg_idx_e {"},{"line_number":198,"context_line":"\tXT_NX_REG_IDX_IBREAKC0 \u003d 0,"},{"line_number":199,"context_line":"\tXT_NX_REG_IDX_WB,"},{"line_number":200,"context_line":"\tXT_NX_REG_IDX_MS,"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"a651480c_71137f60","line":197,"updated":"2023-01-20 23:29:39.000000000","message":"can you please drop the typedef and use \"enum xtensa_nx_reg_idx\" ?","commit_id":"773d3a0d6136df723bcf65a8fe216b62dec91a6f"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"e69a8bd2ffeb228db8a6cb31b2bed8f062d3173d","unresolved":false,"context_lines":[{"line_number":194,"context_line":"\tXT_STEPPING_ISR_ON,\t\t/* interrupts are enabled during stepping */"},{"line_number":195,"context_line":"};"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"typedef enum xtensa_nx_reg_idx_e {"},{"line_number":198,"context_line":"\tXT_NX_REG_IDX_IBREAKC0 \u003d 0,"},{"line_number":199,"context_line":"\tXT_NX_REG_IDX_WB,"},{"line_number":200,"context_line":"\tXT_NX_REG_IDX_MS,"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"e80bb92a_0beef510","line":197,"in_reply_to":"a651480c_71137f60","updated":"2023-01-31 00:34:36.000000000","message":"Done","commit_id":"773d3a0d6136df723bcf65a8fe216b62dec91a6f"}]}