)]}'
{"id":"openocd~master~Ib70812600eaae0403b8ee8673b6f897348496569","project":"openocd","branch":"master","topic":"after 0.12 release","attention_set":{},"removed_from_attention_set":{"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2023-01-15 15:09:07.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ib70812600eaae0403b8ee8673b6f897348496569","subject":"jtag/drivers/cmsis_dap: improve USB packets filling","status":"MERGED","created":"2022-11-20 20:46:08.000000000","updated":"2023-01-15 15:09:07.000000000","submitted":"2023-01-15 15:09:07.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7364-after 0.12 release","meta_rev_id":"8ccd688f843e66ae9ca6a4b5f5fb53ff8ca63102","_number":7364,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-01-15 15:09:07.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-01-15 15:09:07.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-11-21 00:19:15.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-11-22 21:44:46.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"920cb6d82f89d300f188554b2dde3b0431da26c8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-11-20 20:46:08.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8012e1225bae79e0f5b30d3f74f8e806c9fb97c8","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-11-20 20:51:08.000000000","message":"Topic set to after 0.12 release","accounts_in_message":[],"_revision_number":1},{"id":"52d7d26eaafff203ed82ca854ad9847b38deb2e7","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-11-21 00:19:15.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16259/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17049/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"47673e65ce6b86668247bde1b4f40b1a8d4452bd","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-11-22 19:37:09.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"c0a890b70935d6dab25476763964f1a1086a6d09","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-11-22 21:42:18.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16273/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17063/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"0de1bf50483435655ffc8f2388114801c6f07ec6","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-11-22 21:44:46.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"1358783b05d4f375282b80dc7186412cf849267c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-11-22 21:57:45.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"0926901942d3e0b2cbcb0c16a94909cd3a9dc47f","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-11-23 02:25:42.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16279/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17071/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"9e8d0430793cd16f545244dec239799baa51a8e6","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-11-24 15:30:48.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"eab6332c5ffe20e3b8f92d6a2253a2278ff721df","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-01-15 14:36:56.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"8ccd688f843e66ae9ca6a4b5f5fb53ff8ca63102","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-01-15 15:09:07.000000000","message":"Change has been successfully cherry-picked as 40bac8e8c4e556faaf9c8adc1a030dbc52080fdb","accounts_in_message":[],"_revision_number":4}],"current_revision":"40bac8e8c4e556faaf9c8adc1a030dbc52080fdb","revisions":{"27e08f902becce01d45a24e23f447d529c667f31":{"kind":"REWORK","_number":2,"created":"2022-11-22 19:37:09.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/64/7364/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/64/7364/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/64/7364/2 \u0026\u0026 git checkout -b change-7364 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/64/7364/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/64/7364/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/64/7364/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/64/7364/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/64/7364/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ef03ba917b3a0c018ff24aa2d16c8330658d2b1a","subject":"jtag/drivers/cmsis_dap: introduce packet_usable_size"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-11-19 06:21:10.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-11-22 19:36:56.000000000","tz":60},"subject":"jtag/drivers/cmsis_dap: improve USB packets filling","message":"jtag/drivers/cmsis_dap: improve USB packets filling\n\nDAP write transaction occupies 5 bytes of a command packet.\nDAP read transaction needs just one byte in a command packet\nand expect 4 bytes in a response.\n\nThe fixed maximal number of transactions in a packet caused\npacket filling less than optimal.\n\nCompute both command and expected response sizes based on\nread or write direction of each transaction.\nRun the queue if one of sizes does not fit into a packet.\n\nThe change increases the speed of the mostly read transfer\nfrom 36 KiB/s to almost 40 KiB/s @ USB FS, adapter speed 1000\ndue to reduction of adapter inserted RDBUFF reads.\n\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nChange-Id: Ib70812600eaae0403b8ee8673b6f897348496569\n"}},"4c9218299e05d66d46107b1bf15fc17533fef350":{"kind":"REWORK","_number":3,"created":"2022-11-22 21:57:45.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/64/7364/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/64/7364/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/64/7364/3 \u0026\u0026 git checkout -b change-7364 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/64/7364/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/64/7364/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/64/7364/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/64/7364/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/64/7364/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e8b976b04131ba395347a55982fcf3b933af7fe6","subject":"jtag/drivers/cmsis_dap: introduce packet_usable_size"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-11-19 06:21:10.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-11-22 21:55:12.000000000","tz":60},"subject":"jtag/drivers/cmsis_dap: improve USB packets filling","message":"jtag/drivers/cmsis_dap: improve USB packets filling\n\nDAP write transaction occupies 5 bytes of a command packet.\nDAP read transaction needs just one byte in a command packet\nand expect 4 bytes in a response.\n\nThe fixed maximal number of transactions in a packet caused\npacket filling less than optimal.\n\nCompute both command and expected response sizes based on\nread or write direction of each transaction.\nRun the queue if one of sizes does not fit into a packet.\n\nThe change increases the speed of the mostly read transfer\nfrom 36 KiB/s to almost 40 KiB/s @ USB FS, adapter speed 1000\ndue to reduction of adapter inserted RDBUFF reads.\n\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nChange-Id: Ib70812600eaae0403b8ee8673b6f897348496569\n"}},"d4fa0e707596abdfe718b3a00e34f308b91fd375":{"kind":"REWORK","_number":1,"created":"2022-11-20 20:46:08.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/64/7364/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/64/7364/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/64/7364/1 \u0026\u0026 git checkout -b change-7364 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/64/7364/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/64/7364/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/64/7364/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/64/7364/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/64/7364/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"56fd6360a233f842c0492d8544714a135f250260","subject":"jtag/drivers/cmsis_dap: introduce packet_usable_size"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-11-19 06:21:10.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-11-20 20:43:16.000000000","tz":60},"subject":"jtag/drivers/cmsis_dap: improve USB packets filling","message":"jtag/drivers/cmsis_dap: improve USB packets filling\n\nDAP write transaction occupies 5 bytes of a command packet.\nDAP read transaction needs just one byte in a command packet\nand expect 4 bytes in a response.\n\nThe fixed maximal number of transactions in a packet caused\npacket filling less than optimal.\n\nCompute both command and expected response sizes based on\nread or write direction of each transaction.\nRun the queue if one of sizes does not fit into a packet.\n\nThe change increases the speed of the mostly read transfer\nfrom 36 KiB/s to almost 40 KiB/s @ USB FS, adapter speed 1000\ndue to reduction of adapter inserted RDBUFF reads.\n\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nChange-Id: Ib70812600eaae0403b8ee8673b6f897348496569\n"}},"40bac8e8c4e556faaf9c8adc1a030dbc52080fdb":{"kind":"REWORK","_number":4,"created":"2023-01-15 15:09:07.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/64/7364/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/64/7364/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/64/7364/4 \u0026\u0026 git checkout -b change-7364 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/64/7364/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/64/7364/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/64/7364/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/64/7364/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/64/7364/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3d3d35c9b87243a14b37478f1120c4c8d0a6d0bb","subject":"jtag/drivers/cmsis_dap: introduce packet_usable_size"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-11-19 06:21:10.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-01-15 15:09:07.000000000","tz":0},"subject":"jtag/drivers/cmsis_dap: improve USB packets filling","message":"jtag/drivers/cmsis_dap: improve USB packets filling\n\nDAP write transaction occupies 5 bytes of a command packet.\nDAP read transaction needs just one byte in a command packet\nand expect 4 bytes in a response.\n\nThe fixed maximal number of transactions in a packet caused\npacket filling less than optimal.\n\nCompute both command and expected response sizes based on\nread or write direction of each transaction.\nRun the queue if one of sizes does not fit into a packet.\n\nThe change increases the speed of the mostly read transfer\nfrom 36 KiB/s to almost 40 KiB/s @ USB FS, adapter speed 1000\ndue to reduction of adapter inserted RDBUFF reads.\n\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nChange-Id: Ib70812600eaae0403b8ee8673b6f897348496569\nReviewed-on: https://review.openocd.org/c/openocd/+/7364\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}