)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2cefff538a06711f5692709ceaa0f2cda08a6dde","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5020662d_9c86151a","updated":"2022-11-24 15:51:56.000000000","message":"thanks!","commit_id":"2e391f23d50dfe3aeae38bc817967fba66ea318c"}],"src/jtag/drivers/cmsis_dap.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b1ddb21df08e4594f6834f8a6f40218d67334c7d","unresolved":true,"context_lines":[{"line_number":983,"context_line":"\tunsigned int write_count \u003d cmsis_dap_handle-\u003ewrite_count;"},{"line_number":984,"context_line":"\tunsigned int read_count \u003d cmsis_dap_handle-\u003eread_count;"},{"line_number":985,"context_line":"\tbool block_cmd;"},{"line_number":986,"context_line":"\tif (write_count + read_count)"},{"line_number":987,"context_line":"\t\tblock_cmd \u003d (cmd \u003d\u003d cmsis_dap_handle-\u003esame_dap_cmd);"},{"line_number":988,"context_line":"\telse"},{"line_number":989,"context_line":"\t\tblock_cmd \u003d true;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"c12aaacf_a579d6e4","line":986,"updated":"2022-11-22 22:10:59.000000000","message":"Maybe it\u0027s more readable if it\u0027s written as:\nif (write_count || read_count)","commit_id":"1d334c2cd52ff068d86dd64b5e67687f858c4f8a"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"c09069d97d127a2810e1b74c7521a87f4060c064","unresolved":false,"context_lines":[{"line_number":983,"context_line":"\tunsigned int write_count \u003d cmsis_dap_handle-\u003ewrite_count;"},{"line_number":984,"context_line":"\tunsigned int read_count \u003d cmsis_dap_handle-\u003eread_count;"},{"line_number":985,"context_line":"\tbool block_cmd;"},{"line_number":986,"context_line":"\tif (write_count + read_count)"},{"line_number":987,"context_line":"\t\tblock_cmd \u003d (cmd \u003d\u003d cmsis_dap_handle-\u003esame_dap_cmd);"},{"line_number":988,"context_line":"\telse"},{"line_number":989,"context_line":"\t\tblock_cmd \u003d true;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"92784735_4bfda1a9","line":986,"in_reply_to":"94ec49bd_fdd7c6b0","updated":"2022-11-23 07:51:16.000000000","message":"Done","commit_id":"1d334c2cd52ff068d86dd64b5e67687f858c4f8a"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"b1d83901422f886dba97fd59ba7ad3eb8fa965f8","unresolved":true,"context_lines":[{"line_number":983,"context_line":"\tunsigned int write_count \u003d cmsis_dap_handle-\u003ewrite_count;"},{"line_number":984,"context_line":"\tunsigned int read_count \u003d cmsis_dap_handle-\u003eread_count;"},{"line_number":985,"context_line":"\tbool block_cmd;"},{"line_number":986,"context_line":"\tif (write_count + read_count)"},{"line_number":987,"context_line":"\t\tblock_cmd \u003d (cmd \u003d\u003d cmsis_dap_handle-\u003esame_dap_cmd);"},{"line_number":988,"context_line":"\telse"},{"line_number":989,"context_line":"\t\tblock_cmd \u003d true;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"94ec49bd_fdd7c6b0","line":986,"in_reply_to":"c12aaacf_a579d6e4","updated":"2022-11-22 23:29:07.000000000","message":"I know that most common is logic or and will work here.\nBut in fact I\u0027m testing the (total) transfer_count, which equals \n write_count + read_count","commit_id":"1d334c2cd52ff068d86dd64b5e67687f858c4f8a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b1ddb21df08e4594f6834f8a6f40218d67334c7d","unresolved":true,"context_lines":[{"line_number":193,"context_line":"#define DAP_SWO_STATUS_CAPTURE_MASK          BIT(0)"},{"line_number":194,"context_line":"#define DAP_SWO_STATUS_STREAM_ERROR_MASK     BIT(6)"},{"line_number":195,"context_line":"#define DAP_SWO_STATUS_BUFFER_OVERRUN_MASK   BIT(7)"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"/* CMSIS-DAP Vendor Commands"},{"line_number":198,"context_line":" * None as yet... */"},{"line_number":199,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"a727120a_115df164","line":196,"updated":"2022-11-22 22:10:59.000000000","message":"... continue from cmsis_dap.h\nhere:\n/* Value not used by any CMD_DAP_xxx. Use a uint8_t value. */\n#define CMD_DAP_DIFFER UINT8_MAX\nor\n#define CMD_DAP_INVALID UINT8_MAX","commit_id":"88228e7722811d02fffc16718008835f5818d773"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"c09069d97d127a2810e1b74c7521a87f4060c064","unresolved":false,"context_lines":[{"line_number":193,"context_line":"#define DAP_SWO_STATUS_CAPTURE_MASK          BIT(0)"},{"line_number":194,"context_line":"#define DAP_SWO_STATUS_STREAM_ERROR_MASK     BIT(6)"},{"line_number":195,"context_line":"#define DAP_SWO_STATUS_BUFFER_OVERRUN_MASK   BIT(7)"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"/* CMSIS-DAP Vendor Commands"},{"line_number":198,"context_line":" * None as yet... */"},{"line_number":199,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"43afe415_0ad1d8a0","line":196,"in_reply_to":"a727120a_115df164","updated":"2022-11-23 07:51:16.000000000","message":"Done","commit_id":"88228e7722811d02fffc16718008835f5818d773"}],"src/jtag/drivers/cmsis_dap.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b1ddb21df08e4594f6834f8a6f40218d67334c7d","unresolved":true,"context_lines":[{"line_number":39,"context_line":"\tunsigned int write_count;"},{"line_number":40,"context_line":"\tunsigned int read_count;"},{"line_number":41,"context_line":"\tuint8_t same_dap_cmd;"},{"line_number":42,"context_line":"#define DAP_CMD_DIFFER UINT8_MAX"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"\t/* Pending requests are organized as a FIFO - circular buffer */"},{"line_number":45,"context_line":"\tstruct pending_request_block pending_fifo[MAX_PENDING_REQUESTS];"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"11d04789_9b3c05fc","line":42,"updated":"2022-11-22 22:10:59.000000000","message":"you use this special value to compare it with current CMD_DAP_xxx.\nThe list of CMD_DAP_xxx is in cmsis_dap.c\nI think this macro definition should be added there, at the end of the list of commands, and should be renamed and commented.\nI continue in cmsis_dap.c","commit_id":"88228e7722811d02fffc16718008835f5818d773"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"b1d83901422f886dba97fd59ba7ad3eb8fa965f8","unresolved":true,"context_lines":[{"line_number":39,"context_line":"\tunsigned int write_count;"},{"line_number":40,"context_line":"\tunsigned int read_count;"},{"line_number":41,"context_line":"\tuint8_t same_dap_cmd;"},{"line_number":42,"context_line":"#define DAP_CMD_DIFFER UINT8_MAX"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"\t/* Pending requests are organized as a FIFO - circular buffer */"},{"line_number":45,"context_line":"\tstruct pending_request_block pending_fifo[MAX_PENDING_REQUESTS];"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"8d9f22b1_58ba2491","line":42,"in_reply_to":"11d04789_9b3c05fc","updated":"2022-11-22 23:29:07.000000000","message":"There are too many DAPs, CMDs and a mess in my head...\nThis macro has nothing common with CMSIS-DAP adapter protocol commands CMD_DAP_xxx.\nThis is a non-reachable value of cmsis_dap_swd_queue_cmd() cmd parameter,\naka result of swd_cmd().\n\u0027DAP\u0027 in the macro and \u0027dap\u0027 in variable is really misleading.\nWould be SWD_CMD_DIFFER / same_swd_cmd or repeated_swd_cmd sufficient?\nThe cleanest would be not to rely on any unreachable value and use\n uint8_t last_swd_cmd;\n bool swd_cmds_differ;\n\nIt\u0027s late now I\u0027ll solve it tomorrow...","commit_id":"88228e7722811d02fffc16718008835f5818d773"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"c09069d97d127a2810e1b74c7521a87f4060c064","unresolved":false,"context_lines":[{"line_number":39,"context_line":"\tunsigned int write_count;"},{"line_number":40,"context_line":"\tunsigned int read_count;"},{"line_number":41,"context_line":"\tuint8_t same_dap_cmd;"},{"line_number":42,"context_line":"#define DAP_CMD_DIFFER UINT8_MAX"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"\t/* Pending requests are organized as a FIFO - circular buffer */"},{"line_number":45,"context_line":"\tstruct pending_request_block pending_fifo[MAX_PENDING_REQUESTS];"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"d0390a54_894d100e","line":42,"in_reply_to":"8d9f22b1_58ba2491","updated":"2022-11-23 07:51:16.000000000","message":"Done","commit_id":"88228e7722811d02fffc16718008835f5818d773"}]}