)]}'
{"id":"openocd~master~Ifde0159cfd44481d2b81b90daa088e731c03e26d","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-11-24 15:51:56.000000000","reason":"Antonio Borneo replied on the change"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2023-01-15 15:09:47.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ifde0159cfd44481d2b81b90daa088e731c03e26d","subject":"jtag/drivers/cmsis_dap: speed up long transfers using DAP_TransferBlock","status":"MERGED","created":"2022-11-22 19:37:09.000000000","updated":"2023-01-15 15:09:47.000000000","submitted":"2023-01-15 15:09:47.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":9,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7372","meta_rev_id":"6f80a2ea978324915a9e4d0becc1dbb1957c95c2","_number":7372,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-01-15 15:09:47.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-01-15 15:09:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-11-22 21:58:22.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2022-11-22 22:10:59.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2022-11-23 03:14:48.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-11-24 15:51:56.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"b17ef1d6db1a320bcfb7294725ef9f624e540997","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-11-22 19:37:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0971e709b81d9074ab09908c56ce17a2cff265c2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-11-22 21:57:45.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"cd794732c1ecf92d6c2832c298aa670f86a150d6","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-11-22 21:58:22.000000000","message":"Patch Set 1:\n\nNo Builds Executed","accounts_in_message":[],"_revision_number":1},{"id":"b1ddb21df08e4594f6834f8a6f40218d67334c7d","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-11-22 22:10:59.000000000","message":"Patch Set 2:\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"b1d83901422f886dba97fd59ba7ad3eb8fa965f8","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-11-22 23:29:07.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"b51dac0a3dd0fe16db101d6419cfc57e252db92e","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-11-23 03:14:48.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16280/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17073/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"347f8b55978df543813b8b0bbf4e810916220efe","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-11-23 07:48:18.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"c09069d97d127a2810e1b74c7521a87f4060c064","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-11-23 07:51:16.000000000","message":"Patch Set 3:\n\n(3 comments)","accounts_in_message":[],"_revision_number":3},{"id":"d5d7b2bf7202d183000427c871a761d36fb005fe","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-11-23 08:31:54.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16285/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17077/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"2cefff538a06711f5692709ceaa0f2cda08a6dde","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-11-24 15:51:56.000000000","message":"Patch Set 3: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"80708f66976f0cb5c652e4c03897ed3c59ce290b","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-01-15 14:37:10.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"6f80a2ea978324915a9e4d0becc1dbb1957c95c2","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-01-15 15:09:47.000000000","message":"Change has been successfully cherry-picked as 630cb5ea4d65edba42d1c77fa17d9fe78f7b38c2","accounts_in_message":[],"_revision_number":4}],"current_revision":"630cb5ea4d65edba42d1c77fa17d9fe78f7b38c2","revisions":{"630cb5ea4d65edba42d1c77fa17d9fe78f7b38c2":{"kind":"REWORK","_number":4,"created":"2023-01-15 15:09:47.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/72/7372/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/72/7372/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/72/7372/4 \u0026\u0026 git checkout -b change-7372 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/72/7372/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/72/7372/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/72/7372/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/72/7372/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/72/7372/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"40bac8e8c4e556faaf9c8adc1a030dbc52080fdb","subject":"jtag/drivers/cmsis_dap: improve USB packets filling"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-11-22 11:29:52.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-01-15 15:09:47.000000000","tz":0},"subject":"jtag/drivers/cmsis_dap: speed up long transfers using DAP_TransferBlock","message":"jtag/drivers/cmsis_dap: speed up long transfers using DAP_TransferBlock\n\nDAP_TransferBlock command saves n - 3 bytes in comparison to DAP_Transfer,\nwhere n is number of transfers.\n\nUse DAP_TransferBlock optionaly to save some USB bandwidth.\n\nThe change increases the speed of the write transfer\nfrom 40 KiB/s to 42 KiB/s @ USB FS, adapter speed 1000.\n\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nChange-Id: Ifde0159cfd44481d2b81b90daa088e731c03e26d\nReviewed-on: https://review.openocd.org/c/openocd/+/7372\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"1d334c2cd52ff068d86dd64b5e67687f858c4f8a":{"kind":"REWORK","_number":1,"created":"2022-11-22 19:37:09.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/72/7372/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/72/7372/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/72/7372/1 \u0026\u0026 git checkout -b change-7372 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/72/7372/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/72/7372/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/72/7372/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/72/7372/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/72/7372/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"27e08f902becce01d45a24e23f447d529c667f31","subject":"jtag/drivers/cmsis_dap: improve USB packets filling"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-11-22 11:29:52.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-11-22 19:36:56.000000000","tz":60},"subject":"jtag/drivers/cmsis_dap: speed up long transfers using DAP_TransferBlock","message":"jtag/drivers/cmsis_dap: speed up long transfers using DAP_TransferBlock\n\nDAP_TransferBlock command saves n - 3 bytes in comparison to DAP_Transfer,\nwhere n is number of transfers.\n\nUse DAP_TransferBlock optionaly to save some USB bandwidth.\n\nThe change increases the speed of the write transfer\nfrom 40 KiB/s to 42 KiB/s @ USB FS, adapter speed 1000.\n\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nChange-Id: Ifde0159cfd44481d2b81b90daa088e731c03e26d\n"}},"88228e7722811d02fffc16718008835f5818d773":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2022-11-22 21:57:45.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/72/7372/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/72/7372/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/72/7372/2 \u0026\u0026 git checkout -b change-7372 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/72/7372/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/72/7372/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/72/7372/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/72/7372/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/72/7372/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4c9218299e05d66d46107b1bf15fc17533fef350","subject":"jtag/drivers/cmsis_dap: improve USB packets filling"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-11-22 11:29:52.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-11-22 21:55:16.000000000","tz":60},"subject":"jtag/drivers/cmsis_dap: speed up long transfers using DAP_TransferBlock","message":"jtag/drivers/cmsis_dap: speed up long transfers using DAP_TransferBlock\n\nDAP_TransferBlock command saves n - 3 bytes in comparison to DAP_Transfer,\nwhere n is number of transfers.\n\nUse DAP_TransferBlock optionaly to save some USB bandwidth.\n\nThe change increases the speed of the write transfer\nfrom 40 KiB/s to 42 KiB/s @ USB FS, adapter speed 1000.\n\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nChange-Id: Ifde0159cfd44481d2b81b90daa088e731c03e26d\n"}},"2e391f23d50dfe3aeae38bc817967fba66ea318c":{"kind":"REWORK","_number":3,"created":"2022-11-23 07:48:18.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/72/7372/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/72/7372/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/72/7372/3 \u0026\u0026 git checkout -b change-7372 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/72/7372/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/72/7372/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/72/7372/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/72/7372/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/72/7372/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4c9218299e05d66d46107b1bf15fc17533fef350","subject":"jtag/drivers/cmsis_dap: improve USB packets filling"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-11-22 11:29:52.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-11-23 07:33:30.000000000","tz":60},"subject":"jtag/drivers/cmsis_dap: speed up long transfers using DAP_TransferBlock","message":"jtag/drivers/cmsis_dap: speed up long transfers using DAP_TransferBlock\n\nDAP_TransferBlock command saves n - 3 bytes in comparison to DAP_Transfer,\nwhere n is number of transfers.\n\nUse DAP_TransferBlock optionaly to save some USB bandwidth.\n\nThe change increases the speed of the write transfer\nfrom 40 KiB/s to 42 KiB/s @ USB FS, adapter speed 1000.\n\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nChange-Id: Ifde0159cfd44481d2b81b90daa088e731c03e26d\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}