)]}'
{"id":"openocd~master~I11588dee748a55d52aa7f35bc1967b7df55af7fc","project":"openocd","branch":"master","hashtags":[],"change_id":"I11588dee748a55d52aa7f35bc1967b7df55af7fc","subject":"flash: lpc2900: fix clang error \u0027dead assignment\u0027","status":"MERGED","created":"2022-11-24 16:56:58.000000000","updated":"2022-12-03 09:24:59.000000000","submitted":"2022-12-03 09:24:59.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7379","meta_rev_id":"00f5c23ce9e5615a17120243c1f948f1556b85da","_number":7379,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-12-03 09:24:59.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-12-03 09:24:59.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-11-24 18:44:08.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"8a8c82b78feb586d6e32c15745cfe1f69a8be612","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-11-24 16:56:58.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"18516923275fb3cb109c1b205668bfd5f8a76109","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-11-24 18:44:08.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16297/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17091/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"29177a18bf5e5e34bd2af29d0f71d29437d00604","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-11-24 21:50:54.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"7036134d92af8542ece887c49deb1aa7bc5e8abd","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-03 09:24:52.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"00f5c23ce9e5615a17120243c1f948f1556b85da","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-03 09:24:59.000000000","message":"Change has been successfully cherry-picked as 0f034868f2c90741e57c5e27121e292b1774c080","accounts_in_message":[],"_revision_number":2}],"current_revision":"0f034868f2c90741e57c5e27121e292b1774c080","revisions":{"0f034868f2c90741e57c5e27121e292b1774c080":{"kind":"REWORK","_number":2,"created":"2022-12-03 09:24:59.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/79/7379/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/79/7379/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/79/7379/2 \u0026\u0026 git checkout -b change-7379 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/79/7379/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/79/7379/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/79/7379/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/79/7379/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/79/7379/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6ea1ccf3e6dd84c600c4ae9fb70347872634ded4","subject":"flash/nor/stm32lx: Add revision \u00271, X\u0027 for Cat.2 devices"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-11-16 00:02:02.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-03 09:24:59.000000000","tz":0},"subject":"flash: lpc2900: fix clang error \u0027dead assignment\u0027","message":"flash: lpc2900: fix clang error \u0027dead assignment\u0027\n\nThe variable retval is assigned a value that is never used.\nScan-build reports:\n\tAlthough the value stored to \u0027retval\u0027 is used in the\n\tenclosing expression, the value is never actually read\n\tfrom \u0027retval\u0027.\n\nDrop the dead assignment.\n\nChange-Id: I11588dee748a55d52aa7f35bc1967b7df55af7fc\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7379\nTested-by: jenkins\n"}},"9a93b950f0837bd1050bc55c19731bd9fe295ef9":{"kind":"REWORK","_number":1,"created":"2022-11-24 16:56:58.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/79/7379/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/79/7379/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/79/7379/1 \u0026\u0026 git checkout -b change-7379 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/79/7379/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/79/7379/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/79/7379/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/79/7379/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/79/7379/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9d925776b4504f71306b16467c1b731e57b6e7d0","subject":"target/armv7m: fix feature name of ARMv8M security extension regs"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-11-16 00:02:02.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-11-16 00:04:28.000000000","tz":60},"subject":"flash: lpc2900: fix clang error \u0027dead assignment\u0027","message":"flash: lpc2900: fix clang error \u0027dead assignment\u0027\n\nThe variable retval is assigned a value that is never used.\nScan-build reports:\n\tAlthough the value stored to \u0027retval\u0027 is used in the\n\tenclosing expression, the value is never actually read\n\tfrom \u0027retval\u0027.\n\nDrop the dead assignment.\n\nChange-Id: I11588dee748a55d52aa7f35bc1967b7df55af7fc\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}