)]}'
{"id":"openocd~master~I7687c055ec71424b642e152f478723a930966e3a","project":"openocd","branch":"master","hashtags":[],"change_id":"I7687c055ec71424b642e152f478723a930966e3a","subject":"jtag: xds110: fix clang error core.StackAddressEscape","status":"MERGED","created":"2022-11-24 16:56:58.000000000","updated":"2022-12-03 09:25:27.000000000","submitted":"2022-12-03 09:25:27.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7380","meta_rev_id":"7c67e3277ec543d9090d4155183808b8b4e2f160","_number":7380,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-12-03 09:25:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-12-03 09:25:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-11-24 17:51:20.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"4b3c798c2ec9d5abe2d1f36c31950f3672d1e8eb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-11-24 16:56:58.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7b31e6cabb9ffe0c65f7f7926c506d083c5537a8","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-11-24 17:51:20.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16296/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17090/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"b92006d992607b770dcce87edba5ab6b4d1aeb0c","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-11-24 21:50:39.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"8f530118be8a8ff4242c6929aeb7026e6557738b","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-03 09:25:21.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"7c67e3277ec543d9090d4155183808b8b4e2f160","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-03 09:25:27.000000000","message":"Change has been successfully cherry-picked as 3ea1bfce4faf656d0506c194084807f1e498abff","accounts_in_message":[],"_revision_number":2}],"current_revision":"3ea1bfce4faf656d0506c194084807f1e498abff","revisions":{"3ea1bfce4faf656d0506c194084807f1e498abff":{"kind":"REWORK","_number":2,"created":"2022-12-03 09:25:27.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/80/7380/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/80/7380/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/80/7380/2 \u0026\u0026 git checkout -b change-7380 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/80/7380/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/80/7380/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/80/7380/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/80/7380/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/80/7380/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0f034868f2c90741e57c5e27121e292b1774c080","subject":"flash: lpc2900: fix clang error \u0027dead assignment\u0027"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-11-16 22:06:12.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-03 09:25:27.000000000","tz":0},"subject":"jtag: xds110: fix clang error core.StackAddressEscape","message":"jtag: xds110: fix clang error core.StackAddressEscape\n\nClang ignores that xds110_swd_write_reg() is always called with\nbit SWD_CMD_RNW in \u0027cmd\u0027 set to zero.\nIt then complains that the local variable \u0027value\u0027 gets passed by\naddress to xds110_swd_queue_cmd() and in case of \u0027read request\u0027\nsuch stack address get stored for later use:\n\tsrc/jtag/drivers/xds110.c:1363:1: warning: Address of\n\t stack memory associated with local variable \u0027value\u0027 is\n\t still referred to by the global variable \u0027xds110\u0027 upon\n\t returning to the caller. This will be a dangling\n\t reference [core.StackAddressEscape]\n\nTo both xds110_swd_write_reg() and xds110_swd_read_reg(), add an\nassert() to inform Clang about the state of bit SWD_CMD_RNW.\n\nChange-Id: I7687c055ec71424b642e152f478723a930966e3a\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7380\nTested-by: jenkins\n"}},"0a7fc1d03eb0640495e3b4975139f894389c96b9":{"kind":"REWORK","_number":1,"created":"2022-11-24 16:56:58.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/80/7380/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/80/7380/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/80/7380/1 \u0026\u0026 git checkout -b change-7380 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/80/7380/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/80/7380/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/80/7380/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/80/7380/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/80/7380/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9a93b950f0837bd1050bc55c19731bd9fe295ef9","subject":"flash: lpc2900: fix clang error \u0027dead assignment\u0027"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-11-16 22:06:12.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-11-24 16:56:08.000000000","tz":60},"subject":"jtag: xds110: fix clang error core.StackAddressEscape","message":"jtag: xds110: fix clang error core.StackAddressEscape\n\nClang ignores that xds110_swd_write_reg() is always called with\nbit SWD_CMD_RNW in \u0027cmd\u0027 set to zero.\nIt then complains that the local variable \u0027value\u0027 gets passed by\naddress to xds110_swd_queue_cmd() and in case of \u0027read request\u0027\nsuch stack address get stored for later use:\n\tsrc/jtag/drivers/xds110.c:1363:1: warning: Address of\n\t stack memory associated with local variable \u0027value\u0027 is\n\t still referred to by the global variable \u0027xds110\u0027 upon\n\t returning to the caller. This will be a dangling\n\t reference [core.StackAddressEscape]\n\nTo both xds110_swd_write_reg() and xds110_swd_read_reg(), add an\nassert() to inform Clang about the state of bit SWD_CMD_RNW.\n\nChange-Id: I7687c055ec71424b642e152f478723a930966e3a\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}