)]}'
{"id":"openocd~master~Ide52a217f2228e9da2f1cc5036c48f3536f26952","project":"openocd","branch":"master","topic":"after 0.12 release","hashtags":[],"change_id":"Ide52a217f2228e9da2f1cc5036c48f3536f26952","subject":"nds32: drop it, together with aice adapter driver","status":"MERGED","created":"2022-11-24 22:24:04.000000000","updated":"2023-01-15 14:46:36.000000000","submitted":"2023-01-15 14:46:36.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7382-after 0.12 release","meta_rev_id":"f3c6edeb5e8bdc2893da73b1b4b229b25ca4d8ab","_number":7382,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-01-15 14:46:36.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-01-15 14:46:36.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-11-24 23:24:39.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"9231ecc480263965c5ab1d5c0eb896efb7a92287","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-11-24 22:24:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"393a2ba7dc717802b66d8913bfadaa0e6fd0f01f","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-11-24 22:30:00.000000000","message":"Topic set to after 0.12 release","accounts_in_message":[],"_revision_number":1},{"id":"27a626ea6836aa7f3a62fa14a2193e168676574b","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-11-24 22:30:13.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"756c977a35730feeadfb33e41278bd692412ca7e","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-11-24 23:24:39.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16302/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17096/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"368b0d9ff87279e6c319897eb13d887b589ebaaa","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-01-15 13:20:20.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"f3c6edeb5e8bdc2893da73b1b4b229b25ca4d8ab","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-01-15 14:46:36.000000000","message":"Change has been successfully cherry-picked as da34e36cdb542eac9370957b10853184f870e495","accounts_in_message":[],"_revision_number":2}],"current_revision":"da34e36cdb542eac9370957b10853184f870e495","revisions":{"da34e36cdb542eac9370957b10853184f870e495":{"kind":"REWORK","_number":2,"created":"2023-01-15 14:46:36.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/82/7382/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/82/7382/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/82/7382/2 \u0026\u0026 git checkout -b change-7382 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/82/7382/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/82/7382/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/82/7382/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/82/7382/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/82/7382/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8bb926eb01022998ceefe666f8df102e59404015","subject":"Deprecate libjaylink Git submodule"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-19 21:14:41.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-01-15 14:46:36.000000000","tz":0},"subject":"nds32: drop it, together with aice adapter driver","message":"nds32: drop it, together with aice adapter driver\n\nThe target nds32 and its companion adapter aice have not received\nany real improvement since 2013.\nIt has been hard to keep them aligned during the evolution of\nOpenOCD code, with no way for maintainers to really check if they\nare still working.\nNo real documentation is present for them in OpenOCD.\nThe nds32 code triggers ~50 errors/warnings with scan-build.\n\nThe arch nds32 has been dropped from Linux kernel v5.18-rc1.\n\nFor all the reasons above, this code has been deprecated with\ncommit 2e5df83de7f2 (\"nds32: deprecate it, together with aice\nadapter driver\") and tagged to be dropped before v0.13.0.\n\nLet it r.i.p. in OpenOCD git history.\n\nWhile there, drop from checkpatch list the camelcase symbols that\nwhere only used in this code.\n\nChange-Id: Ide52a217f2228e9da2f1cc5036c48f3536f26952\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7382\nTested-by: jenkins\n"}},"68652238d8e8114984929fbe9fa28b4a5fe38b47":{"kind":"REWORK","_number":1,"created":"2022-11-24 22:24:04.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/82/7382/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/82/7382/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/82/7382/1 \u0026\u0026 git checkout -b change-7382 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/82/7382/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/82/7382/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/82/7382/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/82/7382/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/82/7382/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9d925776b4504f71306b16467c1b731e57b6e7d0","subject":"target/armv7m: fix feature name of ARMv8M security extension regs"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-09-19 21:14:41.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-11-24 22:21:18.000000000","tz":60},"subject":"nds32: drop it, together with aice adapter driver","message":"nds32: drop it, together with aice adapter driver\n\nThe target nds32 and its companion adapter aice have not received\nany real improvement since 2013.\nIt has been hard to keep them aligned during the evolution of\nOpenOCD code, with no way for maintainers to really check if they\nare still working.\nNo real documentation is present for them in OpenOCD.\nThe nds32 code triggers ~50 errors/warnings with scan-build.\n\nThe arch nds32 has been dropped from Linux kernel v5.18-rc1.\n\nFor all the reasons above, this code has been deprecated with\ncommit 2e5df83de7f2 (\"nds32: deprecate it, together with aice\nadapter driver\") and tagged to be dropped before v0.13.0.\n\nLet it r.i.p. in OpenOCD git history.\n\nWhile there, drop from checkpatch list the camelcase symbols that\nwhere only used in this code.\n\nChange-Id: Ide52a217f2228e9da2f1cc5036c48f3536f26952\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}