)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"65d37b3922106b3bfec9d8b211c6708ffb029746","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f3089dbf_d9ff877a","updated":"2022-11-28 22:19:10.000000000","message":"Apart from a concern on assert(), the patch looks correct","commit_id":"ba55278834ca34ee1f1a958a2995604c637a9022"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"5df36e3fc67d3c49aedb7efe3821fc82978cc6d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a109d756_331719f4","updated":"2022-11-28 22:15:32.000000000","message":"Tomas, hat target do you use to test / develop SWD multidrop?","commit_id":"ba55278834ca34ee1f1a958a2995604c637a9022"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"1b4f63b295efd2cdc08f70f277d313edb1b242af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"74412444_f9ccbbe4","in_reply_to":"a109d756_331719f4","updated":"2023-01-19 20:34:12.000000000","message":"Marc,\nthe most comfortable is RP2040 (RPi pico) - it integrates 2 CPUs in SWD multidrop configuration.\nThe other setup I used was two STM32H7 or L5/U5 with different device ID numbers\n(e.g. STM32H745 and STM32H7A3).\nThere are some other multidrop capable chips (NRF53..)","commit_id":"ba55278834ca34ee1f1a958a2995604c637a9022"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"42890212da8ca749cf131fd55ce4937bc880606a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"916054b0_e396c6cf","updated":"2023-01-21 16:42:28.000000000","message":"Ok for me, thanks.\nMarc?","commit_id":"0d27818954c02abc58b8b1223d53633d507c75a1"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"41c7fea84ba101fbb74c2e63e7f2cb527d4b473b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ec39b194_52552e11","updated":"2023-01-23 16:29:33.000000000","message":"Thanks!","commit_id":"0d27818954c02abc58b8b1223d53633d507c75a1"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"10e1aaccdd7452277feffdf3071c6dd11e595716","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6963b33b_a8d5bf48","in_reply_to":"916054b0_e396c6cf","updated":"2023-01-22 16:48:12.000000000","message":"I\u0027ll check for regression tomorrow, I have no device at hand right now.","commit_id":"0d27818954c02abc58b8b1223d53633d507c75a1"}],"src/jtag/drivers/jlink.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"65d37b3922106b3bfec9d8b211c6708ffb029746","unresolved":true,"context_lines":[{"line_number":2224,"context_line":"\tif (queued_retval !\u003d ERROR_OK)"},{"line_number":2225,"context_line":"\t\treturn;"},{"line_number":2226,"context_line":""},{"line_number":2227,"context_line":"\tassert(pending_scan_results_length \u003c MAX_PENDING_SCAN_RESULTS);"},{"line_number":2228,"context_line":"\tpending_scan_results_buffer[pending_scan_results_length].swd_cmd \u003d cmd;"},{"line_number":2229,"context_line":"\tcmd |\u003d SWD_CMD_START | SWD_CMD_PARK;"},{"line_number":2230,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"8de08e66_5109820d","line":2227,"updated":"2022-11-28 22:19:10.000000000","message":"the way \u0027pending_scan_results_length\u0027 is managed guarantees it never exceeds MAX_PENDING_SCAN_RESULTS, so the assert here is useless.\nMy concern about adding assert is that we have several broken cases of assert (instead of graceful error return) that crash OpenOCD. See ticket 370.\nThe more assert we add the more difficult to find the broken ones.\nIf there is no scan-build complain, I would prefer dropping this.","commit_id":"ba55278834ca34ee1f1a958a2995604c637a9022"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"05bd6a3c108cfff423df699d98c9da9b9ec6f6c8","unresolved":false,"context_lines":[{"line_number":2224,"context_line":"\tif (queued_retval !\u003d ERROR_OK)"},{"line_number":2225,"context_line":"\t\treturn;"},{"line_number":2226,"context_line":""},{"line_number":2227,"context_line":"\tassert(pending_scan_results_length \u003c MAX_PENDING_SCAN_RESULTS);"},{"line_number":2228,"context_line":"\tpending_scan_results_buffer[pending_scan_results_length].swd_cmd \u003d cmd;"},{"line_number":2229,"context_line":"\tcmd |\u003d SWD_CMD_START | SWD_CMD_PARK;"},{"line_number":2230,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"6a8b0e44_30f7cc50","line":2227,"in_reply_to":"8de08e66_5109820d","updated":"2023-01-19 20:20:42.000000000","message":"jlink_swd_run_queue() skips processing in the case of error\nso I was not sure if pending_scan_results_length gets always reset.\nOne has to examine one more nesting level, jlink_tap_init()\ndoes it. You\u0027re right this time, assert is useless.","commit_id":"ba55278834ca34ee1f1a958a2995604c637a9022"}]}