)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"4889bdf57196f5322bd45baf5b021dd75d7765fd","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Daniel Anselmi \u003cdanselmi@gmx.ch\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-03-31 11:23:04 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"add missing zynq id codes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Idd2d3a5eddb6995f3af1c45afd2adf76ce3442bf"},{"line_number":10,"context_line":"Signed-off-by: Daniel Anselmi \u003cdanselmi@gmx.ch\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"c8a73d1d_2557e6f4","line":7,"updated":"2023-04-04 16:33:22.000000000","message":"please try to be more detailed in the commit message and follow the description in the file HACKING. Here it should be something like:\n\n tcl: zynq_7000: add missing id codes\n \n Add missing ID codes and ignore the the version in the ID.\n \n Change-Id: ...\n Signed-off-by: ...","commit_id":"7177319b4ea61300a59e4c66e519d41a1c2e58b9"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"6fb32009ebcdd4334bfbbdd27474821c19efc807","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Daniel Anselmi \u003cdanselmi@gmx.ch\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-03-31 11:23:04 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"add missing zynq id codes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Idd2d3a5eddb6995f3af1c45afd2adf76ce3442bf"},{"line_number":10,"context_line":"Signed-off-by: Daniel Anselmi \u003cdanselmi@gmx.ch\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"880661cd_a91ef3ce","line":7,"in_reply_to":"c8a73d1d_2557e6f4","updated":"2023-04-04 21:31:40.000000000","message":"Done","commit_id":"7177319b4ea61300a59e4c66e519d41a1c2e58b9"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"6fb32009ebcdd4334bfbbdd27474821c19efc807","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"73abfc25_884e1bb8","updated":"2023-04-04 21:31:40.000000000","message":"Thanks a lot for reviewing my patches!","commit_id":"7177319b4ea61300a59e4c66e519d41a1c2e58b9"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"379a3893960d495d37c08edaf16c9be5346e0e42","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"390ede19_cd55419b","updated":"2023-04-03 13:54:01.000000000","message":"Thanks!","commit_id":"7177319b4ea61300a59e4c66e519d41a1c2e58b9"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"4eacc11b9ecfeb8e62fa61a4914233e6ba14b76c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6c31f78d_ef489757","updated":"2023-04-04 22:02:48.000000000","message":"thanks!","commit_id":"6d359aa9003c224a85b99097f338182aa063c35b"}],"tcl/target/zynq_7000.cfg":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"7e3b47a78ab6d40619cb960e6eb1cbc9ecc04788","unresolved":true,"context_lines":[{"line_number":19,"context_line":"set _CHIPNAME zynq"},{"line_number":20,"context_line":"set _TARGETNAME $_CHIPNAME.cpu"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"jtag newtap zynq_pl bs -irlen 6-ignore-version -ircapture 0x1 -irmask 0x03 \\"},{"line_number":23,"context_line":"    -expected-id 0x03723093 \\"},{"line_number":24,"context_line":"    -expected-id 0x03722093 \\"},{"line_number":25,"context_line":"    -expected-id 0x0373c093 \\"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"238d9ada_e6e2b44f","line":22,"range":{"start_line":22,"start_character":30,"end_line":22,"end_character":32},"updated":"2023-03-31 07:44:20.000000000","message":"missing space","commit_id":"a719ea431a78f80730db13da16b9f98b1f120555"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"23817a58079d14a662b63aeb92759b530513f8ef","unresolved":false,"context_lines":[{"line_number":19,"context_line":"set _CHIPNAME zynq"},{"line_number":20,"context_line":"set _TARGETNAME $_CHIPNAME.cpu"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"jtag newtap zynq_pl bs -irlen 6-ignore-version -ircapture 0x1 -irmask 0x03 \\"},{"line_number":23,"context_line":"    -expected-id 0x03723093 \\"},{"line_number":24,"context_line":"    -expected-id 0x03722093 \\"},{"line_number":25,"context_line":"    -expected-id 0x0373c093 \\"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"0af19ed9_e5869ee4","line":22,"range":{"start_line":22,"start_character":30,"end_line":22,"end_character":32},"in_reply_to":"238d9ada_e6e2b44f","updated":"2023-03-31 09:25:36.000000000","message":"Done","commit_id":"a719ea431a78f80730db13da16b9f98b1f120555"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"4889bdf57196f5322bd45baf5b021dd75d7765fd","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"jtag newtap zynq_pl bs -irlen 6 -ircapture 0x1 -irmask 0x03 \\"},{"line_number":13,"context_line":"    -expected-id 0x23727093 \\"},{"line_number":14,"context_line":"    -expected-id 0x13722093 \\"},{"line_number":15,"context_line":"    -expected-id 0x03727093 \\"},{"line_number":16,"context_line":"    -expected-id 0x03736093"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"daac62bb_169c9355","side":"PARENT","line":14,"updated":"2023-04-04 16:33:22.000000000","message":"what about these old IDs? Did they get obsoleted from Xilinx?\nOne was added in http://review.openocd.org/2729 with comment \"found on the Parallella-I board SKU A101020\"\nThe other was in the original commit http://review.openocd.org/2061","commit_id":"9901dca07a3e4292eed91298d5a37d73bb1fb623"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"4eacc11b9ecfeb8e62fa61a4914233e6ba14b76c","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"jtag newtap zynq_pl bs -irlen 6 -ircapture 0x1 -irmask 0x03 \\"},{"line_number":13,"context_line":"    -expected-id 0x23727093 \\"},{"line_number":14,"context_line":"    -expected-id 0x13722093 \\"},{"line_number":15,"context_line":"    -expected-id 0x03727093 \\"},{"line_number":16,"context_line":"    -expected-id 0x03736093"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"75cdad20_0e0c9db2","side":"PARENT","line":14,"in_reply_to":"05339e6d_660a0531","updated":"2023-04-04 22:02:48.000000000","message":"Yes, right, it only concerns the bits 28-31","commit_id":"9901dca07a3e4292eed91298d5a37d73bb1fb623"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"031be03992b7e7ddc0a437d935b0ca1bb0dcc104","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"jtag newtap zynq_pl bs -irlen 6 -ircapture 0x1 -irmask 0x03 \\"},{"line_number":13,"context_line":"    -expected-id 0x23727093 \\"},{"line_number":14,"context_line":"    -expected-id 0x13722093 \\"},{"line_number":15,"context_line":"    -expected-id 0x03727093 \\"},{"line_number":16,"context_line":"    -expected-id 0x03736093"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"05339e6d_660a0531","side":"PARENT","line":14,"in_reply_to":"daac62bb_169c9355","updated":"2023-04-04 19:04:13.000000000","message":"\u003e what about these old IDs? Did they get obsoleted from Xilinx?\n\nSee description of -ignore-version in\nhttps://openocd.org/doc/html/TAP-Declaration.html\n\nI checked all IDs including not merged\n5253: target/zynq-7000: Add an additional TAP ID | https://review.openocd.org/c/openocd/+/5253","commit_id":"9901dca07a3e4292eed91298d5a37d73bb1fb623"}]}
