)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"1e59ddc9b0c43c678c478996b6d16ea5684a10bd","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"src/target/mips_m4k.c: set missing flag in set_watchpoint"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Id0d91cc02b7055e44d27507f9c05ccd48ff49838"},{"line_number":10,"context_line":"Signed-off-by: Nima Palizban \u003cn.palizban@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fde5c383_beeb404f","line":9,"updated":"2022-12-02 07:28:59.000000000","message":"Please add\n Fixes: fb43f1ff4e2f (target: Rework \u0027set\u0027 variable of break-/watchpoints)","commit_id":"13b2f4a88170713094897b47b44998f795b8f3c6"},{"author":{"_account_id":1002089,"name":"Nima Palizban","email":"n.palizban@gmail.com","username":"npalizban"},"change_message_id":"11c03c9b2cc37552f2dc414a14a00092aaaddcaa","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"src/target/mips_m4k.c: set missing flag in set_watchpoint"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Id0d91cc02b7055e44d27507f9c05ccd48ff49838"},{"line_number":10,"context_line":"Signed-off-by: Nima Palizban \u003cn.palizban@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"8ccc62dd_c1c010d0","line":9,"in_reply_to":"fde5c383_beeb404f","updated":"2022-12-02 15:00:53.000000000","message":"Done","commit_id":"13b2f4a88170713094897b47b44998f795b8f3c6"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"1e59ddc9b0c43c678c478996b6d16ea5684a10bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2dec6c7d_4fe0443b","updated":"2022-12-02 07:28:59.000000000","message":"Nima, thanks for reporting the issue!\n\nMarc, I rechecked the change\n6319: target: Rework \u0027set\u0027 variable of break-/watchpoints | https://review.openocd.org/c/openocd/+/6319\nwhich introduced the bug and did not see any other problem.","commit_id":"13b2f4a88170713094897b47b44998f795b8f3c6"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9ad4c87a6c728b36c8b93013201c94918c83ad62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"16c6b739_c87f4c7e","updated":"2022-12-03 09:27:49.000000000","message":"thanks!","commit_id":"eaa7eb4920b3ba70c06969c849305248834f144e"},{"author":{"_account_id":1002089,"name":"Nima Palizban","email":"n.palizban@gmail.com","username":"npalizban"},"change_message_id":"edb7d16c7fe746d2e0e631fff7103f93d07ea712","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ac192be0_3fa38712","in_reply_to":"16c6b739_c87f4c7e","updated":"2022-12-05 13:09:25.000000000","message":"Thanks for great support.\n\nIs there something else I need to do to proceed with merge?","commit_id":"eaa7eb4920b3ba70c06969c849305248834f144e"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"23b130ab5b519decc21be23b6edaf0e1a20249b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4fb160e0_cb1ccdd9","in_reply_to":"ac192be0_3fa38712","updated":"2022-12-05 15:11:10.000000000","message":"No. We\u0027ll wait couple of days if Marc has some comments and then approve and merge.","commit_id":"eaa7eb4920b3ba70c06969c849305248834f144e"}],"src/target/mips_m4k.c":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"1e59ddc9b0c43c678c478996b6d16ea5684a10bd","unresolved":true,"context_lines":[{"line_number":900,"context_line":"\t\t\tLOG_ERROR(\"BUG: watchpoint-\u003erw neither read, write nor access\");"},{"line_number":901,"context_line":"\t}"},{"line_number":902,"context_line":""},{"line_number":903,"context_line":"\twatchpoint-\u003enumber \u003d wp_num;"},{"line_number":904,"context_line":"\twatchpoint-\u003eis_set \u003d true;"},{"line_number":905,"context_line":"\tcomparator_list[wp_num].used \u003d 1;"},{"line_number":906,"context_line":"\tcomparator_list[wp_num].bp_value \u003d watchpoint-\u003eaddress;"},{"line_number":907,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"3fefba7f_14adebfb","line":904,"range":{"start_line":903,"start_character":1,"end_line":904,"end_character":27},"updated":"2022-12-02 07:28:59.000000000","message":"Please use inline function\n watchpoint_set(wp, wp_num);\n\ninstead of two marked lines.\nSee\nhttps://review.openocd.org/c/openocd/+/6319/10/src/target/breakpoints.h#90","commit_id":"13b2f4a88170713094897b47b44998f795b8f3c6"},{"author":{"_account_id":1002089,"name":"Nima Palizban","email":"n.palizban@gmail.com","username":"npalizban"},"change_message_id":"11c03c9b2cc37552f2dc414a14a00092aaaddcaa","unresolved":false,"context_lines":[{"line_number":900,"context_line":"\t\t\tLOG_ERROR(\"BUG: watchpoint-\u003erw neither read, write nor access\");"},{"line_number":901,"context_line":"\t}"},{"line_number":902,"context_line":""},{"line_number":903,"context_line":"\twatchpoint-\u003enumber \u003d wp_num;"},{"line_number":904,"context_line":"\twatchpoint-\u003eis_set \u003d true;"},{"line_number":905,"context_line":"\tcomparator_list[wp_num].used \u003d 1;"},{"line_number":906,"context_line":"\tcomparator_list[wp_num].bp_value \u003d watchpoint-\u003eaddress;"},{"line_number":907,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"46dae539_9b721b1e","line":904,"range":{"start_line":903,"start_character":1,"end_line":904,"end_character":27},"in_reply_to":"3fefba7f_14adebfb","updated":"2022-12-02 15:00:53.000000000","message":"Done","commit_id":"13b2f4a88170713094897b47b44998f795b8f3c6"}]}