)]}'
{"id":"openocd~master~Id0d91cc02b7055e44d27507f9c05ccd48ff49838","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000853":{"account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2022-12-17 09:29:32.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-12-17 09:27:39.000000000","reason":"removed on reply"},"1002089":{"account":{"_account_id":1002089,"name":"Nima Palizban","email":"n.palizban@gmail.com","username":"npalizban"},"last_update":"2022-12-17 09:29:32.000000000","reason":"Change was submitted"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2022-12-02 15:56:22.000000000","reason":"Tomas Vanek replied on the change"}},"hashtags":[],"change_id":"Id0d91cc02b7055e44d27507f9c05ccd48ff49838","subject":"src/target/mips_m4k.c: set missing flag in set_watchpoint","status":"MERGED","created":"2022-12-01 17:50:15.000000000","updated":"2022-12-17 09:29:32.000000000","submitted":"2022-12-17 09:29:32.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7389","meta_rev_id":"92853233f8c9c212e249c0f17b4794f0a0652e13","_number":7389,"owner":{"_account_id":1002089,"name":"Nima Palizban","email":"n.palizban@gmail.com","username":"npalizban"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-12-17 09:29:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-12-17 09:29:32.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-12-17 09:29:32.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-12-01 18:43:45.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-12-02 07:28:59.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"CC"},{"updated":"2022-12-02 07:28:59.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"state":"REVIEWER"},{"updated":"2022-12-02 15:56:22.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2022-12-03 09:27:49.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"b1a977fcba0da48c5a9126cf49864b6966dfc9a5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002089,"name":"Nima Palizban","email":"n.palizban@gmail.com","username":"npalizban"},"real_author":{"_account_id":1002089,"name":"Nima Palizban","email":"n.palizban@gmail.com","username":"npalizban"},"date":"2022-12-01 17:50:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a3874771c220d932c45e393435a3c024101aa8be","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-12-01 18:43:45.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16365/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17161/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"1e59ddc9b0c43c678c478996b6d16ea5684a10bd","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-12-02 07:28:59.000000000","message":"Patch Set 1:\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"01e3c3ddd63b4a1d7fdf27a3dfbdcdccb8177dd7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002089,"name":"Nima Palizban","email":"n.palizban@gmail.com","username":"npalizban"},"real_author":{"_account_id":1002089,"name":"Nima Palizban","email":"n.palizban@gmail.com","username":"npalizban"},"date":"2022-12-02 14:42:39.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"11c03c9b2cc37552f2dc414a14a00092aaaddcaa","author":{"_account_id":1002089,"name":"Nima Palizban","email":"n.palizban@gmail.com","username":"npalizban"},"real_author":{"_account_id":1002089,"name":"Nima Palizban","email":"n.palizban@gmail.com","username":"npalizban"},"date":"2022-12-02 15:00:53.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"ccd647dcfa7a37e8e08b5a35b77b950d741a3926","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-12-02 15:35:48.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16368/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17164/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"69e1abe59ad28415edd36611e17bfe2e5a037443","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-12-02 15:56:22.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"9ad4c87a6c728b36c8b93013201c94918c83ad62","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-03 09:27:49.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"edb7d16c7fe746d2e0e631fff7103f93d07ea712","author":{"_account_id":1002089,"name":"Nima Palizban","email":"n.palizban@gmail.com","username":"npalizban"},"real_author":{"_account_id":1002089,"name":"Nima Palizban","email":"n.palizban@gmail.com","username":"npalizban"},"date":"2022-12-05 13:09:25.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"23b130ab5b519decc21be23b6edaf0e1a20249b3","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-12-05 15:11:10.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"e071d46c7dd1326df799a6a649c30602837deaeb","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-17 09:27:39.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"92853233f8c9c212e249c0f17b4794f0a0652e13","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-17 09:29:32.000000000","message":"Change has been successfully cherry-picked as 2278878a05d8dfbbed3e59f0cfbeeb598af3129c","accounts_in_message":[],"_revision_number":3}],"current_revision":"2278878a05d8dfbbed3e59f0cfbeeb598af3129c","revisions":{"13b2f4a88170713094897b47b44998f795b8f3c6":{"kind":"REWORK","_number":1,"created":"2022-12-01 17:50:15.000000000","uploader":{"_account_id":1002089,"name":"Nima Palizban","email":"n.palizban@gmail.com","username":"npalizban"},"ref":"refs/changes/89/7389/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/89/7389/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/89/7389/1 \u0026\u0026 git checkout -b change-7389 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/89/7389/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/89/7389/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/89/7389/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/89/7389/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/89/7389/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6ea1ccf3e6dd84c600c4ae9fb70347872634ded4","subject":"flash/nor/stm32lx: Add revision \u00271, X\u0027 for Cat.2 devices"}],"author":{"name":"Nima Palizban","email":"n.palizban@gmail.com","date":"2022-12-01 17:41:30.000000000","tz":-300},"committer":{"name":"Nima Palizban","email":"n.palizban@gmail.com","date":"2022-12-01 17:43:05.000000000","tz":-300},"subject":"src/target/mips_m4k.c: set missing flag in set_watchpoint","message":"src/target/mips_m4k.c: set missing flag in set_watchpoint\n\nChange-Id: Id0d91cc02b7055e44d27507f9c05ccd48ff49838\nSigned-off-by: Nima Palizban \u003cn.palizban@gmail.com\u003e\n"}},"eaa7eb4920b3ba70c06969c849305248834f144e":{"kind":"REWORK","_number":2,"created":"2022-12-02 14:42:39.000000000","uploader":{"_account_id":1002089,"name":"Nima Palizban","email":"n.palizban@gmail.com","username":"npalizban"},"ref":"refs/changes/89/7389/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/89/7389/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/89/7389/2 \u0026\u0026 git checkout -b change-7389 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/89/7389/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/89/7389/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/89/7389/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/89/7389/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/89/7389/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6ea1ccf3e6dd84c600c4ae9fb70347872634ded4","subject":"flash/nor/stm32lx: Add revision \u00271, X\u0027 for Cat.2 devices"}],"author":{"name":"Nima Palizban","email":"n.palizban@gmail.com","date":"2022-12-01 17:41:30.000000000","tz":-300},"committer":{"name":"Nima Palizban","email":"n.palizban@gmail.com","date":"2022-12-02 14:32:02.000000000","tz":-300},"subject":"src/target/mips_m4k.c: set missing flag in set_watchpoint","message":"src/target/mips_m4k.c: set missing flag in set_watchpoint\n\nWithout the fix, will see \"Can not find free FP Comparator\" error log\n\nChange-Id: Id0d91cc02b7055e44d27507f9c05ccd48ff49838\nSigned-off-by: Nima Palizban \u003cn.palizban@gmail.com\u003e\nFixes: fb43f1ff4e2f (target: Rework \u0027set\u0027 variable of break-/watchpoints)\n"}},"2278878a05d8dfbbed3e59f0cfbeeb598af3129c":{"kind":"REWORK","_number":3,"created":"2022-12-17 09:29:32.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/89/7389/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/89/7389/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/89/7389/3 \u0026\u0026 git checkout -b change-7389 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/89/7389/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/89/7389/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/89/7389/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/89/7389/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/89/7389/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9501b263e0ae127b012f5c5e3ba5dffcc7daa8d1","subject":"doc: describe tcl port consistently."}],"author":{"name":"Nima Palizban","email":"n.palizban@gmail.com","date":"2022-12-01 17:41:30.000000000","tz":-300},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-17 09:29:32.000000000","tz":0},"subject":"src/target/mips_m4k.c: set missing flag in set_watchpoint","message":"src/target/mips_m4k.c: set missing flag in set_watchpoint\n\nWithout the fix, will see \"Can not find free FP Comparator\" error log\n\nChange-Id: Id0d91cc02b7055e44d27507f9c05ccd48ff49838\nSigned-off-by: Nima Palizban \u003cn.palizban@gmail.com\u003e\nFixes: fb43f1ff4e2f (target: Rework \u0027set\u0027 variable of break-/watchpoints)\nReviewed-on: https://review.openocd.org/c/openocd/+/7389\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}