)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"8d4eca055b032a6e3741dbe941955f7c06fb93e2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3aebb0d3_36e0cc38","line":19,"updated":"2022-12-15 09:01:59.000000000","message":"not mandatory, but if you send a new version of this patch please add here:\nFixes: https://sourceforge.net/p/openocd/tickets/372/","commit_id":"ea76594f805fdc5263356dc5934e1c86a0b9f2e4"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"4a1987234b27551236ff84a2a2346d21d440e6f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c34a67ba_2772b130","updated":"2022-12-10 06:39:12.000000000","message":"Thanks for the patch.","commit_id":"cb036416eb4ca5a7602fbcb06a71b6124325faa1"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a5785fa529d9df588ee5e64f6b4177f5edef7d56","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"68daa1c2_535705a2","updated":"2022-12-15 08:59:37.000000000","message":"Looks ok, but I haven\u0027t tested it.\nTomas, what do you think? Could this be in -rc3?","commit_id":"ea76594f805fdc5263356dc5934e1c86a0b9f2e4"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"a152cf43a818bf0b05be2ef15a9a24dfb8839a93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cad52df3_4c25f99b","updated":"2022-12-15 16:19:56.000000000","message":"Tested with SAMD09C13. Flash erase does not depend on adapter speed with the change.","commit_id":"ea76594f805fdc5263356dc5934e1c86a0b9f2e4"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"f6d1761003fbca46bee4e07a5885edc236084ce3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5e24abc1_8e2b2850","in_reply_to":"68daa1c2_535705a2","updated":"2022-12-15 16:21:18.000000000","message":"Sure.","commit_id":"ea76594f805fdc5263356dc5934e1c86a0b9f2e4"}],"src/flash/nor/at91samd.c":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"4a1987234b27551236ff84a2a2346d21d440e6f2","unresolved":true,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"/* NVMCTRL bits */"},{"line_number":57,"context_line":"#define SAMD_NVM_CTRLB_MANW 0x80"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"/* Known identifiers */"},{"line_number":60,"context_line":"#define SAMD_PROCESSOR_M0\t0x01"},{"line_number":61,"context_line":"#define SAMD_FAMILY_D\t\t0x00"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"f4f771ad_2c7bcebf","line":58,"updated":"2022-12-10 06:39:12.000000000","message":"Please define SAMD_NVM_INTFLAG_READY here","commit_id":"cb036416eb4ca5a7602fbcb06a71b6124325faa1"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"a152cf43a818bf0b05be2ef15a9a24dfb8839a93","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"/* NVMCTRL bits */"},{"line_number":57,"context_line":"#define SAMD_NVM_CTRLB_MANW 0x80"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"/* Known identifiers */"},{"line_number":60,"context_line":"#define SAMD_PROCESSOR_M0\t0x01"},{"line_number":61,"context_line":"#define SAMD_FAMILY_D\t\t0x00"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"3002e84e_e6b455da","line":58,"in_reply_to":"f4f771ad_2c7bcebf","updated":"2022-12-15 16:19:56.000000000","message":"Done","commit_id":"cb036416eb4ca5a7602fbcb06a71b6124325faa1"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a5785fa529d9df588ee5e64f6b4177f5edef7d56","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"/* NVMCTRL bits */"},{"line_number":57,"context_line":"#define SAMD_NVM_CTRLB_MANW 0x80"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"/* Known identifiers */"},{"line_number":60,"context_line":"#define SAMD_PROCESSOR_M0\t0x01"},{"line_number":61,"context_line":"#define SAMD_FAMILY_D\t\t0x00"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"ce75c568_975e6042","line":58,"in_reply_to":"f4f771ad_2c7bcebf","updated":"2022-12-15 08:59:37.000000000","message":"Done","commit_id":"cb036416eb4ca5a7602fbcb06a71b6124325faa1"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"4a1987234b27551236ff84a2a2346d21d440e6f2","unresolved":true,"context_lines":[{"line_number":510,"context_line":"\t\t\tLOG_ERROR(\"Can\u0027t read NVM intflag\");"},{"line_number":511,"context_line":"\t\t\treturn ret;"},{"line_number":512,"context_line":"\t\t}"},{"line_number":513,"context_line":"\t\tif (intflag \u0026 1) // READY"},{"line_number":514,"context_line":"\t\t\tbreak;"},{"line_number":515,"context_line":"\t\tkeep_alive();"},{"line_number":516,"context_line":"\t} while (timeval_ms() - ts_start \u003c timeout_ms);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"87c760bb_7a160407","line":513,"range":{"start_line":513,"start_character":16,"end_line":513,"end_character":17},"updated":"2022-12-10 06:39:12.000000000","message":"Use defined SAMD_NVM_INTFLAG_READY, remove the comment.","commit_id":"cb036416eb4ca5a7602fbcb06a71b6124325faa1"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a5785fa529d9df588ee5e64f6b4177f5edef7d56","unresolved":false,"context_lines":[{"line_number":510,"context_line":"\t\t\tLOG_ERROR(\"Can\u0027t read NVM intflag\");"},{"line_number":511,"context_line":"\t\t\treturn ret;"},{"line_number":512,"context_line":"\t\t}"},{"line_number":513,"context_line":"\t\tif (intflag \u0026 1) // READY"},{"line_number":514,"context_line":"\t\t\tbreak;"},{"line_number":515,"context_line":"\t\tkeep_alive();"},{"line_number":516,"context_line":"\t} while (timeval_ms() - ts_start \u003c timeout_ms);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"4f3ba38b_69c78576","line":513,"range":{"start_line":513,"start_character":16,"end_line":513,"end_character":17},"in_reply_to":"87c760bb_7a160407","updated":"2022-12-15 08:59:37.000000000","message":"Done","commit_id":"cb036416eb4ca5a7602fbcb06a71b6124325faa1"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"a152cf43a818bf0b05be2ef15a9a24dfb8839a93","unresolved":false,"context_lines":[{"line_number":510,"context_line":"\t\t\tLOG_ERROR(\"Can\u0027t read NVM intflag\");"},{"line_number":511,"context_line":"\t\t\treturn ret;"},{"line_number":512,"context_line":"\t\t}"},{"line_number":513,"context_line":"\t\tif (intflag \u0026 1) // READY"},{"line_number":514,"context_line":"\t\t\tbreak;"},{"line_number":515,"context_line":"\t\tkeep_alive();"},{"line_number":516,"context_line":"\t} while (timeval_ms() - ts_start \u003c timeout_ms);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"8a437c0d_535698db","line":513,"range":{"start_line":513,"start_character":16,"end_line":513,"end_character":17},"in_reply_to":"87c760bb_7a160407","updated":"2022-12-15 16:19:56.000000000","message":"Done","commit_id":"cb036416eb4ca5a7602fbcb06a71b6124325faa1"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"4a1987234b27551236ff84a2a2346d21d440e6f2","unresolved":true,"context_lines":[{"line_number":515,"context_line":"\t\tkeep_alive();"},{"line_number":516,"context_line":"\t} while (timeval_ms() - ts_start \u003c timeout_ms);"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"\tif (!(intflag \u0026 1)) {"},{"line_number":519,"context_line":"\t\tLOG_ERROR(\"SAMD: NVM programming timed out\");"},{"line_number":520,"context_line":"\t\tret \u003d ERROR_FLASH_OPERATION_FAILED;"},{"line_number":521,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"a6283a45_dd55ea15","line":518,"range":{"start_line":518,"start_character":17,"end_line":518,"end_character":18},"updated":"2022-12-10 06:39:12.000000000","message":"Use defined SAMD_NVM_INTFLAG_READY","commit_id":"cb036416eb4ca5a7602fbcb06a71b6124325faa1"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a5785fa529d9df588ee5e64f6b4177f5edef7d56","unresolved":false,"context_lines":[{"line_number":515,"context_line":"\t\tkeep_alive();"},{"line_number":516,"context_line":"\t} while (timeval_ms() - ts_start \u003c timeout_ms);"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"\tif (!(intflag \u0026 1)) {"},{"line_number":519,"context_line":"\t\tLOG_ERROR(\"SAMD: NVM programming timed out\");"},{"line_number":520,"context_line":"\t\tret \u003d ERROR_FLASH_OPERATION_FAILED;"},{"line_number":521,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"1553cce3_e57f5c19","line":518,"range":{"start_line":518,"start_character":17,"end_line":518,"end_character":18},"in_reply_to":"a6283a45_dd55ea15","updated":"2022-12-15 08:59:37.000000000","message":"Done","commit_id":"cb036416eb4ca5a7602fbcb06a71b6124325faa1"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"a152cf43a818bf0b05be2ef15a9a24dfb8839a93","unresolved":false,"context_lines":[{"line_number":515,"context_line":"\t\tkeep_alive();"},{"line_number":516,"context_line":"\t} while (timeval_ms() - ts_start \u003c timeout_ms);"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"\tif (!(intflag \u0026 1)) {"},{"line_number":519,"context_line":"\t\tLOG_ERROR(\"SAMD: NVM programming timed out\");"},{"line_number":520,"context_line":"\t\tret \u003d ERROR_FLASH_OPERATION_FAILED;"},{"line_number":521,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"732bf37d_e3afc528","line":518,"range":{"start_line":518,"start_character":17,"end_line":518,"end_character":18},"in_reply_to":"a6283a45_dd55ea15","updated":"2022-12-15 16:19:56.000000000","message":"Done","commit_id":"cb036416eb4ca5a7602fbcb06a71b6124325faa1"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"4a1987234b27551236ff84a2a2346d21d440e6f2","unresolved":true,"context_lines":[{"line_number":517,"context_line":""},{"line_number":518,"context_line":"\tif (!(intflag \u0026 1)) {"},{"line_number":519,"context_line":"\t\tLOG_ERROR(\"SAMD: NVM programming timed out\");"},{"line_number":520,"context_line":"\t\tret \u003d ERROR_FLASH_OPERATION_FAILED;"},{"line_number":521,"context_line":"\t}"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"\tret \u003d target_read_u16(target,"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"c3bb8cf4_f5e4e33a","line":520,"range":{"start_line":520,"start_character":2,"end_line":520,"end_character":7},"updated":"2022-12-10 06:39:12.000000000","message":"ret will be overwritten in line 523 and there is no point in continuing after timeout. Use\n return ERROR_FLASH_OPERATION_FAILED;\n\ninstead.","commit_id":"cb036416eb4ca5a7602fbcb06a71b6124325faa1"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a5785fa529d9df588ee5e64f6b4177f5edef7d56","unresolved":false,"context_lines":[{"line_number":517,"context_line":""},{"line_number":518,"context_line":"\tif (!(intflag \u0026 1)) {"},{"line_number":519,"context_line":"\t\tLOG_ERROR(\"SAMD: NVM programming timed out\");"},{"line_number":520,"context_line":"\t\tret \u003d ERROR_FLASH_OPERATION_FAILED;"},{"line_number":521,"context_line":"\t}"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"\tret \u003d target_read_u16(target,"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"c072ae4a_9ba86e63","line":520,"range":{"start_line":520,"start_character":2,"end_line":520,"end_character":7},"in_reply_to":"c3bb8cf4_f5e4e33a","updated":"2022-12-15 08:59:37.000000000","message":"Done","commit_id":"cb036416eb4ca5a7602fbcb06a71b6124325faa1"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"a152cf43a818bf0b05be2ef15a9a24dfb8839a93","unresolved":false,"context_lines":[{"line_number":517,"context_line":""},{"line_number":518,"context_line":"\tif (!(intflag \u0026 1)) {"},{"line_number":519,"context_line":"\t\tLOG_ERROR(\"SAMD: NVM programming timed out\");"},{"line_number":520,"context_line":"\t\tret \u003d ERROR_FLASH_OPERATION_FAILED;"},{"line_number":521,"context_line":"\t}"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"\tret \u003d target_read_u16(target,"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"c4112096_fa71d981","line":520,"range":{"start_line":520,"start_character":2,"end_line":520,"end_character":7},"in_reply_to":"c3bb8cf4_f5e4e33a","updated":"2022-12-15 16:19:56.000000000","message":"Done","commit_id":"cb036416eb4ca5a7602fbcb06a71b6124325faa1"}]}