)]}'
{"id":"openocd~master~I19745dae4d3fc6e3a7611dcac628e067cb41e0f0","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-12-17 09:33:40.000000000","reason":"Change was submitted"},"1002091":{"account":{"_account_id":1002091,"name":"Dan Stahlke","display_name":"Dan Stahlke","email":"dan@stahlke.org","username":"dstahlke"},"last_update":"2022-12-17 09:33:40.000000000","reason":"Change was submitted"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2022-12-15 16:21:18.000000000","reason":"Tomas Vanek replied on the change"}},"hashtags":[],"change_id":"I19745dae4d3fc6e3a7611dcac628e067cb41e0f0","subject":"at91samd: wait for nvm ready","status":"MERGED","created":"2022-12-10 03:36:12.000000000","updated":"2022-12-17 09:33:40.000000000","submitted":"2022-12-17 09:33:40.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":17,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"7391","meta_rev_id":"57451039479a52ad26d10db6056a50ee5c21e670","_number":7391,"owner":{"_account_id":1002091,"name":"Dan Stahlke","display_name":"Dan Stahlke","email":"dan@stahlke.org","username":"dstahlke"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-12-17 09:33:40.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-12-17 09:33:40.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-12-17 09:33:40.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-12-10 03:40:57.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-12-10 06:39:12.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"CC"},{"updated":"2022-12-15 08:59:37.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2022-12-15 16:19:56.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"62cb8080f1602f1fb68df557ae16a34c38f17ae6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002091,"name":"Dan Stahlke","display_name":"Dan Stahlke","email":"dan@stahlke.org","username":"dstahlke"},"real_author":{"_account_id":1002091,"name":"Dan Stahlke","display_name":"Dan Stahlke","email":"dan@stahlke.org","username":"dstahlke"},"date":"2022-12-10 03:36:12.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8640dd914e2a363465c1264b7f528a6167f95e4d","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-12-10 03:40:57.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16374/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit/17170/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"74537c6c9c94b811c62c673b157116356128d959","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002091,"name":"Dan Stahlke","display_name":"Dan Stahlke","email":"dan@stahlke.org","username":"dstahlke"},"real_author":{"_account_id":1002091,"name":"Dan Stahlke","display_name":"Dan Stahlke","email":"dan@stahlke.org","username":"dstahlke"},"date":"2022-12-10 04:12:17.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"15ef10e2c9aeeec85164da0cc940cb0767653e3b","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-12-10 05:04:28.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16375/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17171/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"4a1987234b27551236ff84a2a2346d21d440e6f2","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-12-10 06:39:12.000000000","message":"Patch Set 2:\n\n(5 comments)","accounts_in_message":[],"_revision_number":2},{"id":"d269f7e20a62a84dd5362e6efbf09ae1ba96e582","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002091,"name":"Dan Stahlke","display_name":"Dan Stahlke","email":"dan@stahlke.org","username":"dstahlke"},"real_author":{"_account_id":1002091,"name":"Dan Stahlke","display_name":"Dan Stahlke","email":"dan@stahlke.org","username":"dstahlke"},"date":"2022-12-10 18:49:46.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"df407899488036e3b9750d01cf1b6d5e8e66acef","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-12-10 19:44:16.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16377/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17173/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"a5785fa529d9df588ee5e64f6b4177f5edef7d56","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-15 08:59:37.000000000","message":"Patch Set 3: Code-Review+1\n\n(5 comments)","accounts_in_message":[],"_revision_number":3},{"id":"8d4eca055b032a6e3741dbe941955f7c06fb93e2","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-15 09:01:59.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"a152cf43a818bf0b05be2ef15a9a24dfb8839a93","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-12-15 16:19:56.000000000","message":"Patch Set 3: Code-Review+2\n\n(5 comments)","accounts_in_message":[],"_revision_number":3},{"id":"f6d1761003fbca46bee4e07a5885edc236084ce3","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-12-15 16:21:18.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"57451039479a52ad26d10db6056a50ee5c21e670","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-17 09:33:40.000000000","message":"Change has been successfully cherry-picked as 77c7abe4e7569ca8bb23dad6110c7209c8c55558","accounts_in_message":[],"_revision_number":4}],"current_revision":"77c7abe4e7569ca8bb23dad6110c7209c8c55558","revisions":{"77c7abe4e7569ca8bb23dad6110c7209c8c55558":{"kind":"REWORK","_number":4,"created":"2022-12-17 09:33:40.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/91/7391/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/91/7391/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/91/7391/4 \u0026\u0026 git checkout -b change-7391 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/91/7391/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/91/7391/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/91/7391/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/91/7391/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/91/7391/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0a829efda5c254ceca2371edb38e9b0e4a998706","subject":"driver: vdebug: fix mode of cmd \u0027vdebug mem_path\u0027"}],"author":{"name":"Dan Stahlke","email":"dan@stahlke.org","date":"2022-12-05 02:12:16.000000000","tz":-480},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-17 09:33:40.000000000","tz":0},"subject":"at91samd: wait for nvm ready","message":"at91samd: wait for nvm ready\n\nFlashing a SAMD21J17D was failing during NVM erase.  The samd21\ndatasheet specifies that one cause of error conditions is executing an\nNVM command while the previous command is still running.  The solution\nis to wait for INTFLAG.READY after a command is issued.\n\nSAMD21J17A was not exhibiting this problem.  Perhaps the later silicon\nrevision has slower NVM erase times.\n\nSigned-off-by: Dan Stahlke \u003cdan@stahlke.org\u003e\nChange-Id: I19745dae4d3fc6e3a7611dcac628e067cb41e0f0\nReviewed-on: https://review.openocd.org/c/openocd/+/7391\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"ea76594f805fdc5263356dc5934e1c86a0b9f2e4":{"kind":"REWORK","_number":3,"created":"2022-12-10 18:49:46.000000000","uploader":{"_account_id":1002091,"name":"Dan Stahlke","display_name":"Dan Stahlke","email":"dan@stahlke.org","username":"dstahlke"},"ref":"refs/changes/91/7391/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/91/7391/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/91/7391/3 \u0026\u0026 git checkout -b change-7391 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/91/7391/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/91/7391/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/91/7391/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/91/7391/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/91/7391/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9501b263e0ae127b012f5c5e3ba5dffcc7daa8d1","subject":"doc: describe tcl port consistently."}],"author":{"name":"Dan Stahlke","email":"dan@stahlke.org","date":"2022-12-05 02:12:16.000000000","tz":-480},"committer":{"name":"Dan Stahlke","email":"dan@stahlke.org","date":"2022-12-10 18:48:31.000000000","tz":-480},"subject":"at91samd: wait for nvm ready","message":"at91samd: wait for nvm ready\n\nFlashing a SAMD21J17D was failing during NVM erase.  The samd21\ndatasheet specifies that one cause of error conditions is executing an\nNVM command while the previous command is still running.  The solution\nis to wait for INTFLAG.READY after a command is issued.\n\nSAMD21J17A was not exhibiting this problem.  Perhaps the later silicon\nrevision has slower NVM erase times.\n\nSigned-off-by: Dan Stahlke \u003cdan@stahlke.org\u003e\nChange-Id: I19745dae4d3fc6e3a7611dcac628e067cb41e0f0\n"}},"cb036416eb4ca5a7602fbcb06a71b6124325faa1":{"kind":"REWORK","_number":2,"created":"2022-12-10 04:12:17.000000000","uploader":{"_account_id":1002091,"name":"Dan Stahlke","display_name":"Dan Stahlke","email":"dan@stahlke.org","username":"dstahlke"},"ref":"refs/changes/91/7391/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/91/7391/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/91/7391/2 \u0026\u0026 git checkout -b change-7391 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/91/7391/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/91/7391/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/91/7391/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/91/7391/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/91/7391/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9501b263e0ae127b012f5c5e3ba5dffcc7daa8d1","subject":"doc: describe tcl port consistently."}],"author":{"name":"Dan Stahlke","email":"dan@stahlke.org","date":"2022-12-05 02:12:16.000000000","tz":-480},"committer":{"name":"Dan Stahlke","email":"dan@stahlke.org","date":"2022-12-10 03:58:56.000000000","tz":-480},"subject":"at91samd: wait for nvm ready","message":"at91samd: wait for nvm ready\n\nFlashing a SAMD21J17D was failing during NVM erase.  The samd21\ndatasheet specifies that one cause of error conditions is executing an\nNVM command while the previous command is still running.  The solution\nis to wait for INTFLAG.READY after a command is issued.\n\nSAMD21J17A was not exhibiting this problem.  Perhaps the later silicon\nrevision has slower NVM erase times.\n\nSigned-off-by: Dan Stahlke \u003cdan@stahlke.org\u003e\nChange-Id: I19745dae4d3fc6e3a7611dcac628e067cb41e0f0\n"}},"3894c5c3f9896f513029b78a224f98ddd173e3f6":{"kind":"REWORK","_number":1,"created":"2022-12-10 03:36:12.000000000","uploader":{"_account_id":1002091,"name":"Dan Stahlke","display_name":"Dan Stahlke","email":"dan@stahlke.org","username":"dstahlke"},"ref":"refs/changes/91/7391/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/91/7391/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/91/7391/1 \u0026\u0026 git checkout -b change-7391 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/91/7391/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/91/7391/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/91/7391/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/91/7391/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/91/7391/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9501b263e0ae127b012f5c5e3ba5dffcc7daa8d1","subject":"doc: describe tcl port consistently."}],"author":{"name":"Dan Stahlke","email":"dan@stahlke.org","date":"2022-12-05 02:12:16.000000000","tz":-480},"committer":{"name":"Dan Stahlke","email":"dan@stahlke.org","date":"2022-12-10 03:36:02.000000000","tz":-480},"subject":"at91samd: wait for nvm ready","message":"at91samd: wait for nvm ready\n\nFlashing a SAMD21J17D was failing during NVM erase.  The samd21\ndatasheet specifies that one cause of error conditions is executing an\nNVM command while the previous command is still running.  The solution\nis to wait for INTFLAG.READY after a command is issued.\n\nSAMD21J17A was not exhibiting this problem.  Perhaps the later silicon\nrevision has slower NVM erase times.\n\nSigned-off-by: Dan Stahlke \u003cdan@stahlke.org\u003e\nChange-Id: I19745dae4d3fc6e3a7611dcac628e067cb41e0f0\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}