)]}'
{"id":"openocd~master~I806ec3b1b02fcc76e141c8dd3a65044febbf0a8c","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-12-15 20:52:55.000000000","reason":"Antonio Borneo replied on the change"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2022-12-17 09:30:45.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I806ec3b1b02fcc76e141c8dd3a65044febbf0a8c","subject":"arm_adi_v5: fix SIGSEGV due to failing re-examine","status":"MERGED","created":"2022-12-10 17:44:35.000000000","updated":"2022-12-17 09:30:45.000000000","submitted":"2022-12-17 09:30:45.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7392","meta_rev_id":"58092b90a28ee8155aab27346dc99389fd27ceea","_number":7392,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-12-17 09:30:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-12-17 09:30:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-12-17 09:30:45.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-12-10 17:44:35.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2022-12-10 18:40:36.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"286ed25f11a942ae75c0e57c0d4320c7c407b22b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-10 17:44:35.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"35b9ea133ae647e0f902b994637700b4fd0b808b","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-12-10 18:40:36.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16376/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17172/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"b93bf34fedd9268036c4a75c4939660e18ff7e8e","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-10 20:56:22.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"5058066fd527144ca8287d7271fa4e50a17e89e9","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-12-15 16:50:44.000000000","message":"Patch Set 1: Code-Review+1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"7b447648543162762d3ad5695404443b8cad695a","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-15 20:52:55.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"7d0241e780f67b02b6bf1ec7fa3d9a93d55a0fcf","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-17 09:30:27.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"58092b90a28ee8155aab27346dc99389fd27ceea","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-17 09:30:45.000000000","message":"Change has been successfully cherry-picked as c6fe10de75763623dfdaaf2fe3fff7e78a4ca146","accounts_in_message":[],"_revision_number":2}],"current_revision":"c6fe10de75763623dfdaaf2fe3fff7e78a4ca146","revisions":{"85e05cd372f9ef85cb9f54ce487af6efb4aa83bb":{"kind":"REWORK","_number":1,"created":"2022-12-10 17:44:35.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/92/7392/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/92/7392/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/92/7392/1 \u0026\u0026 git checkout -b change-7392 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/92/7392/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/92/7392/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/92/7392/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/92/7392/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/92/7392/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9501b263e0ae127b012f5c5e3ba5dffcc7daa8d1","subject":"doc: describe tcl port consistently."}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-10 17:19:54.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-10 17:31:33.000000000","tz":60},"subject":"arm_adi_v5: fix SIGSEGV due to failing re-examine","message":"arm_adi_v5: fix SIGSEGV due to failing re-examine\n\nCommit 35a503b08d14 (\"arm_adi_v5: add ap refcount and add get/put\naround ap use\") modifies the examine functions of mem_ap, cortex_m,\ncortex_a and aarch64 by calling dap_put_ap() and then looking again\nfor the mem-ap and calling dap_get_ap().\nThis causes an issue if the system is irresponsive and the examine\nfails and left the AP pointer to NULL. If the system was already\nexamined the NULL pointer will cause a SIGSEGV.\n\nCommit b6dad912b85d (\"target/cortex_m: prevent segmentation fault\nin cortex_m_poll()\") proposes a fix for one specific case and only\non cortex_m.\n\nModify all the examine functions by skipping look-up for the AP if\nit was already set in a previous examine; the target\u0027s AP is not\nsupposed to change during runtime.\n\nRemove the partial fix for cortex_m as it is not needed anymore.\n\nChange-Id: I806ec3b1b02fcc76e141c8dd3a65044febbf0a8c\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nFixes: 35a503b08d14 (\"arm_adi_v5: add ap refcount and add get/put around ap use\")\n"}},"c6fe10de75763623dfdaaf2fe3fff7e78a4ca146":{"kind":"REWORK","_number":2,"created":"2022-12-17 09:30:45.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/92/7392/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/92/7392/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/92/7392/2 \u0026\u0026 git checkout -b change-7392 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/92/7392/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/92/7392/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/92/7392/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/92/7392/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/92/7392/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2278878a05d8dfbbed3e59f0cfbeeb598af3129c","subject":"src/target/mips_m4k.c: set missing flag in set_watchpoint"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-10 17:19:54.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-17 09:30:45.000000000","tz":0},"subject":"arm_adi_v5: fix SIGSEGV due to failing re-examine","message":"arm_adi_v5: fix SIGSEGV due to failing re-examine\n\nCommit 35a503b08d14 (\"arm_adi_v5: add ap refcount and add get/put\naround ap use\") modifies the examine functions of mem_ap, cortex_m,\ncortex_a and aarch64 by calling dap_put_ap() and then looking again\nfor the mem-ap and calling dap_get_ap().\nThis causes an issue if the system is irresponsive and the examine\nfails and left the AP pointer to NULL. If the system was already\nexamined the NULL pointer will cause a SIGSEGV.\n\nCommit b6dad912b85d (\"target/cortex_m: prevent segmentation fault\nin cortex_m_poll()\") proposes a fix for one specific case and only\non cortex_m.\n\nModify all the examine functions by skipping look-up for the AP if\nit was already set in a previous examine; the target\u0027s AP is not\nsupposed to change during runtime.\n\nRemove the partial fix for cortex_m as it is not needed anymore.\n\nChange-Id: I806ec3b1b02fcc76e141c8dd3a65044febbf0a8c\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nFixes: 35a503b08d14 (\"arm_adi_v5: add ap refcount and add get/put around ap use\")\nReviewed-on: https://review.openocd.org/c/openocd/+/7392\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}