)]}'
{"id":"openocd~master~Ib4b140221d1c1b63419de109579bde8b63fc2e8c","project":"openocd","branch":"master","hashtags":[],"change_id":"Ib4b140221d1c1b63419de109579bde8b63fc2e8c","subject":"target: cortex_a: fix clang error core.CallAndMessage","status":"MERGED","created":"2022-12-10 21:50:02.000000000","updated":"2022-12-17 09:31:29.000000000","submitted":"2022-12-17 09:31:29.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7393","meta_rev_id":"389a9e8cb11cc7b33d6ec2d6afac65551cdb302a","_number":7393,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-12-17 09:31:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-12-17 09:31:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-12-10 22:40:38.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"67aa1d8cfa79f74b91fea0ab3283724d5145ecff","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-10 21:50:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e6bdf0c3c16d2757aebe35e4fe29c8b4d0d2a145","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-12-10 22:40:38.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16378/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17174/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"12fb6ab381314ebf0e12b8e71c122d42a7820708","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-11 08:48:02.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"0e914b800508fe90fac4e82eff2df12db3b8809d","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-17 09:31:23.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"389a9e8cb11cc7b33d6ec2d6afac65551cdb302a","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-17 09:31:29.000000000","message":"Change has been successfully cherry-picked as a6b02219529d1d48d130e4bed9c8d55395662ff6","accounts_in_message":[],"_revision_number":2}],"current_revision":"a6b02219529d1d48d130e4bed9c8d55395662ff6","revisions":{"a6b02219529d1d48d130e4bed9c8d55395662ff6":{"kind":"REWORK","_number":2,"created":"2022-12-17 09:31:29.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/93/7393/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/93/7393/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/93/7393/2 \u0026\u0026 git checkout -b change-7393 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/93/7393/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/93/7393/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/93/7393/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/93/7393/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/93/7393/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c6fe10de75763623dfdaaf2fe3fff7e78a4ca146","subject":"arm_adi_v5: fix SIGSEGV due to failing re-examine"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-10 21:15:44.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-17 09:31:29.000000000","tz":0},"subject":"target: cortex_a: fix clang error core.CallAndMessage","message":"target: cortex_a: fix clang error core.CallAndMessage\n\nClang complains about the variable \u0027orig_dfsr\u0027 that can be used\nuninitialized both in cortex_a_read_cpu_memory() and in\ncortex_a_write_cpu_memory().\n\nThe issue is caused by an incorrect error path that used to jump\nthrough \u0027goto out\u0027. The code after the label \u0027out\u0027 is specific to\nhandle the case of an error during memory R/W; it is incorrect to\njump there to handle an error during the initialization that\nprecedes the memory R/W.\n\nReplace the \u0027goto out\u0027 with \u0027return retval\u0027.\nRemove the label \u0027out\u0027 that is now unused.\n\nChange-Id: Ib4b140221d1c1b63419de109579bde8b63fc2e8c\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7393\nTested-by: jenkins\n"}},"4a37feae6a10f4a159b9a519a5b66aa2ae50dae4":{"kind":"REWORK","_number":1,"created":"2022-12-10 21:50:02.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/93/7393/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/93/7393/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/93/7393/1 \u0026\u0026 git checkout -b change-7393 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/93/7393/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/93/7393/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/93/7393/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/93/7393/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/93/7393/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9501b263e0ae127b012f5c5e3ba5dffcc7daa8d1","subject":"doc: describe tcl port consistently."}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-10 21:15:44.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-10 21:47:43.000000000","tz":60},"subject":"target: cortex_a: fix clang error core.CallAndMessage","message":"target: cortex_a: fix clang error core.CallAndMessage\n\nClang complains about the variable \u0027orig_dfsr\u0027 that can be used\nuninitialized both in cortex_a_read_cpu_memory() and in\ncortex_a_write_cpu_memory().\n\nThe issue is caused by an incorrect error path that used to jump\nthrough \u0027goto out\u0027. The code after the label \u0027out\u0027 is specific to\nhandle the case of an error during memory R/W; it is incorrect to\njump there to handle an error during the initialization that\nprecedes the memory R/W.\n\nReplace the \u0027goto out\u0027 with \u0027return retval\u0027.\nRemove the label \u0027out\u0027 that is now unused.\n\nChange-Id: Ib4b140221d1c1b63419de109579bde8b63fc2e8c\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}