)]}'
{"id":"openocd~master~Id8ead3f6db0fd5730682a0d1638f11836d06a632","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001043":{"account":{"_account_id":1001043,"name":"Chris Bertrand","email":"fenugrec@users.sourceforge.net","username":"fenugrec"},"last_update":"2022-12-13 21:55:42.000000000","reason":"Chris Bertrand replied on the change"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-12-14 10:13:41.000000000","reason":"Antonio Borneo replied on the change"}},"hashtags":[],"change_id":"Id8ead3f6db0fd5730682a0d1638f11836d06a632","subject":"target: fix unsigned computation in \u0027monitor profile\u0027","status":"MERGED","created":"2022-12-11 09:22:50.000000000","updated":"2022-12-17 09:32:09.000000000","submitted":"2022-12-17 09:32:09.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7394","meta_rev_id":"f8f71f43ef86da9e0373dd4bb8639e1dd1c3f53a","_number":7394,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-12-17 09:32:09.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-12-17 09:32:09.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":1001043,"name":"Chris Bertrand","email":"fenugrec@users.sourceforge.net","username":"fenugrec"}],"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-12-11 09:59:29.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-12-11 16:11:12.000000000","updated_by":{"_account_id":1001043,"name":"Chris Bertrand","email":"fenugrec@users.sourceforge.net","username":"fenugrec"},"reviewer":{"_account_id":1001043,"name":"Chris Bertrand","email":"fenugrec@users.sourceforge.net","username":"fenugrec"},"state":"CC"}],"messages":[{"id":"c1d9ed9781a0cadfe251409e6a2e85001da72d5f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-11 09:22:50.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"54287a5b69dd5480a6ed63f0b8e9c97e47a5a67d","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-12-11 09:59:29.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16379/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17175/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"6acf64ad4398f7106c31290494961808406b632f","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-11 10:13:45.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"918a1d9040782d6eaecee3c235eafe339c4bd91f","author":{"_account_id":1001043,"name":"Chris Bertrand","email":"fenugrec@users.sourceforge.net","username":"fenugrec"},"real_author":{"_account_id":1001043,"name":"Chris Bertrand","email":"fenugrec@users.sourceforge.net","username":"fenugrec"},"date":"2022-12-11 16:11:12.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"3948510e4ff9ef18adfe888c0d5a78103963c4c6","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-11 16:46:49.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"08f943411eed59069d9da7815decad3e6011dda2","author":{"_account_id":1001043,"name":"Chris Bertrand","email":"fenugrec@users.sourceforge.net","username":"fenugrec"},"real_author":{"_account_id":1001043,"name":"Chris Bertrand","email":"fenugrec@users.sourceforge.net","username":"fenugrec"},"date":"2022-12-13 21:55:42.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"751155fd4366ee10ed7572b1b39c138ece7ee653","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-14 10:13:41.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"bd15ef3d641adc536e60018f157e6c337ba1395d","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-14 15:48:11.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"3f0589a0d61b96713493b9f07bce01930e1ab14b","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-17 09:32:03.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"f8f71f43ef86da9e0373dd4bb8639e1dd1c3f53a","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-17 09:32:09.000000000","message":"Change has been successfully cherry-picked as a51ac964c6160646f2c28db854aa8faf096eb314","accounts_in_message":[],"_revision_number":2}],"current_revision":"a51ac964c6160646f2c28db854aa8faf096eb314","revisions":{"c52e71d32ce00377d56872a3da2fad362165cda9":{"kind":"REWORK","_number":1,"created":"2022-12-11 09:22:50.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/94/7394/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/94/7394/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/94/7394/1 \u0026\u0026 git checkout -b change-7394 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/94/7394/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/94/7394/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/94/7394/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/94/7394/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/94/7394/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9501b263e0ae127b012f5c5e3ba5dffcc7daa8d1","subject":"doc: describe tcl port consistently."}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-11 09:11:58.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-11 09:11:58.000000000","tz":60},"subject":"target: fix unsigned computation in \u0027monitor profile\u0027","message":"target: fix unsigned computation in \u0027monitor profile\u0027\n\nThe implementation of command \u0027monitor profile\u0027 has few\nissues:\n- the address_space is a signed int, so cannot wrap-around on\n  space over INT_MAX;\n- max address is incremented without check for overflow;\n- assert() used on errors instead of returning error codes;\n- only handles 32 bits PC;\n- output file created and left empty on error.\n\nThis patch fixes the first two issues, as a wider fix would be too\ninvasive and should be postponed in a following series.\n\nChange-Id: Id8ead3f6db0fd5730682a0d1638f11836d06a632\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nFixes: https://sourceforge.net/p/openocd/tickets/370/\n"}},"a51ac964c6160646f2c28db854aa8faf096eb314":{"kind":"REWORK","_number":2,"created":"2022-12-17 09:32:09.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/94/7394/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/94/7394/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/94/7394/2 \u0026\u0026 git checkout -b change-7394 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/94/7394/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/94/7394/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/94/7394/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/94/7394/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/94/7394/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a6b02219529d1d48d130e4bed9c8d55395662ff6","subject":"target: cortex_a: fix clang error core.CallAndMessage"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-11 09:11:58.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-17 09:32:09.000000000","tz":0},"subject":"target: fix unsigned computation in \u0027monitor profile\u0027","message":"target: fix unsigned computation in \u0027monitor profile\u0027\n\nThe implementation of command \u0027monitor profile\u0027 has few\nissues:\n- the address_space is a signed int, so cannot wrap-around on\n  space over INT_MAX;\n- max address is incremented without check for overflow;\n- assert() used on errors instead of returning error codes;\n- only handles 32 bits PC;\n- output file created and left empty on error.\n\nThis patch fixes the first two issues, as a wider fix would be too\ninvasive and should be postponed in a following series.\n\nChange-Id: Id8ead3f6db0fd5730682a0d1638f11836d06a632\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nFixes: https://sourceforge.net/p/openocd/tickets/370/\nReviewed-on: https://review.openocd.org/c/openocd/+/7394\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}