)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001415,"name":"Jonathan McDowell","email":"noodles-openocd@earth.li","username":"u1f35c"},"change_message_id":"52a6ebb3e5ebe34bc942c51212a97fc076c6145f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c2569320_7ababb8f","updated":"2022-12-14 22:24:18.000000000","message":"Generally LGTM. Same comments as for ECP5 apply; PRELOAD unused, example doesn\u0027t actually show the pld device example.","commit_id":"5cde05d8c0551a9daa3faf7045ed8749116cd0a4"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"4b50f1238ff4ddeb8261fe398bb8b27adae1ef5e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"cac0c9f0_10d00484","updated":"2022-12-19 12:36:26.000000000","message":"\u003e Patch Set 7: Verified-1\n\u003e \n\u003e Build Failed \n\u003e \n\u003e https://build.openocd.org/job/openocd-gerrit-build/16413/ : ABORTED\n\u003e \n\u003e https://build.openocd.org/job/openocd-gerrit/17210/ : SUCCESS\n\n","commit_id":"2549d32e39b3a2bab4b1caedbf78684040e3241d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c3f147595dbd450e25c545c01dbec76751bf7261","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"13ee2f58_7bfea0c4","updated":"2023-04-02 13:27:37.000000000","message":"There are few modification here that are not specific of certus and could be in the initial patch of this series 7396\nPlus, my request to put enum uppercase, will change to something like LATTICE_CERTUS. Please update this patch accrodingly","commit_id":"f24736971f0442db787c41324c28eab169ab823c"}],"src/pld/certus.c":[{"author":{"_account_id":1001415,"name":"Jonathan McDowell","email":"noodles-openocd@earth.li","username":"u1f35c"},"change_message_id":"52a6ebb3e5ebe34bc942c51212a97fc076c6145f","unresolved":true,"context_lines":[{"line_number":24,"context_line":"#define ISC_ENABLE           0xC6"},{"line_number":25,"context_line":"#define BYPASS               0xFF"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"int lattice_certus_load(struct lattice_pld_device *lattice_device, struct lattice_bit_file *bit_file);"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"int lattice_certus_read_status(struct jtag_tap *tap, uint64_t *status, uint64_t out)"},{"line_number":30,"context_line":"{"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"f5e137e9_3b14be5e","line":27,"updated":"2022-12-14 22:24:18.000000000","message":"Just include certus.h? It\u0027s not like this function is even used before definition in the file.","commit_id":"5cde05d8c0551a9daa3faf7045ed8749116cd0a4"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"e51b49f86a239e4b31d351d1e864f8185ef3566b","unresolved":false,"context_lines":[{"line_number":24,"context_line":"#define ISC_ENABLE           0xC6"},{"line_number":25,"context_line":"#define BYPASS               0xFF"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"int lattice_certus_load(struct lattice_pld_device *lattice_device, struct lattice_bit_file *bit_file);"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"int lattice_certus_read_status(struct jtag_tap *tap, uint64_t *status, uint64_t out)"},{"line_number":30,"context_line":"{"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"ebc38362_9e307aab","line":27,"in_reply_to":"f5e137e9_3b14be5e","updated":"2022-12-14 23:59:43.000000000","message":"Done","commit_id":"5cde05d8c0551a9daa3faf7045ed8749116cd0a4"}],"src/pld/ecp2_3.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c3f147595dbd450e25c545c01dbec76751bf7261","unresolved":true,"context_lines":[{"line_number":18,"context_line":"#define ISC_ERASE            0x03"},{"line_number":19,"context_line":"#define READ_USERCODE        0x17"},{"line_number":20,"context_line":"#define ISC_DISABLE          0x1E"},{"line_number":21,"context_line":"#define BYPASS               0xFF"},{"line_number":22,"context_line":"#define LSCC_READ_STATUS     0x53"},{"line_number":23,"context_line":"#define LSCC_BITSTREAM_BURST 0x02"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":11,"id":"f285d0b4_23aa8a6b","side":"PARENT","line":21,"updated":"2023-04-02 13:27:37.000000000","message":"can this change be part of 7396 ?","commit_id":"58e2fe2f46ba2ea215b90053e7d088029beea574"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"eccf91893b5376d165aae2129027145ff6f02b73","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#define ISC_ERASE            0x03"},{"line_number":19,"context_line":"#define READ_USERCODE        0x17"},{"line_number":20,"context_line":"#define ISC_DISABLE          0x1E"},{"line_number":21,"context_line":"#define BYPASS               0xFF"},{"line_number":22,"context_line":"#define LSCC_READ_STATUS     0x53"},{"line_number":23,"context_line":"#define LSCC_BITSTREAM_BURST 0x02"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":11,"id":"d5e85fa3_241e013f","side":"PARENT","line":21,"in_reply_to":"f285d0b4_23aa8a6b","updated":"2023-04-08 19:30:13.000000000","message":"Done","commit_id":"58e2fe2f46ba2ea215b90053e7d088029beea574"}],"src/pld/ecp5.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c3f147595dbd450e25c545c01dbec76751bf7261","unresolved":true,"context_lines":[{"line_number":18,"context_line":"#define LSC_INIT_ADDRESS     0x46"},{"line_number":19,"context_line":"#define LSC_BITSTREAM_BURST  0x7A"},{"line_number":20,"context_line":"#define READ_USERCODE        0xC0"},{"line_number":21,"context_line":"#define ISC_DISABLE          0x26"},{"line_number":22,"context_line":"#define ISC_PROGRAM_USERCODE 0xC2"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"#define STATUS_DONE_BIT        0x00000100"}],"source_content_type":"text/x-csrc","patch_set":11,"id":"0b09b500_43ffa386","side":"PARENT","line":21,"updated":"2023-04-02 13:27:37.000000000","message":"can this change be in 7396 ?","commit_id":"58e2fe2f46ba2ea215b90053e7d088029beea574"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"eccf91893b5376d165aae2129027145ff6f02b73","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#define LSC_INIT_ADDRESS     0x46"},{"line_number":19,"context_line":"#define LSC_BITSTREAM_BURST  0x7A"},{"line_number":20,"context_line":"#define READ_USERCODE        0xC0"},{"line_number":21,"context_line":"#define ISC_DISABLE          0x26"},{"line_number":22,"context_line":"#define ISC_PROGRAM_USERCODE 0xC2"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"#define STATUS_DONE_BIT        0x00000100"}],"source_content_type":"text/x-csrc","patch_set":11,"id":"4b2e663b_11bc1563","side":"PARENT","line":21,"in_reply_to":"0b09b500_43ffa386","updated":"2023-04-08 19:30:13.000000000","message":"Done","commit_id":"58e2fe2f46ba2ea215b90053e7d088029beea574"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c3f147595dbd450e25c545c01dbec76751bf7261","unresolved":true,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"int lattice_ecp5_read_status(struct jtag_tap *tap, uint32_t *status, uint32_t out, bool do_idle)"},{"line_number":32,"context_line":"{"},{"line_number":33,"context_line":"\treturn lattice_read_u32_register(tap, LSCC_READ_STATUS, status, out, do_idle);"},{"line_number":34,"context_line":"}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"int lattice_ecp5_read_usercode(struct jtag_tap *tap, uint32_t *usercode, uint32_t out)"}],"source_content_type":"text/x-csrc","patch_set":11,"id":"f77fd9ca_ac12c1a9","side":"PARENT","line":33,"updated":"2023-04-02 13:27:37.000000000","message":"this too","commit_id":"58e2fe2f46ba2ea215b90053e7d088029beea574"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"eccf91893b5376d165aae2129027145ff6f02b73","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"int lattice_ecp5_read_status(struct jtag_tap *tap, uint32_t *status, uint32_t out, bool do_idle)"},{"line_number":32,"context_line":"{"},{"line_number":33,"context_line":"\treturn lattice_read_u32_register(tap, LSCC_READ_STATUS, status, out, do_idle);"},{"line_number":34,"context_line":"}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"int lattice_ecp5_read_usercode(struct jtag_tap *tap, uint32_t *usercode, uint32_t out)"}],"source_content_type":"text/x-csrc","patch_set":11,"id":"20918360_76716463","side":"PARENT","line":33,"in_reply_to":"f77fd9ca_ac12c1a9","updated":"2023-04-08 19:30:13.000000000","message":"Done","commit_id":"58e2fe2f46ba2ea215b90053e7d088029beea574"}]}