)]}'
{"id":"openocd~master~I2be8df8568ce8c889923888c492e4f7ce354b16b","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001043":{"account":{"_account_id":1001043,"name":"Chris Bertrand","email":"fenugrec@users.sourceforge.net","username":"fenugrec"},"last_update":"2022-12-17 09:32:34.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-12-14 15:08:07.000000000","reason":"Antonio Borneo replied on the change"}},"hashtags":[],"change_id":"I2be8df8568ce8c889923888c492e4f7ce354b16b","subject":"target: fix assert in \u0027monitor profile\u0027 on constant PC","status":"MERGED","created":"2022-12-14 14:31:37.000000000","updated":"2022-12-17 09:32:34.000000000","submitted":"2022-12-17 09:32:34.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7400","meta_rev_id":"37634163d8ca2db231a83c4a6a6ec337a2aa51a2","_number":7400,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001043,"name":"Chris Bertrand","email":"fenugrec@users.sourceforge.net","username":"fenugrec"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-12-17 09:32:34.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"value":0,"_account_id":1001043,"name":"Chris Bertrand","email":"fenugrec@users.sourceforge.net","username":"fenugrec"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-12-17 09:32:34.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001043,"name":"Chris Bertrand","email":"fenugrec@users.sourceforge.net","username":"fenugrec"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-12-14 14:31:37.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001043,"name":"Chris Bertrand","email":"fenugrec@users.sourceforge.net","username":"fenugrec"},"state":"REVIEWER"},{"updated":"2022-12-14 15:09:53.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2022-12-14 19:56:30.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"ea18f6bd4c19e9dd13681d05d1d5f6ae2e6f4fbb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-14 14:31:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2137f21e4b090f85b0620cc19fba7f3ae7fd3f74","author":{"_account_id":1001043,"name":"Chris Bertrand","email":"fenugrec@users.sourceforge.net","username":"fenugrec"},"real_author":{"_account_id":1001043,"name":"Chris Bertrand","email":"fenugrec@users.sourceforge.net","username":"fenugrec"},"date":"2022-12-14 15:01:51.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"902b402c16395fe9ce83a737b16e4e799be70fb9","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-14 15:08:07.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"fd5842275a073bf70be9af0d144545d25f69cafb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-14 15:09:37.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"b496106b102755543a1a39350acc758552b49172","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-12-14 15:09:53.000000000","message":"Patch Set 1:\n\nNo Builds Executed","accounts_in_message":[],"_revision_number":1},{"id":"2b143d9abd570259f3138c00de94b0a060560096","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-12-14 19:56:30.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16411/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17208/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"1525270bbe1057445b3015e5bcd559f953b2a46b","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-17 09:32:26.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"37634163d8ca2db231a83c4a6a6ec337a2aa51a2","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-17 09:32:34.000000000","message":"Change has been successfully cherry-picked as 2b6fe8f1ab739798309b47f7b3a664894ba43a19","accounts_in_message":[],"_revision_number":3}],"current_revision":"2b6fe8f1ab739798309b47f7b3a664894ba43a19","revisions":{"2b6fe8f1ab739798309b47f7b3a664894ba43a19":{"kind":"REWORK","_number":3,"created":"2022-12-17 09:32:34.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/00/7400/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/00/7400/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/00/7400/3 \u0026\u0026 git checkout -b change-7400 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/00/7400/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/00/7400/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/00/7400/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/00/7400/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/00/7400/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a51ac964c6160646f2c28db854aa8faf096eb314","subject":"target: fix unsigned computation in \u0027monitor profile\u0027"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-14 14:21:43.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-17 09:32:34.000000000","tz":0},"subject":"target: fix assert in \u0027monitor profile\u0027 on constant PC","message":"target: fix assert in \u0027monitor profile\u0027 on constant PC\n\nWhen target is stopped in WFI/WFE or is in an infinite loop, the\nsampled PC will always return the same value.\nCommand \u0027profile\u0027 requires that distance between min and max PC\nshould be at least 2, which is not the case for constant PC, and\nincorrectly enforces the check through as assert().\n\nMove the code that reads the optional parameters \u0027start\u0027 and \u0027end\u0027\nand check the gap \u0027end - start\u0027 before running the profile.\nFor self-computed min and max, increase max (or decrease min) to\nmatch the required constraint.\nDrop the assert().\n\nChange-Id: I2be8df8568ce8c889923888c492e4f7ce354b16b\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nFixes: https://sourceforge.net/p/openocd/tickets/370/\nReviewed-on: https://review.openocd.org/c/openocd/+/7400\nTested-by: jenkins\n"}},"1a28321913657305d9aa5e4a1148b47b1ce83086":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2022-12-14 15:09:37.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/00/7400/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/00/7400/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/00/7400/2 \u0026\u0026 git checkout -b change-7400 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/00/7400/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/00/7400/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/00/7400/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/00/7400/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/00/7400/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c52e71d32ce00377d56872a3da2fad362165cda9","subject":"target: fix unsigned computation in \u0027monitor profile\u0027"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-14 14:21:43.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-14 15:08:52.000000000","tz":60},"subject":"target: fix assert in \u0027monitor profile\u0027 on constant PC","message":"target: fix assert in \u0027monitor profile\u0027 on constant PC\n\nWhen target is stopped in WFI/WFE or is in an infinite loop, the\nsampled PC will always return the same value.\nCommand \u0027profile\u0027 requires that distance between min and max PC\nshould be at least 2, which is not the case for constant PC, and\nincorrectly enforces the check through as assert().\n\nMove the code that reads the optional parameters \u0027start\u0027 and \u0027end\u0027\nand check the gap \u0027end - start\u0027 before running the profile.\nFor self-computed min and max, increase max (or decrease min) to\nmatch the required constraint.\nDrop the assert().\n\nChange-Id: I2be8df8568ce8c889923888c492e4f7ce354b16b\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nFixes: https://sourceforge.net/p/openocd/tickets/370/\n"}},"7238806b22149f297a5c39e6297393af79428b82":{"kind":"REWORK","_number":1,"created":"2022-12-14 14:31:37.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/00/7400/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/00/7400/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/00/7400/1 \u0026\u0026 git checkout -b change-7400 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/00/7400/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/00/7400/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/00/7400/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/00/7400/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/00/7400/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c52e71d32ce00377d56872a3da2fad362165cda9","subject":"target: fix unsigned computation in \u0027monitor profile\u0027"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-14 14:21:43.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-14 14:21:43.000000000","tz":60},"subject":"target: fix assert in \u0027monitor profile\u0027 on constant PC","message":"target: fix assert in \u0027monitor profile\u0027 on constant PC\n\nWhen target is stopped in WFI/WFE or is in an infinite loop, the\nsampled PC will always return the same value.\nCommand \u0027profile\u0027 requires that distance between min and max PC\nshould be at least 2, which is not the case for constant PC, and\nincorrectly enforces the check through as assert().\n\nMove the code that reads the optional parameters \u0027start\u0027 and \u0027end\u0027\nand check the gap \u0027end - start\u0027 before running the profile.\nFor self-computed min and max, increase max (or decrease min) to\nmatch the required constraint.\nDrop the assert().\n\nChange-Id: I2be8df8568ce8c889923888c492e4f7ce354b16b\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}