)]}'
{"id":"openocd~master~Ifc8a6e4686555578a7355a1f6049471fd5e31913","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-12-18 21:49:57.000000000","reason":"Antonio Borneo replied on the change"},"1001517":{"account":{"_account_id":1001517,"name":"TM","email":"tommy_murphy@hotmail.com"},"last_update":"2022-12-18 21:50:17.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ifc8a6e4686555578a7355a1f6049471fd5e31913","subject":"jtag: fix build with configure --enable-verbose","status":"MERGED","created":"2022-12-17 22:43:04.000000000","updated":"2022-12-18 21:50:17.000000000","submitted":"2022-12-18 21:50:17.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7403","meta_rev_id":"3615133ec7fc4ecce17749e4937ac442f45159d5","_number":7403,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-12-18 21:50:17.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-12-18 21:50:17.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-12-18 21:50:17.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1001517,"name":"TM","email":"tommy_murphy@hotmail.com"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1001517,"name":"TM","email":"tommy_murphy@hotmail.com"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-12-17 22:43:04.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001517,"name":"TM","email":"tommy_murphy@hotmail.com"},"state":"REVIEWER"},{"updated":"2022-12-18 00:42:12.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-12-18 17:01:58.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"461a6687a62f969af8a901138ea7fa9dd416c1fd","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-17 22:43:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4027208fc3c64f373cb3cc8ef3aec67de0fdd45a","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-12-18 00:42:12.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16422/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/17219/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"5bfffeb980541bcf7f8799708e9a054f704be017","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-12-18 17:01:58.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"01df0b137b56612663b37f0b6bd276614f802747","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-18 21:49:57.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"3615133ec7fc4ecce17749e4937ac442f45159d5","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-18 21:50:17.000000000","message":"Change has been successfully cherry-picked as c913e4d5a6cafab9a19735c440be8d0c111b2088","accounts_in_message":[],"_revision_number":2}],"current_revision":"c913e4d5a6cafab9a19735c440be8d0c111b2088","revisions":{"7fbb115cda77ca1b39fb0aefd95849f505b275f2":{"kind":"REWORK","_number":1,"created":"2022-12-17 22:43:04.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/03/7403/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/03/7403/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/03/7403/1 \u0026\u0026 git checkout -b change-7403 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/03/7403/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/03/7403/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/03/7403/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/03/7403/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/03/7403/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"77c7abe4e7569ca8bb23dad6110c7209c8c55558","subject":"at91samd: wait for nvm ready"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-17 22:05:23.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-17 22:30:13.000000000","tz":60},"subject":"jtag: fix build with configure --enable-verbose","message":"jtag: fix build with configure --enable-verbose\n\nWith flag --enable-verbose, configure enables compiling some\nconditional code that with new gcc triggers an error:\n\terror: \u0027%04x\u0027 directive output may be truncated writing\n\tbetween 4 and 8 bytes into a region of size 5\n\t[-Werror\u003dformat-truncation\u003d]\n\nExtend the buffer to contain the full 8 bytes of %04x on a \u0027int\u0027\nand change the limit in snprintf.\nSkip the intermediate buffer \u0027s[4]\u0027.\nAlign the code to the coding style.\n\nChange-Id: Ifc8a6e4686555578a7355a1f6049471fd5e31913\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReported-by: Karl Hammar \u003ckarl@aspodata.se\u003e\nReported-by: Tommy Murphy \u003ctommy_murphy@hotmail.com\u003e\nFixes: https://sourceforge.net/p/openocd/tickets/376/\n"}},"c913e4d5a6cafab9a19735c440be8d0c111b2088":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2022-12-18 21:50:17.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/03/7403/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/03/7403/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/03/7403/2 \u0026\u0026 git checkout -b change-7403 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/03/7403/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/03/7403/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/03/7403/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/03/7403/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/03/7403/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"77c7abe4e7569ca8bb23dad6110c7209c8c55558","subject":"at91samd: wait for nvm ready"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-17 22:05:23.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-18 21:50:17.000000000","tz":0},"subject":"jtag: fix build with configure --enable-verbose","message":"jtag: fix build with configure --enable-verbose\n\nWith flag --enable-verbose, configure enables compiling some\nconditional code that with new gcc triggers an error:\n\terror: \u0027%04x\u0027 directive output may be truncated writing\n\tbetween 4 and 8 bytes into a region of size 5\n\t[-Werror\u003dformat-truncation\u003d]\n\nExtend the buffer to contain the full 8 bytes of %04x on a \u0027int\u0027\nand change the limit in snprintf.\nSkip the intermediate buffer \u0027s[4]\u0027.\nAlign the code to the coding style.\n\nChange-Id: Ifc8a6e4686555578a7355a1f6049471fd5e31913\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReported-by: Karl Hammar \u003ckarl@aspodata.se\u003e\nReported-by: Tommy Murphy \u003ctommy_murphy@hotmail.com\u003e\nFixes: https://sourceforge.net/p/openocd/tickets/376/\nReviewed-on: https://review.openocd.org/c/openocd/+/7403\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}