)]}'
{"id":"openocd~master~Iae5afc50e3f688e11176a52648efc9a6577a9a11","project":"openocd","branch":"master","topic":"after 0.12 release","hashtags":[],"change_id":"Iae5afc50e3f688e11176a52648efc9a6577a9a11","subject":"openocd: revert workarounds for \u0027expr\u0027 syntax change","status":"MERGED","created":"2022-12-19 17:56:07.000000000","updated":"2023-01-15 14:46:57.000000000","submitted":"2023-01-15 14:46:57.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7405-after 0.12 release","meta_rev_id":"e528e5cecd1e6f2e8893f2cc347e938076ccf3a2","_number":7405,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-01-15 14:46:57.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-01-15 14:46:57.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-12-19 18:50:55.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"833b2c55756465cb25449d8045bdcc18e8872055","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-19 17:56:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"41e666e6eb1c91e5bb2e551c7a18da515a8aa17e","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-19 17:56:52.000000000","message":"Topic set to after 0.12 release","accounts_in_message":[],"_revision_number":1},{"id":"303c2152117f6482722328e05ae0fa2b54d66bf0","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-12-19 18:50:55.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/17230/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/16432/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"5aa9a7343b2b27d97f655fcf3d5bda1455536142","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-12-19 18:54:08.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"9133a76c463f67d7b1706f0c0918e19904581723","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-01-15 13:21:43.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"e528e5cecd1e6f2e8893f2cc347e938076ccf3a2","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-01-15 14:46:57.000000000","message":"Change has been successfully cherry-picked as 95603fae18f81eebdafc5b318e70f9e2cdefab9e","accounts_in_message":[],"_revision_number":2}],"current_revision":"95603fae18f81eebdafc5b318e70f9e2cdefab9e","revisions":{"83aa545463e63878f2de84920b860bbe886ba53c":{"kind":"REWORK","_number":1,"created":"2022-12-19 17:56:07.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/05/7405/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/05/7405/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/05/7405/1 \u0026\u0026 git checkout -b change-7405 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/05/7405/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/05/7405/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/05/7405/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/05/7405/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/05/7405/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"77c281d2df25621782b48d0a45846b93fba3860d","subject":"cortex_m: handle armv8m cores without security extension"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-18 18:15:57.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-18 22:44:11.000000000","tz":60},"subject":"openocd: revert workarounds for \u0027expr\u0027 syntax change","message":"openocd: revert workarounds for \u0027expr\u0027 syntax change\n\nWith OpenOCD v0.12.0 released, drop the workarounds for \u0027expr\u0027\nsyntax change by reverting:\n- commit 320043c054dc (\"openocd: fix for polling during \"expr\"\n  computation\");\n- commit c7eaaf620488 (\"openocd: prepare for jimtcl 0.81 \u0027expr\u0027\n  syntax change\").\n\nReplace the call to target_call_timer_callbacks_now() with call\nto target_call_timer_callbacks().\n\nChange-Id: Iae5afc50e3f688e11176a52648efc9a6577a9a11\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"95603fae18f81eebdafc5b318e70f9e2cdefab9e":{"kind":"REWORK","_number":2,"created":"2023-01-15 14:46:57.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/05/7405/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/05/7405/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/05/7405/2 \u0026\u0026 git checkout -b change-7405 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/05/7405/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/05/7405/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/05/7405/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/05/7405/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/05/7405/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"da34e36cdb542eac9370957b10853184f870e495","subject":"nds32: drop it, together with aice adapter driver"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-12-18 18:15:57.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-01-15 14:46:57.000000000","tz":0},"subject":"openocd: revert workarounds for \u0027expr\u0027 syntax change","message":"openocd: revert workarounds for \u0027expr\u0027 syntax change\n\nWith OpenOCD v0.12.0 released, drop the workarounds for \u0027expr\u0027\nsyntax change by reverting:\n- commit 320043c054dc (\"openocd: fix for polling during \"expr\"\n  computation\");\n- commit c7eaaf620488 (\"openocd: prepare for jimtcl 0.81 \u0027expr\u0027\n  syntax change\").\n\nReplace the call to target_call_timer_callbacks_now() with call\nto target_call_timer_callbacks().\n\nChange-Id: Iae5afc50e3f688e11176a52648efc9a6577a9a11\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/7405\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}